)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"660231cedf01d317fdd49df739e48d4e1929318b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-05-14 16:27:56 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XenAPI: Pass expected return codes to resize2fs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"None is not tolerated by ProcessUtils, therefore make sure that [0] is passed as the"},{"line_number":10,"context_line":"expected return code"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_42a188f7","line":8,"updated":"2018-05-14 16:09:42.000000000","message":"The information from the bug report would have been good to have in the commit message, otherwise this is really sparse.\n\nPatch I6c695c04ae586fec6adc354257638116277dda88 (https://review.openstack.org/#/c/552242/) moved disk resizing into privsep. Unforutunately \"None\" was passed as the expected return code, which is not understood by processutils.\nFurther, Tempest flavor resizing moves from m1.nano to m1.micro, both of which have root_gb\u003d0 thus skipping the resize code - so Tempest didn\u0027t spot this error.","commit_id":"eec0fe59ff08285181ac6c74ffcc36348b692b69"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b7386abc876ae38d97ec06a80f36896619776e0e","unresolved":false,"context_lines":[{"line_number":2294,"context_line":"    if new_sectors \u003c old_sectors:"},{"line_number":2295,"context_line":"        # Resizing down, resize filesystem before partition resize"},{"line_number":2296,"context_line":"        try:"},{"line_number":2297,"context_line":"            nova.privsep.fs.resize2fs(partition_path, [0], size\u003d\u0027%ds\u0027 % size)"},{"line_number":2298,"context_line":"        except processutils.ProcessExecutionError as exc:"},{"line_number":2299,"context_line":"            LOG.error(six.text_type(exc))"},{"line_number":2300,"context_line":"            reason \u003d _(\"Shrinking the filesystem down with resize2fs \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_674e16c2","line":2297,"range":{"start_line":2297,"start_character":54,"end_line":2297,"end_character":57},"updated":"2018-05-14 16:03:27.000000000","message":"We could also pass True here and do the same thing but this is more explicit what\u0027s going on. I\u0027m not sure which is better.\n\nI\u0027m leaning toward thinking the privsep resize2fs methods should default check_exit_code\u003dTrue and let callers override it if they want to. That was also the previous behavior prior to the privsep change. We could look at that possibility later on.","commit_id":"eec0fe59ff08285181ac6c74ffcc36348b692b69"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"660231cedf01d317fdd49df739e48d4e1929318b","unresolved":false,"context_lines":[{"line_number":2294,"context_line":"    if new_sectors \u003c old_sectors:"},{"line_number":2295,"context_line":"        # Resizing down, resize filesystem before partition resize"},{"line_number":2296,"context_line":"        try:"},{"line_number":2297,"context_line":"            nova.privsep.fs.resize2fs(partition_path, [0], size\u003d\u0027%ds\u0027 % size)"},{"line_number":2298,"context_line":"        except processutils.ProcessExecutionError as exc:"},{"line_number":2299,"context_line":"            LOG.error(six.text_type(exc))"},{"line_number":2300,"context_line":"            reason \u003d _(\"Shrinking the filesystem down with resize2fs \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a2df3c67","line":2297,"range":{"start_line":2297,"start_character":54,"end_line":2297,"end_character":57},"in_reply_to":"5f7c97a3_674e16c2","updated":"2018-05-14 16:09:42.000000000","message":"I also thought about making the resize2fs privsep interface better by handling None and defaulting appropriately.","commit_id":"eec0fe59ff08285181ac6c74ffcc36348b692b69"}]}