)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"70a75b1dbc6fafddc6cf0568ee1bbe302f88ddcb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"considered more or less branchless, so people looking at the API reference"},{"line_number":17,"context_line":"can apply it to older deployments of nova before os-fixed-ips was removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"TODO: rebase on https://review.openstack.org/#/c/567682/1 to update reno"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Part of blueprint remova-nova-network"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_549dae54","line":19,"updated":"2018-06-26 13:12:22.000000000","message":"This can be removed now right?","commit_id":"ffbec781acefe17ce8c968c694571b53d4f53ae1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e5292b147557fc102f42058c069701691441b639","unresolved":false,"context_lines":[{"line_number":16,"context_line":"considered more or less branchless, so people looking at the API reference"},{"line_number":17,"context_line":"can apply it to older deployments of nova before os-fixed-ips was removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"TODO: rebase on https://review.openstack.org/#/c/567682/1 to update reno"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Part of blueprint remova-nova-network"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_579290a0","line":19,"in_reply_to":"5f7c97a3_549dae54","updated":"2018-06-26 13:22:03.000000000","message":"Done","commit_id":"ffbec781acefe17ce8c968c694571b53d4f53ae1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36878c53ea83813cc0b43cd6a37ff2819a496f6d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"TODO: rebase on https://review.openstack.org/#/c/567682/1 to update reno"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Part of blueprint remova-nova-network"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I61f758ff9285448d431b45f67c70286082b4ee90"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_541fee6e","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":24},"updated":"2018-06-26 13:12:49.000000000","message":"remove - need to fix the topic branch as well","commit_id":"ffbec781acefe17ce8c968c694571b53d4f53ae1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e5292b147557fc102f42058c069701691441b639","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"TODO: rebase on https://review.openstack.org/#/c/567682/1 to update reno"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Part of blueprint remova-nova-network"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I61f758ff9285448d431b45f67c70286082b4ee90"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_3797d492","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":24},"in_reply_to":"5f7c97a3_541fee6e","updated":"2018-06-26 13:22:03.000000000","message":"Done","commit_id":"ffbec781acefe17ce8c968c694571b53d4f53ae1"}],"api-ref/source/os-fixed-ips.inc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"70a75b1dbc6fafddc6cf0568ee1bbe302f88ddcb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. warning::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"   These APIs are proxy calls to the Network service. Nova has"},{"line_number":10,"context_line":"   deprecated all the proxy APIs and users should use the native APIs"},{"line_number":11,"context_line":"   instead. These will fail with a 404 starting from microversion 2.36."},{"line_number":12,"context_line":"   It was removed in the 18.0.0 Rocky release."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Shows data for a fixed IP, such as host name, CIDR, and address. Also,"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5f7c97a3_54712edd","line":11,"range":{"start_line":9,"start_character":3,"end_line":11,"end_character":11},"updated":"2018-06-26 13:12:22.000000000","message":"We should probably update this since there are no proxy calls to neutron for these APIs, so maybe re-word this to:\n\n\"This API only works with **nova-network** which is deprecated.\"","commit_id":"ffbec781acefe17ce8c968c694571b53d4f53ae1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e5292b147557fc102f42058c069701691441b639","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":".. warning::"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"   These APIs are proxy calls to the Network service. Nova has"},{"line_number":10,"context_line":"   deprecated all the proxy APIs and users should use the native APIs"},{"line_number":11,"context_line":"   instead. These will fail with a 404 starting from microversion 2.36."},{"line_number":12,"context_line":"   It was removed in the 18.0.0 Rocky release."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Shows data for a fixed IP, such as host name, CIDR, and address. Also,"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5f7c97a3_977ca871","line":11,"range":{"start_line":9,"start_character":3,"end_line":11,"end_character":11},"in_reply_to":"5f7c97a3_54712edd","updated":"2018-06-26 13:22:03.000000000","message":"Done","commit_id":"ffbec781acefe17ce8c968c694571b53d4f53ae1"}],"nova/api/openstack/compute/fixed_ips.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"70a75b1dbc6fafddc6cf0568ee1bbe302f88ddcb","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        attrs \u003d [\u0027network\u0027, \u0027instance\u0027]"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            fixed_ip \u003d objects.FixedIP.get_by_address(context, id,"},{"line_number":51,"context_line":"                                                      expected_attrs\u003dattrs)"},{"line_number":52,"context_line":"        except exception.FixedIpNotFoundForAddress as ex:"},{"line_number":53,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dex.format_message())"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_54cb6e48","side":"PARENT","line":50,"range":{"start_line":50,"start_character":39,"end_line":50,"end_character":53},"updated":"2018-06-26 13:12:22.000000000","message":"Hmm, so we don\u0027t call the network API (neutron or nova-network) directly at all for this, it\u0027s all stuff done in the database (granted it would be the cell database and this API doesn\u0027t support multiple cells). But is this nova-network only or does the neutron API also store fixed IP information in the nova cell database? I was confused because the API reference says these are proxies to the network service, which means neutron:\n\nhttps://developer.openstack.org/api-ref/compute/#fixed-ips-os-fixed-ips-deprecated\n\nBut these aren\u0027t proxying calls to neutron at all.\n\nThe only place in the neutron API code that uses objects.FixedIP is when building a FloatingIP object:\n\nhttps://github.com/openstack/nova/blob/08a618d0c486cae2676803cdc0d9da0d9264bec9/nova/network/neutronv2/api.py#L2035\n\nAnd I think that\u0027s just so that the floating IP API, which supports both nova-network and proxying to neutron, can work with the same data object (the FloatingIP object):\n\nIe60fb8661195eec9c01a57129efe8145504789e1","commit_id":"7968670d5222c25cf49f00140be04fb3d307b627"}]}