)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5cc36e5da1c90622a9b4e83e8f64af7fe49fdf7d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"So instead return a 200 to indicate a success and wait for long"},{"line_number":15,"context_line":"time, we can properly return 500 as it\u0027s anyway a connection issue."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"There are some concern about whether we should return 500 error,"},{"line_number":18,"context_line":"we should not lie about the result, if it\u0027s an internal error,"},{"line_number":19,"context_line":"we should report it instead fake a success and delay the error"},{"line_number":20,"context_line":"occurance as it will eventually be there."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_c2bac16c","line":17,"updated":"2018-05-24 18:33:40.000000000","message":"The concern is that this API used to just not check the project_id at all, and would gladly accept it, so that\u0027s why the code would log something and continue. Now this would be a hard failure when we\u0027re not sure why we failed to connect to keystone.","commit_id":"2465f0f5601363004bf67909579fea78425b1edb"}],"nova/api/openstack/identity.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a7528cdd23135c458fcad217335e81c2786161c3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"},{"line_number":51,"context_line":"        # we\u0027ll take the pass and default to everything being ok."},{"line_number":52,"context_line":"        msg \u003d \"Unable to contact keystone to verify project_id\""},{"line_number":53,"context_line":"        LOG.error(msg)"},{"line_number":54,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if resp:"},{"line_number":57,"context_line":"        # All is good with this 20x status"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_92e9b2b8","line":54,"range":{"start_line":52,"start_character":7,"end_line":54,"end_character":49},"updated":"2018-05-21 07:33:38.000000000","message":"Same as the other patch, shouldn\u0027t we avoid raise 500 to users?","commit_id":"17058f4eb4667b89e53663b950a51d11aa4b1fdd"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"88e0311f5e4314365679692bfd38f4a2b33b95d1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"},{"line_number":51,"context_line":"        # we\u0027ll take the pass and default to everything being ok."},{"line_number":52,"context_line":"        msg \u003d \"Unable to contact keystone to verify project_id\""},{"line_number":53,"context_line":"        LOG.error(msg)"},{"line_number":54,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if resp:"},{"line_number":57,"context_line":"        # All is good with this 20x status"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4ae01ecd","line":54,"range":{"start_line":52,"start_character":7,"end_line":54,"end_character":49},"in_reply_to":"5f7c97a3_92e9b2b8","updated":"2018-05-23 08:57:45.000000000","message":"nope, I think if it\u0027s a internal error\nwe should be honst\n\nthis can make it easier to find real problem...","commit_id":"17058f4eb4667b89e53663b950a51d11aa4b1fdd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4a13f3a2f70300c1d29ed42bc0737186d0704f20","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"},{"line_number":51,"context_line":"        # we\u0027ll take the pass and default to everything being ok."},{"line_number":52,"context_line":"        msg \u003d \"Unable to contact keystone to verify project_id\""},{"line_number":53,"context_line":"        LOG.error(msg)"},{"line_number":54,"context_line":"        raise webob.exc.HTTPInternalServerError()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_7b33c162","line":51,"range":{"start_line":51,"start_character":10,"end_line":51,"end_character":65},"updated":"2018-10-17 22:34:31.000000000","message":"Here also needs to be updated.","commit_id":"2465f0f5601363004bf67909579fea78425b1edb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4a13f3a2f70300c1d29ed42bc0737186d0704f20","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"},{"line_number":51,"context_line":"        # we\u0027ll take the pass and default to everything being ok."},{"line_number":52,"context_line":"        msg \u003d \"Unable to contact keystone to verify project_id\""},{"line_number":53,"context_line":"        LOG.error(msg)"},{"line_number":54,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_bb12b9b2","line":52,"updated":"2018-10-17 22:34:31.000000000","message":"There are similar handlings at line 69 and 78 also and do we need to consider them also here?","commit_id":"2465f0f5601363004bf67909579fea78425b1edb"}]}