)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"530237347910629abca0edccb5718675326fd292","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EndpointNotFound will be made when the keystone v3 API is not"},{"line_number":10,"context_line":"found in the service catalog, or if the v2.0 endpoint was"},{"line_number":11,"context_line":"registered as the root endpoint. We treat this the same as 404"},{"line_number":12,"context_line":"previously but it\u0027s not correct as it\u0027s telling user something"},{"line_number":13,"context_line":"is missing, but in reality it\u0027s an internal error"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_6d7d766b","line":11,"range":{"start_line":11,"start_character":59,"end_line":11,"end_character":62},"updated":"2018-09-07 23:14:29.000000000","message":"This seems wrong because the \"failure\" is webob.exc.HTTPBadRequest and that is 400 instead.","commit_id":"e98ce611767d998db77a02638d698fe5fca9b236"}],"nova/api/openstack/identity.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c7a9c52cc3ae2ede97eb5ccd5fee4eacd0251f18","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_32cf7e80","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":49},"updated":"2018-05-21 07:23:48.000000000","message":"is this a HTTP 500? I thought we should avoid http 500? Maybe we should translate this to something else?","commit_id":"b74dbdd295f85ba1b8199fe4efb64a3131798202"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"208022dfe82285cac412b98406ca243fc174f25c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4abb3ec3","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":49},"in_reply_to":"5f7c97a3_32cf7e80","updated":"2018-05-23 08:56:34.000000000","message":"It it 500, per bug indicated, \n\nraise 400 is cheating user and may lead to further confusion","commit_id":"b74dbdd295f85ba1b8199fe4efb64a3131798202"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b052f32ec51a4dbf9b272f61071941869e09bba1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_10ba02c0","line":47,"updated":"2018-05-30 13:39:54.000000000","message":"As UX behavior changed probably you need reno.","commit_id":"e98ce611767d998db77a02638d698fe5fca9b236"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"530237347910629abca0edccb5718675326fd292","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4dc8baa6","line":47,"in_reply_to":"3f79a3b5_e43206a7","updated":"2018-09-07 23:14:29.000000000","message":"I feel it is better to include actual error message like line 44-46 into the error response instead of \"Project ID %s is not a valid project.\" for solving and actual error.","commit_id":"e98ce611767d998db77a02638d698fe5fca9b236"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f77803330f72b54107ae5f7066d2cf9006f8b108","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e43206a7","line":47,"in_reply_to":"5f7c97a3_10ba02c0","updated":"2018-08-27 13:39:07.000000000","message":"we actully might need a microverion bump not just a reno.\nwe are changing api return codes so clients will have to be updated. older clients may want to still use the old behavior explcitly via a microverion until updated.\n\nthat said im not familar with this part of the nova code base but this looks like old proxy code to the identity service and clients should really be going to keystone directly instead of nova.","commit_id":"e98ce611767d998db77a02638d698fe5fca9b236"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"530237347910629abca0edccb5718675326fd292","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise webob.exc.HTTPInternalServerError()"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"},{"line_number":50,"context_line":"        # or nova isn\u0027t configured for the interface to talk to it;"},{"line_number":51,"context_line":"        # we\u0027ll take the pass and default to everything being ok."},{"line_number":52,"context_line":"        LOG.info(\"Unable to contact keystone to verify project_id\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_eddd066d","line":49,"range":{"start_line":49,"start_character":30,"end_line":49,"end_character":70},"updated":"2018-09-07 23:14:29.000000000","message":"TBH, I am not sure what is different between this case and the above EndpointNotFound case and why the one should return an error response and the other should return success.","commit_id":"e98ce611767d998db77a02638d698fe5fca9b236"}]}