)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10ee00478abda6fbb231f0a44efbd000b0858567","unresolved":false,"context_lines":[{"line_number":11,"context_line":"regression in the nova-lvm experimental job as n-cpu attempted to run"},{"line_number":12,"context_line":"qemu-img info against block devices as an unprivileged user."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For the time being we should skip any attempt to use this command"},{"line_number":15,"context_line":"against block devices until the disk_api layer can make privileged"},{"line_number":16,"context_line":"calls using privsep."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-bug: #1771700"},{"line_number":19,"context_line":"Change-Id: I9653f81ec716f80eb638810f65e2d3cdfeedaa22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_92e07f28","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":20},"updated":"2018-05-28 09:26:51.000000000","message":"We don\u0027t want fix that because the patch is going to be backported?","commit_id":"fda48219a378d09a9a363078ba161d7f54e32c0a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3b08cd2ed734e07626bd3e15694a1a86ff353af7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"regression in the nova-lvm experimental job as n-cpu attempted to run"},{"line_number":12,"context_line":"qemu-img info against block devices as an unprivileged user."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For the time being we should skip any attempt to use this command"},{"line_number":15,"context_line":"against block devices until the disk_api layer can make privileged"},{"line_number":16,"context_line":"calls using privsep."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-bug: #1771700"},{"line_number":19,"context_line":"Change-Id: I9653f81ec716f80eb638810f65e2d3cdfeedaa22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_f03d2b8e","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"5f7c97a3_92e07f28","updated":"2018-05-28 12:14:56.000000000","message":"Yeah indeed, that\u0027s additional work we can complete outside of this bugfix that we also need to backport.","commit_id":"fda48219a378d09a9a363078ba161d7f54e32c0a"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9c3f3fab917950d7483244357c05a26da3493b8d","unresolved":false,"context_lines":[{"line_number":14327,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027)"},{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api\u0027)"},{"line_number":14329,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14330,"context_line":"            mock_get_volume_size, mock_disk_api):"},{"line_number":14331,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"},{"line_number":14332,"context_line":"        reported as the same and that the disk_api is not used."},{"line_number":14333,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_76473cbe","line":14330,"range":{"start_line":14330,"start_character":12,"end_line":14330,"end_character":46},"updated":"2018-05-18 21:31:33.000000000","message":"These are in the wrong order right...so how is this test passing? Missing assertions?","commit_id":"00dcca59d8439af8ec06d26288e9781283a6b5a1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9a000c9fdbdfcd78c48a315a0dadf6849b95a663","unresolved":false,"context_lines":[{"line_number":14327,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027)"},{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api\u0027)"},{"line_number":14329,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14330,"context_line":"            mock_get_volume_size, mock_disk_api):"},{"line_number":14331,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"},{"line_number":14332,"context_line":"        reported as the same and that the disk_api is not used."},{"line_number":14333,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_8650a1d6","line":14330,"range":{"start_line":14330,"start_character":12,"end_line":14330,"end_character":46},"in_reply_to":"5f7c97a3_76473cbe","updated":"2018-05-19 08:49:16.000000000","message":"Yeah, I wasn\u0027t asserting that get_volume_size was called, just that get_disk_size and get_allocated_disk_size were not. Thanks!","commit_id":"00dcca59d8439af8ec06d26288e9781283a6b5a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67131f9883f174e0b6c8b5337d321384d8e1e6dd","unresolved":false,"context_lines":[{"line_number":14325,"context_line":"                          drvr._get_disk_over_committed_size_total)"},{"line_number":14326,"context_line":""},{"line_number":14327,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027)"},{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api\u0027)"},{"line_number":14329,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14330,"context_line":"            mock_disk_api, mock_get_volume_size):"},{"line_number":14331,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_9d946bea","line":14328,"updated":"2018-05-20 16:27:44.000000000","message":"We can just add new_callable\u003dmock.NonCallableMock here and then anything that touches this will explode.","commit_id":"75f5d4d5971de3b596a3578efc4fe308daaa5f8d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db7aa9a729780300d92fdc08667842d4f7f2a19f","unresolved":false,"context_lines":[{"line_number":14356,"context_line":"        disk_info \u003d drvr._get_instance_disk_info_from_config(config,"},{"line_number":14357,"context_line":"                                                             block_device_info)"},{"line_number":14358,"context_line":""},{"line_number":14359,"context_line":"        mock_get_volume_size.called_once_with(mock.sentinel.volume_path)"},{"line_number":14360,"context_line":"        mock_disk_api.get_disk_size.assert_not_called()"},{"line_number":14361,"context_line":"        mock_disk_api.get_allocated_disk_size.assert_not_called()"},{"line_number":14362,"context_line":"        self.assertEqual(disk_info[0][\u0027disk_size\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_3dd517b8","line":14359,"range":{"start_line":14359,"start_character":29,"end_line":14359,"end_character":45},"updated":"2018-05-20 16:20:32.000000000","message":"This isn\u0027t a real assertion method on the mock, it should be assert_called_once_with.","commit_id":"75f5d4d5971de3b596a3578efc4fe308daaa5f8d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9dd17816ccc8ed8dc597815d3d0acfb3dff01143","unresolved":false,"context_lines":[{"line_number":14326,"context_line":""},{"line_number":14327,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027)"},{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api.get_disk_size\u0027,"},{"line_number":14329,"context_line":"                new_callable\u003dmock.NonCallableMock)"},{"line_number":14330,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14331,"context_line":"            mock_disk_api, mock_get_volume_size):"},{"line_number":14332,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_c317feed","line":14329,"range":{"start_line":14329,"start_character":16,"end_line":14329,"end_character":49},"updated":"2018-05-29 09:49:50.000000000","message":"First time I have paid attention to this being used","commit_id":"fda48219a378d09a9a363078ba161d7f54e32c0a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d0591870aa962e4dca3ac5e3ce372ecfd8e0a7df","unresolved":false,"context_lines":[{"line_number":14326,"context_line":""},{"line_number":14327,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027)"},{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api.get_disk_size\u0027,"},{"line_number":14329,"context_line":"                new_callable\u003dmock.NonCallableMock)"},{"line_number":14330,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14331,"context_line":"            mock_disk_api, mock_get_volume_size):"},{"line_number":14332,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_23f7d28d","line":14329,"range":{"start_line":14329,"start_character":16,"end_line":14329,"end_character":49},"in_reply_to":"5f7c97a3_c317feed","updated":"2018-05-29 10:03:10.000000000","message":"Yes actually me as-well :)","commit_id":"fda48219a378d09a9a363078ba161d7f54e32c0a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10ee00478abda6fbb231f0a44efbd000b0858567","unresolved":false,"context_lines":[{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api.get_disk_size\u0027,"},{"line_number":14329,"context_line":"                new_callable\u003dmock.NonCallableMock)"},{"line_number":14330,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14331,"context_line":"            mock_disk_api, mock_get_volume_size):"},{"line_number":14332,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"},{"line_number":14333,"context_line":"        reported as the same and that the disk_api is not used."},{"line_number":14334,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_92671fb8","line":14331,"range":{"start_line":14331,"start_character":12,"end_line":14331,"end_character":25},"updated":"2018-05-28 09:26:51.000000000","message":"You should probably add an assertion somewhere to ensure that is not called.","commit_id":"fda48219a378d09a9a363078ba161d7f54e32c0a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3b08cd2ed734e07626bd3e15694a1a86ff353af7","unresolved":false,"context_lines":[{"line_number":14328,"context_line":"    @mock.patch(\u0027nova.virt.disk.api.get_disk_size\u0027,"},{"line_number":14329,"context_line":"                new_callable\u003dmock.NonCallableMock)"},{"line_number":14330,"context_line":"    def test_get_instance_disk_info_from_config_block_devices(self,"},{"line_number":14331,"context_line":"            mock_disk_api, mock_get_volume_size):"},{"line_number":14332,"context_line":"        \"\"\"Test that for block devices the actual and virtual sizes are"},{"line_number":14333,"context_line":"        reported as the same and that the disk_api is not used."},{"line_number":14334,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_b09813c0","line":14331,"range":{"start_line":14331,"start_character":12,"end_line":14331,"end_character":25},"in_reply_to":"5f7c97a3_92671fb8","updated":"2018-05-28 12:14:56.000000000","message":"Matt took care of this on L14329 by using NonCallableMock, if anything calls mock_disk_api we would see a TypeError raised.","commit_id":"fda48219a378d09a9a363078ba161d7f54e32c0a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6795fef8e3133c1d39e962b35fa0d9f8d6a8a7be","unresolved":false,"context_lines":[{"line_number":7853,"context_line":"                # NOTE(lyarwood): As above, we should be using disk_api to"},{"line_number":7854,"context_line":"                # fetch the virt-size but can\u0027t as it currently runs qemu-img"},{"line_number":7855,"context_line":"                # as an unprivileged user, causing a failure for block devices."},{"line_number":7856,"context_line":"                virt_size \u003d dk_size"},{"line_number":7857,"context_line":"            else:"},{"line_number":7858,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) - unable to \u0027"},{"line_number":7859,"context_line":"                          \u0027determine if volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f24378ae","line":7856,"updated":"2018-05-17 15:09:18.000000000","message":"OK so this is what we used to do:\n\nhttps://review.openstack.org/#/c/567899/3/nova/virt/libvirt/driver.py@a7855\n\nBefore the change that caused this regression.\n\nWith this change, the nova-lvm job is passing again.","commit_id":"9b7b442451db332adda63ed8a44cb16efcbda66d"}]}