)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"change_message_id":"47a1a3dc02e1ac5ca211f751603db8373aff57a8","unresolved":false,"context_lines":[{"line_number":987,"context_line":"            return None"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        try:"},{"line_number":990,"context_line":"            messaging.TransportURL.parse(conf\u003dCONF, url\u003dtransport_url)"},{"line_number":991,"context_line":"        except (messaging.InvalidTransportURL, ValueError) as e:"},{"line_number":992,"context_line":"            print(_(\u0027Invalid transport URL: %s\u0027) % six.text_type(e))"},{"line_number":993,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a380584b","line":990,"range":{"start_line":990,"start_character":41,"end_line":990,"end_character":50},"updated":"2018-06-15 07:22:02.000000000","message":"Method is defined as: \nhttps://github.com/openstack/oslo.messaging/blob/b34ab8b1cc9f4d513a2927c102dbbe82031d9c2a/oslo_messaging/transport.py#L458)\ndef parse(cls, conf, url\u003dNone, aliases\u003dNone):\n\nShouldn\u0027t it be called with (CONF, url\u003dtransport_url) instead?","commit_id":"dc01690f48327ca82560d468cdd281b9ba120b25"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"857fbe0f7cfcc35da96b09bce0d5ec30dd8c11ee","unresolved":false,"context_lines":[{"line_number":987,"context_line":"            return None"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        try:"},{"line_number":990,"context_line":"            messaging.TransportURL.parse(conf\u003dCONF, url\u003dtransport_url)"},{"line_number":991,"context_line":"        except (messaging.InvalidTransportURL, ValueError) as e:"},{"line_number":992,"context_line":"            print(_(\u0027Invalid transport URL: %s\u0027) % six.text_type(e))"},{"line_number":993,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c661e2aa","line":990,"range":{"start_line":990,"start_character":41,"end_line":990,"end_character":50},"in_reply_to":"5f7c97a3_a380584b","updated":"2018-06-15 08:11:19.000000000","message":"it makes no difference, this way may look clearer","commit_id":"dc01690f48327ca82560d468cdd281b9ba120b25"}],"nova/tests/unit/test_nova_manage.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0fa2eba9bc84b3696197e21952adcda7679fdc99","unresolved":false,"context_lines":[{"line_number":1781,"context_line":"        self.assertIn(\u0027exists\u0027, self.output.getvalue())"},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1784,"context_line":"    def test_create_cell_use_params(self, mock_transport_parse):"},{"line_number":1785,"context_line":"        ctxt \u003d context.get_context()"},{"line_number":1786,"context_line":"        kwargs \u003d dict("},{"line_number":1787,"context_line":"            name\u003d\u0027fake-name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bfda9b48","line":1784,"range":{"start_line":1784,"start_character":42,"end_line":1784,"end_character":62},"updated":"2018-06-05 08:59:12.000000000","message":"This mock should be asserted.","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6dd90b694e9de9d24c5428f55399d50af59ff7","unresolved":false,"context_lines":[{"line_number":1781,"context_line":"        self.assertIn(\u0027exists\u0027, self.output.getvalue())"},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1784,"context_line":"    def test_create_cell_use_params(self, mock_transport_parse):"},{"line_number":1785,"context_line":"        ctxt \u003d context.get_context()"},{"line_number":1786,"context_line":"        kwargs \u003d dict("},{"line_number":1787,"context_line":"            name\u003d\u0027fake-name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_51d8607d","line":1784,"range":{"start_line":1784,"start_character":42,"end_line":1784,"end_character":62},"in_reply_to":"5f7c97a3_b4e2909f","updated":"2018-06-13 13:04:48.000000000","message":"I did the latter.","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d83e37d3b6becb8a0511cc4cc1c9dc57ce56e29f","unresolved":false,"context_lines":[{"line_number":1781,"context_line":"        self.assertIn(\u0027exists\u0027, self.output.getvalue())"},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1784,"context_line":"    def test_create_cell_use_params(self, mock_transport_parse):"},{"line_number":1785,"context_line":"        ctxt \u003d context.get_context()"},{"line_number":1786,"context_line":"        kwargs \u003d dict("},{"line_number":1787,"context_line":"            name\u003d\u0027fake-name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b4e2909f","line":1784,"range":{"start_line":1784,"start_character":42,"end_line":1784,"end_character":62},"in_reply_to":"5f7c97a3_bfda9b48","updated":"2018-06-06 22:24:54.000000000","message":"I get why you didn\u0027t; you\u0027re not testing that here.  You could put new\u003dmock.Mock() in the decorator and get rid of the arg.  Or you could just make the transport_url a valid URL and not mock anything.","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0fa2eba9bc84b3696197e21952adcda7679fdc99","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        self.assertIs(cell2.disabled, False)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1802,"context_line":"    def test_create_cell_use_config_values(self, mock_transport_parse):"},{"line_number":1803,"context_line":"        settings \u003d dict("},{"line_number":1804,"context_line":"            transport_url\u003d\u0027fake-conf-transport-url\u0027,"},{"line_number":1805,"context_line":"            database_connection\u003d\u0027fake-conf-db-connection\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7fe4030f","line":1802,"range":{"start_line":1802,"start_character":49,"end_line":1802,"end_character":69},"updated":"2018-06-05 08:59:12.000000000","message":"ditto","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0fa2eba9bc84b3696197e21952adcda7679fdc99","unresolved":false,"context_lines":[{"line_number":1818,"context_line":"        self.assertEqual(settings[\u0027transport_url\u0027], cell1.transport_url)"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1821,"context_line":"    def test_create_cell_failed_if_non_unique(self, mock_transport_parse):"},{"line_number":1822,"context_line":"        kwargs \u003d dict("},{"line_number":1823,"context_line":"            name\u003d\u0027fake-name\u0027,"},{"line_number":1824,"context_line":"            transport_url\u003d\u0027fake-transport-url\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ffb9f3eb","line":1821,"range":{"start_line":1821,"start_character":52,"end_line":1821,"end_character":72},"updated":"2018-06-05 08:59:12.000000000","message":"ditto","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0fa2eba9bc84b3696197e21952adcda7679fdc99","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"        self.assertIn(\u0027--transport-url\u0027, self.output.getvalue())"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1838,"context_line":"    def test_create_cell_failed_if_no_database_connection(self, mock_parse):"},{"line_number":1839,"context_line":"        self.flags(connection\u003dNone, group\u003d\u0027database\u0027)"},{"line_number":1840,"context_line":"        status \u003d self.commands.create_cell(transport_url\u003d\u0027fake-transport-url\u0027)"},{"line_number":1841,"context_line":"        self.assertEqual(1, status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bfb37b0a","line":1838,"range":{"start_line":1838,"start_character":64,"end_line":1838,"end_character":74},"updated":"2018-06-05 08:59:12.000000000","message":"ditto","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0fa2eba9bc84b3696197e21952adcda7679fdc99","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"        self.assertIn(\u0027--database_connection\u0027, self.output.getvalue())"},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"    @mock.patch(\u0027oslo_messaging.TransportURL.parse\u0027)"},{"line_number":1845,"context_line":"    def test_create_cell_pre_disabled(self, mock_transport_parse):"},{"line_number":1846,"context_line":"        ctxt \u003d context.get_context()"},{"line_number":1847,"context_line":"        kwargs \u003d dict("},{"line_number":1848,"context_line":"            name\u003d\u0027fake-name1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dfb8b7e6","line":1845,"range":{"start_line":1845,"start_character":44,"end_line":1845,"end_character":64},"updated":"2018-06-05 08:59:12.000000000","message":"ditto","commit_id":"a6a767483ce76673f2b03fdbb5f1f706f184ad27"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1dfb923bee0721e312b2b5b1432a9b222b4e503f","unresolved":false,"context_lines":[{"line_number":1784,"context_line":"        ctxt \u003d context.get_context()"},{"line_number":1785,"context_line":"        kwargs \u003d dict("},{"line_number":1786,"context_line":"            name\u003d\u0027fake-name\u0027,"},{"line_number":1787,"context_line":"            transport_url\u003d\u0027http://fake-transport-url\u0027,"},{"line_number":1788,"context_line":"            database_connection\u003d\u0027fake-db-connection\u0027)"},{"line_number":1789,"context_line":"        status \u003d self.commands.create_cell(verbose\u003dTrue, **kwargs)"},{"line_number":1790,"context_line":"        self.assertEqual(0, status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_aacf0526","line":1787,"range":{"start_line":1787,"start_character":27,"end_line":1787,"end_character":31},"updated":"2018-06-26 02:14:44.000000000","message":"nit: rabbit, amqp or zmq is better. kafka is also good.\n\nhttps://docs.openstack.org/oslo.messaging/latest/admin/AMQP1.0.html#configuration","commit_id":"bc6ca87a6a01ecbda926a78d07cadbd4e3ab97e0"}]}