)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9970ecdebbf3a39bc138fca87190475fd0c685f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-22 11:17:07 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move resize and rebuild operations to Flavor objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes the compute_api resize and rebuild operations use"},{"line_number":10,"context_line":"Flavor objects for their reservation and record-keeping activities."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F96N4%3D","line":7,"updated":"2013-12-04 16:09:08.000000000","message":"You\u0027re also changing restore here, should that be called out?","commit_id":"72746c3f92785bf5aa360383ec1c2c3eea0d6168"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9970ecdebbf3a39bc138fca87190475fd0c685f4","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"            # of other places, I think it should be addressed in a DB"},{"line_number":2058,"context_line":"            # layer overhaul."},{"line_number":2059,"context_line":"            sys_metadata \u003d self.db.instance_system_metadata_get(context,"},{"line_number":2060,"context_line":"                    instance[\u0027uuid\u0027])"},{"line_number":2061,"context_line":"            orig_sys_metadata \u003d dict(sys_metadata)"},{"line_number":2062,"context_line":"            # Remove the old keys"},{"line_number":2063,"context_line":"            for key in sys_metadata.keys():"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F96PE%3D","line":2060,"updated":"2013-12-04 16:09:08.000000000","message":"Not part of this patch but this could be instance.uuid now right?","commit_id":"72746c3f92785bf5aa360383ec1c2c3eea0d6168"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9970ecdebbf3a39bc138fca87190475fd0c685f4","unresolved":false,"context_lines":[{"line_number":2267,"context_line":"        be migrated to a new host and resized to the new flavor_id."},{"line_number":2268,"context_line":"        \"\"\""},{"line_number":2269,"context_line":"        self._check_auto_disk_config(instance, **extra_instance_updates)"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"        current_instance_type \u003d flavors.extract_flavor(instance)"},{"line_number":2272,"context_line":""},{"line_number":2273,"context_line":"        # If flavor_id is not provided, only migrate the instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F96OA%3D","line":2270,"updated":"2013-12-04 16:09:08.000000000","message":"What about this?","commit_id":"72746c3f92785bf5aa360383ec1c2c3eea0d6168"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9970ecdebbf3a39bc138fca87190475fd0c685f4","unresolved":false,"context_lines":[{"line_number":6245,"context_line":"                          \"new password\")"},{"line_number":6246,"context_line":""},{"line_number":6247,"context_line":"    def test_rebuild_no_image(self):"},{"line_number":6248,"context_line":"        instance \u003d instance_obj.Instance.get_by_uuid("},{"line_number":6249,"context_line":"            self.context,"},{"line_number":6250,"context_line":"            self._create_fake_instance(params\u003d{\u0027image_ref\u0027: \u0027\u0027})[\u0027uuid\u0027])"},{"line_number":6251,"context_line":"        instance_uuid \u003d instance[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F96NE%3D","line":6248,"updated":"2013-12-04 16:09:08.000000000","message":"So...shouldn\u0027t you be converting the test cases to use objects now too?  There is a helper method in here somewhere to convert an instance dict to an object.","commit_id":"72746c3f92785bf5aa360383ec1c2c3eea0d6168"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1711f0606155486dffe2c8e787c919ed20febc45","unresolved":false,"context_lines":[{"line_number":6498,"context_line":"                          \"new password\")"},{"line_number":6499,"context_line":""},{"line_number":6500,"context_line":"    def test_rebuild_no_image(self):"},{"line_number":6501,"context_line":"        instance \u003d self._create_fake_instance_obj(params\u003d{\u0027image_ref\u0027: \u0027\u0027})"},{"line_number":6502,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":6503,"context_line":"        self.stubs.Set(fake_image._FakeImageService, \u0027show\u0027, self.fake_show)"},{"line_number":6504,"context_line":"        self.compute.run_instance(self.context, instance, {}, {}, None, None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F95vA%3D","line":6501,"updated":"2013-12-04 17:37:28.000000000","message":"Thanks, this looks better, enforces the object usage.","commit_id":"c7a5b2d56accc641609f53a98dc4b218f66c5fab"}]}
