)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4281d7fc92c3e900d25b0a1a5a2502c556862d77","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds the requested_networks field in the RequestSpec object."},{"line_number":10,"context_line":"The change is needed because currently, there was no way to retrieve"},{"line_number":11,"context_line":"the requested networks when trying to rebuild instances burried in"},{"line_number":12,"context_line":"cell0."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"When an instance fails to be scheduled and it gets burried in cell0,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_8fd2f6d0","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":63},"updated":"2019-03-04 18:18:07.000000000","message":"buried","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"0e84003ac26b22a1a8df9a91d8eaf0a25df254ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds the requested_networks field in the RequestSpec object."},{"line_number":10,"context_line":"The change is needed because currently, there was no way to retrieve"},{"line_number":11,"context_line":"the requested networks when trying to rebuild instances burried in"},{"line_number":12,"context_line":"cell0."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"When an instance fails to be scheduled and it gets burried in cell0,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_2043ca15","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":63},"in_reply_to":"9fdfeff1_8fd2f6d0","updated":"2019-03-05 15:36:46.000000000","message":"Done","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4281d7fc92c3e900d25b0a1a5a2502c556862d77","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the requested networks when trying to rebuild instances burried in"},{"line_number":12,"context_line":"cell0."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"When an instance fails to be scheduled and it gets burried in cell0,"},{"line_number":15,"context_line":"we will use the new field in the RequestSpec object to store a"},{"line_number":16,"context_line":"NetworkRequestList containing the networks requested by the user."},{"line_number":17,"context_line":"This way, when we try to rebuild the instance we can retrieve this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_8fa0b644","line":14,"range":{"start_line":14,"start_character":51,"end_line":14,"end_character":58},"updated":"2019-03-04 18:18:07.000000000","message":"buried","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"0e84003ac26b22a1a8df9a91d8eaf0a25df254ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the requested networks when trying to rebuild instances burried in"},{"line_number":12,"context_line":"cell0."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"When an instance fails to be scheduled and it gets burried in cell0,"},{"line_number":15,"context_line":"we will use the new field in the RequestSpec object to store a"},{"line_number":16,"context_line":"NetworkRequestList containing the networks requested by the user."},{"line_number":17,"context_line":"This way, when we try to rebuild the instance we can retrieve this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_c0475e1e","line":14,"range":{"start_line":14,"start_character":51,"end_line":14,"end_character":58},"in_reply_to":"9fdfeff1_8fa0b644","updated":"2019-03-05 15:36:46.000000000","message":"Done","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a51b3a98493899563d1056cf73eb9d3218f69b","unresolved":false,"context_lines":[{"line_number":879,"context_line":"                        base_options[\u0027pci_requests\u0027], filter_properties,"},{"line_number":880,"context_line":"                        instance_group, base_options[\u0027availability_zone\u0027],"},{"line_number":881,"context_line":"                        security_groups\u003dsecurity_groups,"},{"line_number":882,"context_line":"                        requested_networks\u003drequested_networks)"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"                if block_device_mapping:"},{"line_number":885,"context_line":"                    # Record whether or not we are a BFV instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffd0ebdf_ab88021f","line":882,"updated":"2019-01-04 20:48:17.000000000","message":"Per the spec, I thought we would only set this during _bury_in_cell0 in conductor? Otherwise we don\u0027t really need this in the RequestSpec for a normal build. I worry about persisting this and then it causing issues later, like if ports are attached to a server and then we rebuild it later, would this somehow mess that up? It shouldn\u0027t since we should only use this if rebuilding from cell0, but RequestSpec is a tricky beast and often causes problems because of having stale data.","commit_id":"c0d58592050e10aa913c22feb2c3578a1f51f7bf"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"0447b8368fa7272bd10fe5ae4dcaa931e33f65d0","unresolved":false,"context_lines":[{"line_number":879,"context_line":"                        base_options[\u0027pci_requests\u0027], filter_properties,"},{"line_number":880,"context_line":"                        instance_group, base_options[\u0027availability_zone\u0027],"},{"line_number":881,"context_line":"                        security_groups\u003dsecurity_groups,"},{"line_number":882,"context_line":"                        requested_networks\u003drequested_networks)"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"                if block_device_mapping:"},{"line_number":885,"context_line":"                    # Record whether or not we are a BFV instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_27c1aa55","line":882,"in_reply_to":"ffd0ebdf_ab88021f","updated":"2019-01-23 11:48:48.000000000","message":"Yes I totally, agree with you. I\u0027ll move it to _bury_in_cell0.","commit_id":"c0d58592050e10aa913c22feb2c3578a1f51f7bf"}],"nova/objects/request_spec.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81dbda977f78ebb8078e78236df2497aa39861c3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                         default\u003dNone),"},{"line_number":103,"context_line":"        \u0027requested_networks\u0027: fields.ObjectField(\u0027NetworkRequestList\u0027,"},{"line_number":104,"context_line":"                                                 nullable\u003dTrue,"},{"line_number":105,"context_line":"                                                 default\u003dNone)"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_715c544c","line":105,"updated":"2019-03-04 18:22:12.000000000","message":"I think this makes sense to persist here. The only question would maybe be about port_id.\n\nIf we really bury this request in cell0, then I guess the port_id would be re-usable, but I think if we were to use this during rebuild or evacuate or something, we\u0027d have to ignore existing port_id values in this structure.","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"0e84003ac26b22a1a8df9a91d8eaf0a25df254ff","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                         default\u003dNone),"},{"line_number":103,"context_line":"        \u0027requested_networks\u0027: fields.ObjectField(\u0027NetworkRequestList\u0027,"},{"line_number":104,"context_line":"                                                 nullable\u003dTrue,"},{"line_number":105,"context_line":"                                                 default\u003dNone)"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_80ff16aa","line":105,"in_reply_to":"9fdfeff1_3f8e9379","updated":"2019-03-05 15:36:46.000000000","message":"Actually, hard delete of the instance is out of the picture. But yes, as soon as the instance gets resurrected we set requested_networks to None. The requested networks are stored here ONLY when the instance gets buried to cell0.","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c2230451c4c5dfe5995cfa1d642aba43351f3683","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                         default\u003dNone),"},{"line_number":103,"context_line":"        \u0027requested_networks\u0027: fields.ObjectField(\u0027NetworkRequestList\u0027,"},{"line_number":104,"context_line":"                                                 nullable\u003dTrue,"},{"line_number":105,"context_line":"                                                 default\u003dNone)"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_d4ebae75","line":105,"in_reply_to":"9fdfeff1_715c544c","updated":"2019-03-04 19:14:57.000000000","message":"The commit message doesn\u0027t say it, but when rebuilding from cell0 this gets used to pass to conductor and then deleted:\n\nhttps://review.openstack.org/#/c/570203/9/nova/compute/api.py@3432","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8335e07009b46d01184f6447e65239395d45cb2d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                         default\u003dNone),"},{"line_number":103,"context_line":"        \u0027requested_networks\u0027: fields.ObjectField(\u0027NetworkRequestList\u0027,"},{"line_number":104,"context_line":"                                                 nullable\u003dTrue,"},{"line_number":105,"context_line":"                                                 default\u003dNone)"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_3f8e9379","line":105,"in_reply_to":"9fdfeff1_d4ebae75","updated":"2019-03-04 19:30:12.000000000","message":"Ah, okay, so we\u0027ll only be persisting this in the case of burying in cell0, and we\u0027ll nuke it when the thing is resurrected.. That eliminates the concern there I guess.","commit_id":"cd00469b2cd369b8ea42d1669dc43d23ea733742"}],"nova/tests/unit/objects/test_request_spec.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a51b3a98493899563d1056cf73eb9d3218f69b","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        primitive \u003d req_obj.obj_to_primitive(target_version\u003d\u00271.12\u0027,"},{"line_number":788,"context_line":"                                             version_manifest\u003dversions)"},{"line_number":789,"context_line":"        primitive \u003d primitive[\u0027nova_object.data\u0027]"},{"line_number":790,"context_line":"        self.assertNotIn(\u0027requested_networks\u0027, primitive)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def test_default_requested_destination(self):"},{"line_number":793,"context_line":"        req_obj \u003d objects.RequestSpec()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffd0ebdf_ab9d625a","line":790,"updated":"2019-01-04 20:48:17.000000000","message":"Would be good to assert that \u0027project_id\u0027 is in primitive to make sure this isn\u0027t a false positive.","commit_id":"c0d58592050e10aa913c22feb2c3578a1f51f7bf"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"0447b8368fa7272bd10fe5ae4dcaa931e33f65d0","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        primitive \u003d req_obj.obj_to_primitive(target_version\u003d\u00271.12\u0027,"},{"line_number":788,"context_line":"                                             version_manifest\u003dversions)"},{"line_number":789,"context_line":"        primitive \u003d primitive[\u0027nova_object.data\u0027]"},{"line_number":790,"context_line":"        self.assertNotIn(\u0027requested_networks\u0027, primitive)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def test_default_requested_destination(self):"},{"line_number":793,"context_line":"        req_obj \u003d objects.RequestSpec()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_bb66f728","line":790,"in_reply_to":"ffd0ebdf_ab9d625a","updated":"2019-01-23 11:48:48.000000000","message":"Done","commit_id":"c0d58592050e10aa913c22feb2c3578a1f51f7bf"}]}