)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"8db4bf2601cc0ce9414d975cba096e7ae2f0c0dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe Gordon \u003cjoe.gordon0@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-18 12:55:02 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t log stacktrace for UnexpecteTaskSateError"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An UnexpectedTaskStateError is actually an expected behavior and we"},{"line_number":10,"context_line":"don\u0027t need to log a stacktrace every time it happens. This stacktrace"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BBEI%3D","line":7,"updated":"2013-12-03 12:59:51.000000000","message":"Double typo there :)","commit_id":"d813de7f3e96397928e34b443f084b938146d43f"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7a69b6e0320e0237075c7c99e9ca7cf1057289f4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.warn(_(\"task possibly preempted.\"))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BA%2FE%3D","line":243,"updated":"2013-12-03 13:19:51.000000000","message":"If it\u0027s an expected exception, why do not use an INFO level?","commit_id":"b2df8d781cbe3e2d4a9d866c9fe70cef35309d78"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4d2c92d0e9379dfaae93aaf0fffc2bafcda1afd3","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.warn(_(\"task possibly preempted.\"))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BA9M%3D","line":243,"in_reply_to":"AAAATn%2F%2BA%2FE%3D","updated":"2013-12-03 13:24:49.000000000","message":"good point","commit_id":"b2df8d781cbe3e2d4a9d866c9fe70cef35309d78"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cc9343c474fd42306d5a9d620a7cc7c9cb651ebd","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"task possibly preempted.\"))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9778%3D","line":243,"updated":"2013-12-04 09:14:52.000000000","message":"Can we at least have the explanation of the log. That is,\nexcept exception.UnexpectedTaskStateError as e:\n....\nLOG.info(\"task possibly preempted: %s\", unicode(e))\n\nThat will at least give us an understand of where is was thrown and maybe why","commit_id":"8cd6d298c72b5e62d6cdc8fd85d9b99174126b1b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"97b8d223f58a191a71d9a35ab1b9627eb1d1db57","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"task possibly preempted.\"))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BA6w%3D","line":243,"updated":"2013-12-03 13:33:32.000000000","message":"Sorry for that but what do you think about using upper case:\n\nTask possibly...","commit_id":"8cd6d298c72b5e62d6cdc8fd85d9b99174126b1b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d2085857d25b955d538db08bd980395a917b12a9","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"task possibly preempted.\"))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BA3c%3D","line":243,"in_reply_to":"AAAATn%2F%2BA4M%3D","updated":"2013-12-03 13:45:52.000000000","message":"yes, you probably right.","commit_id":"8cd6d298c72b5e62d6cdc8fd85d9b99174126b1b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"eead5efb3e1130357617c155d461361e5aae74aa","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"task possibly preempted.\"))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BA4M%3D","line":243,"in_reply_to":"AAAATn%2F%2BA6w%3D","updated":"2013-12-03 13:43:35.000000000","message":"While I like the idea, we don\u0027t have uniform capitalization in log messages today, so I think a change like that would make more sense as a separate patch that covers all log messages.","commit_id":"8cd6d298c72b5e62d6cdc8fd85d9b99174126b1b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fe816cdac4a19fcc1ac15c0daecdea9e8fe1d107","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"Task possibly preempted: %s\") % unicode(e))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F973g%3D","line":243,"updated":"2013-12-04 09:29:25.000000000","message":"Please use e.format_message() instead.","commit_id":"612c095c08a621d57d78d0f3335004570fb20e4b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"bbc2a3fc1f4451c2d4f2db4ed3f98d567985b271","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"Task possibly preempted: %s\") % unicode(e))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F97mQ%3D","line":243,"in_reply_to":"AAAATn%2F973g%3D","updated":"2013-12-04 10:27:38.000000000","message":"sure, but we don\u0027t use format_message everywhere see below.","commit_id":"612c095c08a621d57d78d0f3335004570fb20e4b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8acc5e8e4d6773c0876b6e7c13f2ecbd207855bb","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            # task is preempted. Do not clear task state in this"},{"line_number":241,"context_line":"            # case."},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":243,"context_line":"                LOG.info(_(\"Task possibly preempted: %s\") % unicode(e))"},{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":246,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F97kA%3D","line":243,"in_reply_to":"AAAATn%2F97mQ%3D","updated":"2013-12-04 10:37:19.000000000","message":"Yeah - we really should be, although it doesn\u0027t matter so much, since none of these exceptions are ever going to be remote.","commit_id":"612c095c08a621d57d78d0f3335004570fb20e4b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"bbc2a3fc1f4451c2d4f2db4ed3f98d567985b271","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            notify(\"end\", msg\u003d_(\"Success\"), network_info\u003dnetwork_info)"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":"        except exception.RescheduledException as e:"},{"line_number":970,"context_line":"            # Instance build encountered an error, and has been rescheduled."},{"line_number":971,"context_line":"            notify(\"error\", msg\u003dunicode(e))  # notify that build failed"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"        except exception.BuildAbortException as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F97mk%3D","line":970,"updated":"2013-12-04 10:27:38.000000000","message":"here","commit_id":"612c095c08a621d57d78d0f3335004570fb20e4b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"bbc2a3fc1f4451c2d4f2db4ed3f98d567985b271","unresolved":false,"context_lines":[{"line_number":978,"context_line":"        except Exception as e:"},{"line_number":979,"context_line":"            # Instance build encountered a non-recoverable error:"},{"line_number":980,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":981,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":982,"context_line":"                notify(\"error\", msg\u003dunicode(e))  # notify that build failed"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    def _prebuild_instance(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F97mY%3D","line":981,"updated":"2013-12-04 10:27:38.000000000","message":"here","commit_id":"612c095c08a621d57d78d0f3335004570fb20e4b"}]}