)]}'
{"nova/network/api.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"00aaf451fbc85e391d841aa4f35a20d3052989de","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return wrapper"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def update_instance_cache_with_nw_info(api, context, instance, nw_info\u003dNone,"},{"line_number":69,"context_line":"                                       update_cells\u003dTrue):"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        if not isinstance(nw_info, network_model.NetworkInfo):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BnMk%3D","side":"PARENT","line":68,"updated":"2013-11-22 14:03:01.000000000","message":"@Peter, curiousity question, update_instance_cache_with_nw_info is an internal to this module right? (at somepoint is it worth adding \u0027_\u0027 prefix to make it a bit more apparent)","commit_id":"6fbb0b17199addfbba0bc92fb0aa071465b916ba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7661f57162204c6c5778abac178420dc68b49c7a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"def update_instance_cache_with_nw_info(api, context, instance, nw_info\u003dNone,"},{"line_number":69,"context_line":"                                       update_cells\u003dTrue):"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        if not isinstance(nw_info, network_model.NetworkInfo):"},{"line_number":72,"context_line":"            nw_info \u003d None"},{"line_number":73,"context_line":"        if nw_info is None:"},{"line_number":74,"context_line":"            nw_info \u003d api._get_instance_nw_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B388%3D","line":71,"updated":"2013-11-19 04:11:38.000000000","message":"is nw_info\u0027s value the list [], in the case you\u0027re addressing? If so, wouldn\u0027t the test on line 71 be True, and hence nw_info set to None?\n\nIf I am not missing something, wouldn\u0027t \u0027not nw_info\u0027 still be True, just as \u0027nw_info is None\u0027?","commit_id":"8bc974be50bea6ff6beacda890d9a33fa90059b3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e1d76b30774e801e749c186a8880b78826549f31","unresolved":false,"context_lines":[{"line_number":68,"context_line":"def update_instance_cache_with_nw_info(api, context, instance, nw_info\u003dNone,"},{"line_number":69,"context_line":"                                       update_cells\u003dTrue):"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        if not isinstance(nw_info, network_model.NetworkInfo):"},{"line_number":72,"context_line":"            nw_info \u003d None"},{"line_number":73,"context_line":"        if nw_info is None:"},{"line_number":74,"context_line":"            nw_info \u003d api._get_instance_nw_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B1hs%3D","line":71,"in_reply_to":"AAAATn%2F%2B1kQ%3D","updated":"2013-11-19 15:08:11.000000000","message":"Gotcha, thanks for clarifying this. I think this fix is still good but I suspect it will end up changing the failure mode of some of the tempest woes we\u0027re seeing.","commit_id":"8bc974be50bea6ff6beacda890d9a33fa90059b3"},{"author":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"change_message_id":"9e8817607f76c35655abbd35338ed63a33c077e1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"def update_instance_cache_with_nw_info(api, context, instance, nw_info\u003dNone,"},{"line_number":69,"context_line":"                                       update_cells\u003dTrue):"},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        if not isinstance(nw_info, network_model.NetworkInfo):"},{"line_number":72,"context_line":"            nw_info \u003d None"},{"line_number":73,"context_line":"        if nw_info is None:"},{"line_number":74,"context_line":"            nw_info \u003d api._get_instance_nw_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B1kQ%3D","line":71,"in_reply_to":"AAAATn%2F%2B388%3D","updated":"2013-11-19 14:56:25.000000000","message":"Whenever I say \"[]\" I should be saying NetworkInfo([]). Note that NetworkInfo is a subclass of list. Take a look at the unit test I added for an example.\n\nOn another note: I\u0027m not sure why this \"if not isinstance(...\" check is necessary. If there are indeed callers of update_instance_cache_with_nw_info that pass in something other than NetworkInfo we should fix those. I\u0027ll do that as a separate patch.","commit_id":"8bc974be50bea6ff6beacda890d9a33fa90059b3"}]}