)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"808c456c5ad775488b2e39ae49690fbb03f153a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem.os@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-13 13:49:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug to api-ref"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API reference for the server \u0027migrate\u0027 (cold migrate) action"},{"line_number":10,"context_line":"doesn\u0027t mention any asynchronous post conditions. We should have"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_d4177ea2","line":7,"updated":"2018-06-13 13:49:35.000000000","message":"nit: this could have been more specific, e.g.:\n\n\"Add postcondition details to cold migrate API reference\"","commit_id":"8819cd9348a8cf94abdcfe8576ca889256d1879b"}],"api-ref/source/servers-admin-action.inc":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a6312ada80df5290af893a49c3005c8b57f2c8ed","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Specify the ``migrate`` action in the request body."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to ``VERIFY_RESIZE`` status after a successful"},{"line_number":64,"context_line":"cold migration and then must be confirmed or reverted. If you set the "},{"line_number":65,"context_line":"``resize_confirm_window`` option of the Compute service to an integer value,"},{"line_number":66,"context_line":"the Compute service automatically confirms the resize operation after"},{"line_number":67,"context_line":"the set interval in seconds."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_9ece132b","line":64,"range":{"start_line":64,"start_character":69,"end_line":64,"end_character":70},"updated":"2018-05-31 07:31:12.000000000","message":"remove this","commit_id":"2449e58443be7df8c6e235724a5da03ae3eb34b1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a6312ada80df5290af893a49c3005c8b57f2c8ed","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to ``VERIFY_RESIZE`` status after a successful"},{"line_number":64,"context_line":"cold migration and then must be confirmed or reverted. If you set the "},{"line_number":65,"context_line":"``resize_confirm_window`` option of the Compute service to an integer value,"},{"line_number":66,"context_line":"the Compute service automatically confirms the resize operation after"},{"line_number":67,"context_line":"the set interval in seconds."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_3ea49f4a","line":65,"range":{"start_line":65,"start_character":58,"end_line":65,"end_character":76},"updated":"2018-05-31 07:31:12.000000000","message":"positive integer value?","commit_id":"2449e58443be7df8c6e235724a5da03ae3eb34b1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"076d1683710fff642a2765e2db15324be3a18133","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Specify the ``migrate`` action in the request body."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to ``VERIFY_RESIZE`` status after a successful"},{"line_number":64,"context_line":"cold migration and then must be confirmed or reverted. If you set the"},{"line_number":65,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"},{"line_number":66,"context_line":"value, the Compute service automatically confirms the resize operation after"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_50de246d","line":63,"range":{"start_line":63,"start_character":19,"end_line":63,"end_character":43},"updated":"2018-05-31 13:07:17.000000000","message":"It is not consistent with the description in \"Resize Server (resize Action)\".\n\nIt should be:\na ``VERIFY_RESIZE`` status, ``RESIZED`` VM status, and ``finished`` migration status.\n\nhttps://developer.openstack.org/api-ref/compute/#resize-server-resize-action","commit_id":"e815b234dd7e5d4b2cc01c2b68d3f7965da89073"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"076d1683710fff642a2765e2db15324be3a18133","unresolved":false,"context_lines":[{"line_number":63,"context_line":"The server goes to ``VERIFY_RESIZE`` status after a successful"},{"line_number":64,"context_line":"cold migration and then must be confirmed or reverted. If you set the"},{"line_number":65,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"},{"line_number":66,"context_line":"value, the Compute service automatically confirms the resize operation after"},{"line_number":67,"context_line":"the set interval in seconds."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Up to microversion 2.55, the scheduler chooses the host."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_70c24087","line":66,"range":{"start_line":66,"start_character":54,"end_line":66,"end_character":60},"updated":"2018-05-31 13:07:17.000000000","message":"migrate or cold migrate","commit_id":"e815b234dd7e5d4b2cc01c2b68d3f7965da89073"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db590f89eea84db63e4c44144f1f6cdd0665d49f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Specify the ``migrate`` action in the request body."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to a ``VERIFY_RESIZE`` status, ``RESIZED`` VM status,"},{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_3e99d66b","line":63,"range":{"start_line":63,"start_character":59,"end_line":63,"end_character":68},"updated":"2018-06-02 02:23:14.000000000","message":"This should probably be OS-EXT-STS:vm_state since that\u0027s the actual field in the server response body.","commit_id":"a022ea607fa1d29b7214f454f74af930a5f7f37c"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fbb20b317b369dbdae5706ee29f2275defa2e118","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Specify the ``migrate`` action in the request body."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to a ``VERIFY_RESIZE`` status, ``RESIZED`` VM status,"},{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_6657aecc","line":63,"range":{"start_line":63,"start_character":59,"end_line":63,"end_character":68},"in_reply_to":"5f7c97a3_3e99d66b","updated":"2018-06-04 14:59:49.000000000","message":"It is consistent with the description of \"Resize Server (resize Action)\".\n\nhttps://developer.openstack.org/api-ref/compute/#resize-server-resize-action\n\nSo IMO, it is no problem.","commit_id":"a022ea607fa1d29b7214f454f74af930a5f7f37c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"900f792e2ebbb85ab5587948e90360526c5c9769","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Specify the ``migrate`` action in the request body."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to a ``VERIFY_RESIZE`` status, ``RESIZED`` VM status,"},{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_74a78abd","line":63,"range":{"start_line":63,"start_character":59,"end_line":63,"end_character":68},"in_reply_to":"5f7c97a3_6657aecc","updated":"2018-06-13 13:42:27.000000000","message":"\u003e It is consistent with the description of \"Resize Server (resize Action)\".\n\nIt\u0027s consistently wrong, IMO. The API user is looking at the server response body fields, so status\u003dVERIFY_RESIZE, and OS-EXT-STS:vm_state is \u0027resized\u0027.","commit_id":"a022ea607fa1d29b7214f454f74af930a5f7f37c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db590f89eea84db63e4c44144f1f6cdd0665d49f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"},{"line_number":67,"context_line":"value, the Compute service automatically confirms the migrate or cold migrate"},{"line_number":68,"context_line":"operation after the set interval in seconds."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Up to microversion 2.55, the scheduler chooses the host."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_5e905243","line":67,"range":{"start_line":67,"start_character":62,"end_line":67,"end_character":77},"updated":"2018-06-02 02:23:14.000000000","message":"We can remove this since it\u0027s redundant.","commit_id":"a022ea607fa1d29b7214f454f74af930a5f7f37c"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fbb20b317b369dbdae5706ee29f2275defa2e118","unresolved":false,"context_lines":[{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"},{"line_number":67,"context_line":"value, the Compute service automatically confirms the migrate or cold migrate"},{"line_number":68,"context_line":"operation after the set interval in seconds."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Up to microversion 2.55, the scheduler chooses the host."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_e6e3be33","line":67,"range":{"start_line":67,"start_character":62,"end_line":67,"end_character":77},"in_reply_to":"5f7c97a3_5e905243","updated":"2018-06-04 14:59:49.000000000","message":"the Compute service automatically confirms the migrate operation after the set interval in seconds.\n\nor\n\nthe Compute service automatically confirms the cold migrate operation after the set interval in seconds.","commit_id":"a022ea607fa1d29b7214f454f74af930a5f7f37c"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8dece023ebc92f904360967fd5482c3974ecb767","unresolved":false,"context_lines":[{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"},{"line_number":67,"context_line":"value, the Compute service automatically confirms the migrate or cold migrate"},{"line_number":68,"context_line":"operation after the set interval in seconds."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Up to microversion 2.55, the scheduler chooses the host."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_f06ef494","line":67,"range":{"start_line":67,"start_character":62,"end_line":67,"end_character":77},"in_reply_to":"5f7c97a3_e6e3be33","updated":"2018-06-05 20:18:22.000000000","message":"Agree, there is no need to specify \u0027cold\u0027","commit_id":"a022ea607fa1d29b7214f454f74af930a5f7f37c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29cc0607f4ab992358ebdf58d0297e4920c896b3","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Specify the ``migrate`` action in the request body."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The server goes to a ``VERIFY_RESIZE`` status, ``RESIZED`` VM status,"},{"line_number":64,"context_line":"and ``finished`` migration status after a successful cold migration"},{"line_number":65,"context_line":"and then must be confirmed or reverted. If you set the"},{"line_number":66,"context_line":"``resize_confirm_window`` option of the Compute service to a positive integer"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5f7c97a3_7480eaf7","line":63,"range":{"start_line":63,"start_character":47,"end_line":63,"end_character":68},"updated":"2018-06-13 13:46:18.000000000","message":"I still think this should be:\n\n``resized`` OS-EXT-STS:vm_state\n\nBut it\u0027s a persistent confusion in several API references which we could cleanup separately.","commit_id":"7f4e989e24465d901a29058a8b1d7bc4ddf67c6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29cc0607f4ab992358ebdf58d0297e4920c896b3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"value, the Compute service automatically confirms the migrate operation"},{"line_number":68,"context_line":"after the set interval in seconds."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Up to microversion 2.55, the scheduler chooses the host."},{"line_number":71,"context_line":"Starting from microversion 2.56, the ``host`` parameter is available"},{"line_number":72,"context_line":"to specify the destination host. If you specify ``null`` or don\u0027t specify"},{"line_number":73,"context_line":"this parameter, the scheduler chooses a host."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5f7c97a3_34ccb268","line":70,"updated":"2018-06-13 13:46:18.000000000","message":"I tend to think the asynchronous postconditions should go after this paragraph which is more about the actual request.\n\nAnd in other API references, we clearly delineate the precondtions and asynchronous postconditions sections with a bold header, like for rescue:\n\nhttps://developer.openstack.org/api-ref/compute/#rescue-server-rescue-action","commit_id":"7f4e989e24465d901a29058a8b1d7bc4ddf67c6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9c2ceaad6d9d45f0edef8eeee4f20257e2a232e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"value, the Compute service automatically confirms the migrate operation"},{"line_number":68,"context_line":"after the set interval in seconds."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Up to microversion 2.55, the scheduler chooses the host."},{"line_number":71,"context_line":"Starting from microversion 2.56, the ``host`` parameter is available"},{"line_number":72,"context_line":"to specify the destination host. If you specify ``null`` or don\u0027t specify"},{"line_number":73,"context_line":"this parameter, the scheduler chooses a host."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5f7c97a3_f41ddabd","line":70,"in_reply_to":"5f7c97a3_34ccb268","updated":"2018-06-13 13:49:44.000000000","message":"Done","commit_id":"7f4e989e24465d901a29058a8b1d7bc4ddf67c6e"}]}