)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"85a331264756c863ef7e931b23e6f078699412d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichen \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-01 17:18:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not reraise DiskNotFound if instance is resized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when the instance is in resized state, the backend disk might"},{"line_number":10,"context_line":"be renamed to xxx_resize on the compute host and lead to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_72d27a36","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2018-06-11 12:22:12.000000000","message":"nit - Do not","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f3f6cbc201b5c3dfbf1c714e57590672e93d2d01","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichen \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-01 17:18:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not reraise DiskNotFound if instance is resized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when the instance is in resized state, the backend disk might"},{"line_number":10,"context_line":"be renamed to xxx_resize on the compute host and lead to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_30fa88b9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"in_reply_to":"5f7c97a3_72d27a36","updated":"2018-06-13 06:44:25.000000000","message":"Done","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"85a331264756c863ef7e931b23e6f078699412d9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not reraise DiskNotFound if instance is resized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when the instance is in resized state, the backend disk might"},{"line_number":10,"context_line":"be renamed to xxx_resize on the compute host and lead to"},{"line_number":11,"context_line":"potential disk not found issue."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_92d71624","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2018-06-11 12:22:12.000000000","message":"nit - W","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f3f6cbc201b5c3dfbf1c714e57590672e93d2d01","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not reraise DiskNotFound if instance is resized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when the instance is in resized state, the backend disk might"},{"line_number":10,"context_line":"be renamed to xxx_resize on the compute host and lead to"},{"line_number":11,"context_line":"potential disk not found issue."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_10ff4cab","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"in_reply_to":"5f7c97a3_92d71624","updated":"2018-06-13 06:44:25.000000000","message":"Done","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"85a331264756c863ef7e931b23e6f078699412d9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in resized situation it\u0027s not true, so this patch added"},{"line_number":16,"context_line":"another condition based on vmstate."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1774249"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id687e11e235fd6c2f99bb647184310dfdce9a08d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_52ddfe3e","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":19},"updated":"2018-06-11 12:22:12.000000000","message":"nit - #1774249","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f3f6cbc201b5c3dfbf1c714e57590672e93d2d01","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in resized situation it\u0027s not true, so this patch added"},{"line_number":16,"context_line":"another condition based on vmstate."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1774249"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id687e11e235fd6c2f99bb647184310dfdce9a08d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_70f480cf","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":19},"in_reply_to":"5f7c97a3_52ddfe3e","updated":"2018-06-13 06:44:25.000000000","message":"no # will also work :)","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c813631d4e5d957f59b55843847a5711400e0875","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Do not reraise DiskNotFound exceptions during resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an instance is in a RESIZE_CONFIRM state, the instance disk on the"},{"line_number":10,"context_line":"source compute host has moved to \u003cinstance_path\u003e/\u003cinstance_uuid\u003e_resize"},{"line_number":11,"context_line":"folder, which leads to disk not found errors if the update available"},{"line_number":12,"context_line":"resource periodic task on the source compute runs before resize is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fce034c_2422b101","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":39},"updated":"2019-04-17 14:16:25.000000000","message":"Do you mean RESIZE_CONFIRMING task_state? As far as I can tell, and this is a surprise to me, we never set this on the instance when the API confirm_resize method is run before casting to the source compute. That seems like a bug in itself since we should have a task_state set on the instance while the resize is being confirmed, I\u0027m not sure why the API doesn\u0027t do that.\n\nI guess your point here is we hit this during confirm_resize, not necessarily that the instance.task_state is literally set to RESIZE_CONFIRMING.\n\nOr do you mean VERIFY_RESIZE status? i.e. while the resize is waiting to be confirmed/reverted by the user?","commit_id":"1341e552c71c58e2aee3514b2b4b9e9925ea150d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5529821b4dca37178e69c8f62109536ba5891dd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"wait for the resize confirmation from the user). This patch ensures we"},{"line_number":19,"context_line":"don\u0027t reraise DiskNotFound exceptions during resize."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1774249"},{"line_number":22,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":23,"context_line":"Change-Id: Id687e11e235fd6c2f99bb647184310dfdce9a08d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fce034c_249391fc","line":21,"updated":"2019-04-17 14:19:30.000000000","message":"This would also fix bug 1824974 which is a different scenario - the local disk is corrupted resulting in DiskNotFound.","commit_id":"1341e552c71c58e2aee3514b2b4b9e9925ea150d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d806a38271bf47d03b7dd99a3800d530f21dea67","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Icec2769bf42455853cbe686fb30fda73df791b25 almost fixed this issue but it"},{"line_number":16,"context_line":"will only set reraise to False when task_state is not None, that isn\u0027t"},{"line_number":17,"context_line":"the case during a resize, so this patch adds a condition based on"},{"line_number":18,"context_line":"vm_state to ensure we don\u0027t reraise DiskNotFound exceptions during"},{"line_number":19,"context_line":"resize."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fce034c_5afa3475","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":24},"updated":"2019-04-17 15:16:44.000000000","message":"nit: the task_state should not be None during a resize, what you\u0027re really talking about here is after the resize is done and waiting for the user to either confirm or revert it.","commit_id":"6c2a1a294a37440d855581dc8cc2627a898d2544"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d806a38271bf47d03b7dd99a3800d530f21dea67","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Icec2769bf42455853cbe686fb30fda73df791b25 almost fixed this issue but it"},{"line_number":16,"context_line":"will only set reraise to False when task_state is not None, that isn\u0027t"},{"line_number":17,"context_line":"the case during a resize, so this patch adds a condition based on"},{"line_number":18,"context_line":"vm_state to ensure we don\u0027t reraise DiskNotFound exceptions during"},{"line_number":19,"context_line":"resize."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1774249"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fce034c_7af5b082","line":19,"range":{"start_line":18,"start_character":60,"end_line":19,"end_character":7},"updated":"2019-04-17 15:16:44.000000000","message":"similar nit, maybe \"while resized\".","commit_id":"6c2a1a294a37440d855581dc8cc2627a898d2544"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d806a38271bf47d03b7dd99a3800d530f21dea67","unresolved":false,"context_lines":[{"line_number":19,"context_line":"resize."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1774249"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Id687e11e235fd6c2f99bb647184310dfdce9a08d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fce034c_3aef28b1","line":22,"updated":"2019-04-17 15:16:44.000000000","message":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e","commit_id":"6c2a1a294a37440d855581dc8cc2627a898d2544"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d806a38271bf47d03b7dd99a3800d530f21dea67","unresolved":false,"context_lines":[{"line_number":15052,"context_line":"    def test_disk_over_committed_size_total_disk_not_found_ignore_vmstate("},{"line_number":15053,"context_line":"            self, mock_get, mock_bdms, mock_get_disk_info, mock_list_domains):"},{"line_number":15054,"context_line":"        \"\"\"Tests that we handle DiskNotFound gracefully for an instance that"},{"line_number":15055,"context_line":"        is undergoing a task_state transition."},{"line_number":15056,"context_line":"        \"\"\""},{"line_number":15057,"context_line":"        mock_dom \u003d mock.Mock()"},{"line_number":15058,"context_line":"        mock_dom.XMLDesc.return_value \u003d \"\u003cdomain/\u003e\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fce034c_ba38f83c","line":15055,"range":{"start_line":15055,"start_character":11,"end_line":15055,"end_character":46},"updated":"2019-04-17 15:16:44.000000000","message":"this copy/paste is wrong","commit_id":"6c2a1a294a37440d855581dc8cc2627a898d2544"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"bf90f43a5253687bf44d12802cbf95adfcb8bf19","unresolved":false,"context_lines":[{"line_number":8008,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8009,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8010,"context_line":"                        # state it might also can\u0027t find back disk"},{"line_number":8011,"context_line":"                        if (inst.task_state is not None) or"},{"line_number":8012,"context_line":"                            (inst.vm_state \u003d\u003d vm_states.RESIZED):"},{"line_number":8013,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8014,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7047a01e","line":8011,"range":{"start_line":8011,"start_character":56,"end_line":8011,"end_character":59},"updated":"2018-05-31 13:08:42.000000000","message":"syntax error here.","commit_id":"6d8cb80e532ba49f61e0cf34e1b765a8470b0ecd"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"27e894198131d99b4ee8fb35d8151282cebc006f","unresolved":false,"context_lines":[{"line_number":8008,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8009,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8010,"context_line":"                        # state it might also can\u0027t find back disk"},{"line_number":8011,"context_line":"                        if (inst.task_state is not None) or"},{"line_number":8012,"context_line":"                            (inst.vm_state \u003d\u003d vm_states.RESIZED):"},{"line_number":8013,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8014,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3acd745c","line":8011,"range":{"start_line":8011,"start_character":56,"end_line":8011,"end_character":59},"in_reply_to":"5f7c97a3_7047a01e","updated":"2018-06-01 08:53:11.000000000","message":"Done","commit_id":"6d8cb80e532ba49f61e0cf34e1b765a8470b0ecd"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"bf90f43a5253687bf44d12802cbf95adfcb8bf19","unresolved":false,"context_lines":[{"line_number":8013,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8014,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8015,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"},{"line_number":8016,"context_line":"                                     \u0027was removed by a concurrent operation \u0027"},{"line_number":8017,"context_line":"                                     \u0027(task_state\u003d%(task_state)s) and \u0027,"},{"line_number":8018,"context_line":"                                     \u0027(vm_state\u003d%(vm_state)s)\u0027,"},{"line_number":8019,"context_line":"                                     {\u0027i_name\u0027: guest.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9057dcca","line":8016,"range":{"start_line":8016,"start_character":38,"end_line":8016,"end_character":49},"updated":"2018-05-31 13:08:42.000000000","message":"removed or renamed?","commit_id":"6d8cb80e532ba49f61e0cf34e1b765a8470b0ecd"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"27e894198131d99b4ee8fb35d8151282cebc006f","unresolved":false,"context_lines":[{"line_number":8013,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8014,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8015,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"},{"line_number":8016,"context_line":"                                     \u0027was removed by a concurrent operation \u0027"},{"line_number":8017,"context_line":"                                     \u0027(task_state\u003d%(task_state)s) and \u0027,"},{"line_number":8018,"context_line":"                                     \u0027(vm_state\u003d%(vm_state)s)\u0027,"},{"line_number":8019,"context_line":"                                     {\u0027i_name\u0027: guest.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3ac81453","line":8016,"range":{"start_line":8016,"start_character":38,"end_line":8016,"end_character":49},"in_reply_to":"5f7c97a3_9057dcca","updated":"2018-06-01 08:53:11.000000000","message":"renamed also means removed the original one :)","commit_id":"6d8cb80e532ba49f61e0cf34e1b765a8470b0ecd"},{"author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"change_message_id":"a08be0b10b75919c30d0bb0df943154685318cb8","unresolved":false,"context_lines":[{"line_number":8015,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8016,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"},{"line_number":8017,"context_line":"                                     \u0027was removed by a concurrent operation \u0027"},{"line_number":8018,"context_line":"                                     \u0027(task_state\u003d%(task_state)s) and \u0027"},{"line_number":8019,"context_line":"                                     \u0027(vm_state\u003d%(vm_state)s)\u0027,"},{"line_number":8020,"context_line":"                                     {\u0027i_name\u0027: guest.name,"},{"line_number":8021,"context_line":"                                      \u0027task_state\u0027: inst.task_state,"},{"line_number":8022,"context_line":"                                      \u0027vm_state\u0027: inst.vm_state},"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f2b0ca8d","line":8019,"range":{"start_line":8018,"start_character":66,"end_line":8019,"end_character":61},"updated":"2018-06-11 12:43:40.000000000","message":"I think we are adding a new scenario here, so it sounds clearer with  something like \"or renamed in the middle of resize action\"","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f3f6cbc201b5c3dfbf1c714e57590672e93d2d01","unresolved":false,"context_lines":[{"line_number":8015,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8016,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"},{"line_number":8017,"context_line":"                                     \u0027was removed by a concurrent operation \u0027"},{"line_number":8018,"context_line":"                                     \u0027(task_state\u003d%(task_state)s) and \u0027"},{"line_number":8019,"context_line":"                                     \u0027(vm_state\u003d%(vm_state)s)\u0027,"},{"line_number":8020,"context_line":"                                     {\u0027i_name\u0027: guest.name,"},{"line_number":8021,"context_line":"                                      \u0027task_state\u0027: inst.task_state,"},{"line_number":8022,"context_line":"                                      \u0027vm_state\u0027: inst.vm_state},"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_900b5cd3","line":8019,"range":{"start_line":8018,"start_character":66,"end_line":8019,"end_character":61},"in_reply_to":"5f7c97a3_f2b0ca8d","updated":"2018-06-13 06:44:25.000000000","message":"well, I don\u0027t know concurrent operation is enough here\nas anyway we won\u0027t raise exception here","commit_id":"631c55a99af408dc8b50fba656fe7170b5d93071"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"7e1dcd5f8951005c7daa1273e35f66f329db474f","unresolved":false,"context_lines":[{"line_number":8101,"context_line":"        # disk_over_committed_size would differ to the list you would get"},{"line_number":8102,"context_line":"        # in _update_available_resource method for calculating usages based"},{"line_number":8103,"context_line":"        # on instance utilization."},{"line_number":8104,"context_line":"        local_instance_list \u003d objects.InstanceList.get_by_filters("},{"line_number":8105,"context_line":"            ctx, filters, use_slave\u003dTrue)"},{"line_number":8106,"context_line":"        # Convert instance list to dictionary with instance uuid as key."},{"line_number":8107,"context_line":"        local_instances \u003d {inst.uuid: inst for inst in local_instance_list}"},{"line_number":8108,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_0bc0042b","line":8105,"range":{"start_line":8104,"start_character":0,"end_line":8105,"end_character":41},"updated":"2018-07-25 12:27:23.000000000","message":"From here...","commit_id":"8502ff8ed90abc279c93e885f81b6f6fdac6013e"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"7e1dcd5f8951005c7daa1273e35f66f329db474f","unresolved":false,"context_lines":[{"line_number":8170,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8171,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8172,"context_line":"                        # state it might also can\u0027t find back disk"},{"line_number":8173,"context_line":"                        if (inst.task_state is not None or"},{"line_number":8174,"context_line":"                            inst.vm_state \u003d\u003d vm_states.RESIZED):"},{"line_number":8175,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8176,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8177,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ab32305c","line":8174,"range":{"start_line":8173,"start_character":0,"end_line":8174,"end_character":64},"updated":"2018-07-25 12:27:23.000000000","message":"... to here is a race. It\u0027s a really long race, in fact, and one that we probably hit all the time in practise. This instance info is seriously out of date. We could refresh it, but... it would still be a (shorter) race. Why bother?\n\nWhy would we fail here anyway? Can\u0027t we just turn LOG.info() into LOG.warning() and never fail? Failing here doesn\u0027t seem critical, and attempting to be clever is probably going to result in confusion given that the data here is almost definitely out of date.","commit_id":"8502ff8ed90abc279c93e885f81b6f6fdac6013e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6fc74350dd087c980d7a3160f892f3598c0d4226","unresolved":false,"context_lines":[{"line_number":8170,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8171,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8172,"context_line":"                        # state it might also can\u0027t find back disk"},{"line_number":8173,"context_line":"                        if (inst.task_state is not None or"},{"line_number":8174,"context_line":"                            inst.vm_state \u003d\u003d vm_states.RESIZED):"},{"line_number":8175,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8176,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8177,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_6bf9771a","line":8174,"range":{"start_line":8173,"start_character":0,"end_line":8174,"end_character":64},"in_reply_to":"5f7c97a3_ab32305c","updated":"2018-07-25 12:46:48.000000000","message":"Good point, basically the same as the above VolumeBDMPathNotFound block right?","commit_id":"8502ff8ed90abc279c93e885f81b6f6fdac6013e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07663b1f7783a294cc73cc96ba929e8b422a3e36","unresolved":false,"context_lines":[{"line_number":8247,"context_line":"                    # If the instance is undergoing a task state transition,"},{"line_number":8248,"context_line":"                    # like moving to another host or is being deleted, we"},{"line_number":8249,"context_line":"                    # should ignore this instance and move on."},{"line_number":8250,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8251,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8252,"context_line":"                        if inst.task_state is not None:"},{"line_number":8253,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8254,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_8bbc09dd","side":"PARENT","line":8251,"range":{"start_line":8250,"start_character":20,"end_line":8251,"end_character":58},"updated":"2019-03-08 01:03:22.000000000","message":"So why don\u0027t we still do this in the resize case? Or is the guest no longer local? Do we hit this on the source host? That would be good to explain in the commit message.","commit_id":"95287619c9f59ea91537ac5789dda25aab41f5f6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07663b1f7783a294cc73cc96ba929e8b422a3e36","unresolved":false,"context_lines":[{"line_number":8243,"context_line":"                            \u0027Error: %(error)s\u0027,"},{"line_number":8244,"context_line":"                            {\u0027i_name\u0027: guest.name, \u0027error\u0027: e})"},{"line_number":8245,"context_line":"            except exception.DiskNotFound:"},{"line_number":8246,"context_line":"                LOG.warning(\u0027Periodic task is updating the host stats; it is \u0027"},{"line_number":8247,"context_line":"                            \u0027trying to get disk info for %(i_name)s, but the \u0027"},{"line_number":8248,"context_line":"                            \u0027backing disk was removed by a concurrent \u0027"},{"line_number":8249,"context_line":"                            \u0027operation such as resize\u0027, {\u0027i_name\u0027: guest.name})"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_cbc9b178","line":8246,"range":{"start_line":8246,"start_character":20,"end_line":8246,"end_character":27},"updated":"2019-03-08 01:03:22.000000000","message":"Does this really need to be a warning if it\u0027s expected? IOW, I had this as info for the case we race with server delete so the task_state was DELETING since it was a known issue that we don\u0027t need to warn about.","commit_id":"7df53188a4760eb07a25f332af8e89ce2dcb8fb1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b769a58d4a7bf919b19beda7659c7270de8c203","unresolved":false,"context_lines":[{"line_number":8249,"context_line":"                    # should ignore this instance and move on."},{"line_number":8250,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8251,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8252,"context_line":"                        if inst.task_state is not None:"},{"line_number":8253,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8254,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8255,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fce034c_3718a173","side":"PARENT","line":8252,"range":{"start_line":8252,"start_character":24,"end_line":8252,"end_character":55},"updated":"2019-04-17 14:27:50.000000000","message":"So the alternative would be to keep this old logic but include a condition for \"and inst.vm_state is not vm_states.RESIZED\" right? That would fix your bug and still avoid blindly ignoring DiskNotFound for steady-state instances, and is thus an incremental improvement over a more drastic change. I understand mdbooth\u0027s comments about the race and such, but the point of this being conservative was to handle known cases (like while the server is being deleted or moving off the host) rather than unexpected cases like a corrupted disk on the host that we arguably shouldn\u0027t blindly ignore.","commit_id":"95287619c9f59ea91537ac5789dda25aab41f5f6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5529821b4dca37178e69c8f62109536ba5891dd","unresolved":false,"context_lines":[{"line_number":8246,"context_line":"                LOG.info(\u0027Periodic task is updating the host stats; it is \u0027"},{"line_number":8247,"context_line":"                         \u0027trying to get disk info for %(i_name)s, but the \u0027"},{"line_number":8248,"context_line":"                         \u0027backing disk was removed by a concurrent \u0027"},{"line_number":8249,"context_line":"                         \u0027operation such as resize\u0027, {\u0027i_name\u0027: guest.name})"},{"line_number":8250,"context_line":""},{"line_number":8251,"context_line":"            # NOTE(gtt116): give other tasks a chance."},{"line_number":8252,"context_line":"            greenthread.sleep(0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fce034c_84ffe532","line":8249,"range":{"start_line":8249,"start_character":36,"end_line":8249,"end_character":50},"updated":"2019-04-17 14:19:30.000000000","message":"This could be misleading if the instance is currently being deleted and we pulled it from the DB before the files were deleted. It might be better to just remove this part since \u0027concurrent operation\u0027 is generic enough.","commit_id":"1341e552c71c58e2aee3514b2b4b9e9925ea150d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e102c88fe346df154def730434fbf8e93ff5964","unresolved":false,"context_lines":[{"line_number":8246,"context_line":"                LOG.info(\u0027Periodic task is updating the host stats; it is \u0027"},{"line_number":8247,"context_line":"                         \u0027trying to get disk info for %(i_name)s, but the \u0027"},{"line_number":8248,"context_line":"                         \u0027backing disk was removed by a concurrent \u0027"},{"line_number":8249,"context_line":"                         \u0027operation such as resize\u0027, {\u0027i_name\u0027: guest.name})"},{"line_number":8250,"context_line":""},{"line_number":8251,"context_line":"            # NOTE(gtt116): give other tasks a chance."},{"line_number":8252,"context_line":"            greenthread.sleep(0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fce034c_a43b01e9","line":8249,"range":{"start_line":8249,"start_character":36,"end_line":8249,"end_character":50},"in_reply_to":"3fce034c_84ffe532","updated":"2019-04-17 14:25:03.000000000","message":"http://logstash.openstack.org/#dashboard/file/logstash.json?query\u003dmessage%3A%5C%22Periodic%20task%20is%20updating%20the%20host%20stats%3B%20it%20is%20trying%20to%20get%20disk%20info%5C%22%20AND%20NOT%20message%3A%5C%22(task_state%3Ddeleting)%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22\u0026from\u003d7d\n\nwill show you all the times we hit the old message when the instance is not being deleted - lots of it is resize in progress but some is rebuild as well.","commit_id":"1341e552c71c58e2aee3514b2b4b9e9925ea150d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4d7b9c8a780a0783940eeff9ea73c9329aefb7fa","unresolved":false,"context_lines":[{"line_number":8249,"context_line":"                    # should ignore this instance and move on."},{"line_number":8250,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8251,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8252,"context_line":"                        if inst.task_state is not None:"},{"line_number":8253,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8254,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8255,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fce034c_773ce9be","side":"PARENT","line":8252,"updated":"2019-04-17 14:28:52.000000000","message":"From PS9:\n\nhttps://review.openstack.org/#/c/571410/9/nova/virt/libvirt/driver.py@a8252","commit_id":"95287619c9f59ea91537ac5789dda25aab41f5f6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9ed514b66aa864579ffe9eec98528db593fe8615","unresolved":false,"context_lines":[{"line_number":8249,"context_line":"                    # should ignore this instance and move on."},{"line_number":8250,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8251,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8252,"context_line":"                        if inst.task_state is not None:"},{"line_number":8253,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"},{"line_number":8254,"context_line":"                                     \u0027stats; it is trying to get disk info \u0027"},{"line_number":8255,"context_line":"                                     \u0027for %(i_name)s, but the backing disk \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fce034c_d7603da8","side":"PARENT","line":8252,"in_reply_to":"3fce034c_773ce9be","updated":"2019-04-17 14:30:31.000000000","message":"Note that I\u0027d also be more comfortable with fixing the VERIFY_RESIZE issue in a more conservative incremental approach here as described in PS9 for backports - and then we can debate separately if we should just rip out the conditionals in here altogether, i.e. bug 1824974.","commit_id":"95287619c9f59ea91537ac5789dda25aab41f5f6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61859c1adb9633c6090b273a1e6b9e1a30570693","unresolved":false,"context_lines":[{"line_number":8614,"context_line":"        \"\"\"Return total over committed disk size for all instances.\"\"\""},{"line_number":8615,"context_line":"        # Disk size that all instance uses : virtual_size - disk_size"},{"line_number":8616,"context_line":"        disk_over_committed_size \u003d 0"},{"line_number":8617,"context_line":"        instance_domains \u003d self._host.list_instance_domains(only_running\u003dFalse)"},{"line_number":8618,"context_line":"        if not instance_domains:"},{"line_number":8619,"context_line":"            return disk_over_committed_size"},{"line_number":8620,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_d0d36337","line":8617,"range":{"start_line":8617,"start_character":8,"end_line":8617,"end_character":79},"updated":"2019-04-17 16:24:38.000000000","message":"Does this continue to return the domain even after migrate_disk_and_power_off destroys the guest on the source host?","commit_id":"1ff9e9512b737c9f2604d8ff6e70e7075830fb87"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7750b4de258d68ca0030e37974368445e5d6fb58","unresolved":false,"context_lines":[{"line_number":8614,"context_line":"        \"\"\"Return total over committed disk size for all instances.\"\"\""},{"line_number":8615,"context_line":"        # Disk size that all instance uses : virtual_size - disk_size"},{"line_number":8616,"context_line":"        disk_over_committed_size \u003d 0"},{"line_number":8617,"context_line":"        instance_domains \u003d self._host.list_instance_domains(only_running\u003dFalse)"},{"line_number":8618,"context_line":"        if not instance_domains:"},{"line_number":8619,"context_line":"            return disk_over_committed_size"},{"line_number":8620,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ffb9cba7_438ec7d0","line":8617,"range":{"start_line":8617,"start_character":8,"end_line":8617,"end_character":79},"in_reply_to":"3fce034c_d0d36337","updated":"2019-04-26 15:04:30.000000000","message":"Yeah, when an instance is in resized state, an instance is still present in virsh, it is just shut off. it gets deleted only after resize confirm, at least as of queens.","commit_id":"1ff9e9512b737c9f2604d8ff6e70e7075830fb87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f787190f97022386a00770e366f0dcde3703a2b","unresolved":false,"context_lines":[{"line_number":8614,"context_line":"        \"\"\"Return total over committed disk size for all instances.\"\"\""},{"line_number":8615,"context_line":"        # Disk size that all instance uses : virtual_size - disk_size"},{"line_number":8616,"context_line":"        disk_over_committed_size \u003d 0"},{"line_number":8617,"context_line":"        instance_domains \u003d self._host.list_instance_domains(only_running\u003dFalse)"},{"line_number":8618,"context_line":"        if not instance_domains:"},{"line_number":8619,"context_line":"            return disk_over_committed_size"},{"line_number":8620,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ffb9cba7_066207af","line":8617,"range":{"start_line":8617,"start_character":8,"end_line":8617,"end_character":79},"in_reply_to":"ffb9cba7_438ec7d0","updated":"2019-04-28 15:56:39.000000000","message":"Ack, thanks for confirming.","commit_id":"1ff9e9512b737c9f2604d8ff6e70e7075830fb87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc42b7bca00b639dfe0b0c6877750488dfefa4ee","unresolved":false,"context_lines":[{"line_number":8696,"context_line":"                    # If the instance is undergoing a task state transition,"},{"line_number":8697,"context_line":"                    # like moving to another host or is being deleted, we"},{"line_number":8698,"context_line":"                    # should ignore this instance and move on."},{"line_number":8699,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8700,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8701,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8702,"context_line":"                        # state it might also can\u0027t find back disk"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_70370fe5","line":8699,"range":{"start_line":8699,"start_character":20,"end_line":8699,"end_character":53},"updated":"2019-04-17 16:13:41.000000000","message":"Actually, how do we get past this when the instance is in VERIFY_RESIZE status? For the libvirt driver, migrate_disk_and_power_off which is called from ComputeManager.resize_instance will destroy the guest, so how is it in local_instances? Unless we\u0027re racing between the time we pulled the guest from the local hypervisor on the source node and when the vm_state changes to RESIZED - which if we miss that race window for the vm_state change then we\u0027ll still raise DiskNotFound right? Unless task_state is not None.\n\nIn other words, is it possible to hit this while the instance is in VERIFY_RESIZE steady state even though the libvirt driver destroyed the guest on the source host? I probably need to test this out in devstack.","commit_id":"1ff9e9512b737c9f2604d8ff6e70e7075830fb87"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"118a228a3d3f9f282b7dc13d1fe97329fa00ad16","unresolved":false,"context_lines":[{"line_number":8696,"context_line":"                    # If the instance is undergoing a task state transition,"},{"line_number":8697,"context_line":"                    # like moving to another host or is being deleted, we"},{"line_number":8698,"context_line":"                    # should ignore this instance and move on."},{"line_number":8699,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8700,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8701,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8702,"context_line":"                        # state it might also can\u0027t find back disk"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_90995b6f","line":8699,"range":{"start_line":8699,"start_character":20,"end_line":8699,"end_character":53},"in_reply_to":"3fce034c_70370fe5","updated":"2019-04-17 16:28:42.000000000","message":"I was hitting this on queens but do not have an env to debug this at the moment, need to try it as well.","commit_id":"1ff9e9512b737c9f2604d8ff6e70e7075830fb87"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"449fde3b15566c34b8f9e98e6b79d53ea0d9f5e0","unresolved":false,"context_lines":[{"line_number":8699,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8700,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8701,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8702,"context_line":"                        # state it might also can\u0027t find back disk"},{"line_number":8703,"context_line":"                        if (inst.task_state is not None or"},{"line_number":8704,"context_line":"                            inst.vm_state \u003d\u003d vm_states.RESIZED):"},{"line_number":8705,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_b02577ad","line":8702,"range":{"start_line":8702,"start_character":46,"end_line":8702,"end_character":51},"updated":"2019-04-17 16:14:29.000000000","message":"not be able to?","commit_id":"1ff9e9512b737c9f2604d8ff6e70e7075830fb87"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4878561ea27ac2b3dc6bb508fc52cc1a0d8a1ab3","unresolved":false,"context_lines":[{"line_number":8772,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":8773,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":8774,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":8775,"context_line":"                        # state it might also can\u0027t find back disk"},{"line_number":8776,"context_line":"                        if (inst.task_state is not None or"},{"line_number":8777,"context_line":"                            inst.vm_state \u003d\u003d vm_states.RESIZED):"},{"line_number":8778,"context_line":"                            LOG.info(\u0027Periodic task is updating the host \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"bfb3d3c7_3f4c4d9d","line":8775,"range":{"start_line":8775,"start_character":46,"end_line":8775,"end_character":66},"updated":"2019-05-20 21:42:37.000000000","message":"not be able to find the backing disk","commit_id":"966192704c20d1b4e9faf384c8dafac8ea6e06ea"}]}