)]}'
{"nova/tests/unit/virt/ironic/test_driver.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"244051036871a9f7c3dce7607d43f932f19116cf","unresolved":false,"context_lines":[{"line_number":2265,"context_line":"            mock_pgroup.return_value \u003d [portgroup]"},{"line_number":2266,"context_line":"        else:"},{"line_number":2267,"context_line":"            mock_pgroup.return_value \u003d []"},{"line_number":2268,"context_line":""},{"line_number":2269,"context_line":"        props \u003d self.driver.get_volume_connector(instance)"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"        self.assertEqual(expected_props, props)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a0bdefb1","line":2268,"updated":"2018-06-12 21:03:49.000000000","message":"nit: unrelated change","commit_id":"ff68a4350ff572e8c79d9f5b381c896b028c82b7"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0fb36b51f4628d11fd2559f236d2a7905809791a","unresolved":false,"context_lines":[{"line_number":1860,"context_line":"        props[\u0027os_type\u0027] \u003d \u0027baremetal\u0027"},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"        if \u0027host\u0027 not in props:"},{"line_number":1863,"context_line":"            props[\u0027host\u0027] \u003d instance.hostname"},{"line_number":1864,"context_line":"        # Eventually it would be nice to be able to do multipath, but for now"},{"line_number":1865,"context_line":"        # we should at least set the value to False."},{"line_number":1866,"context_line":"        props[\u0027multipath\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3ededf69","line":1863,"updated":"2018-06-12 23:05:18.000000000","message":"It feels like we would benefit from a code comment here explaining the importance of the \u0027host\u0027 field and why we\u0027re falling back on the instance.hostname. From reading the bug, I see we need to do this because some cinder backends require the \u0027host\u0027 property in order to boot from volume and currently, the \u0027host\u0027 property is only set if there is an IP in the volume connector.","commit_id":"ff68a4350ff572e8c79d9f5b381c896b028c82b7"}]}