)]}'
{"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f4f90342be6a73dbf11c51e61a85ef4db4eb4aa4","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def setUp(self):"},{"line_number":488,"context_line":"        super(TestNeutronv2Base, self).setUp()"},{"line_number":489,"context_line":"        self.mox.StubOutWithMock(neutronapi, \u0027get_client\u0027)"},{"line_number":490,"context_line":"        self.moxed_client \u003d self.mox.CreateMock(client.Client)"},{"line_number":491,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":492,"context_line":"        self.addCleanup(self.mox.VerifyAll)"},{"line_number":493,"context_line":"        self.addCleanup(self.mox.UnsetStubs)"},{"line_number":494,"context_line":"        self.addCleanup(self.stubs.UnsetAll)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def _stub_allocate_for_instance(self, net_idx\u003d1, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_68469e7e","line":493,"range":{"start_line":489,"start_character":0,"end_line":493,"end_character":44},"updated":"2018-06-28 00:37:21.000000000","message":"This part still uses mox because of just moving the code from _TestNeutronV2Common. Is that intentional? The patch series is long and it is fine to make this part out of scope from this patch. I just want to confirm.","commit_id":"ac671367d5609a844b0752236a28315129cfb0d0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"74d3a19ab7787e39e7b6f192b9b479e71420ce13","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def setUp(self):"},{"line_number":488,"context_line":"        super(TestNeutronv2Base, self).setUp()"},{"line_number":489,"context_line":"        self.mox.StubOutWithMock(neutronapi, \u0027get_client\u0027)"},{"line_number":490,"context_line":"        self.moxed_client \u003d self.mox.CreateMock(client.Client)"},{"line_number":491,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":492,"context_line":"        self.addCleanup(self.mox.VerifyAll)"},{"line_number":493,"context_line":"        self.addCleanup(self.mox.UnsetStubs)"},{"line_number":494,"context_line":"        self.addCleanup(self.stubs.UnsetAll)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def _stub_allocate_for_instance(self, net_idx\u003d1, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_c9849360","line":493,"range":{"start_line":489,"start_character":0,"end_line":493,"end_character":44},"in_reply_to":"5f7c97a3_06703a40","updated":"2018-06-28 04:51:20.000000000","message":"OK, thanks for your explanation.","commit_id":"ac671367d5609a844b0752236a28315129cfb0d0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c34c8187d9b495a6998c48d3aa630837fb3e4b86","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def setUp(self):"},{"line_number":488,"context_line":"        super(TestNeutronv2Base, self).setUp()"},{"line_number":489,"context_line":"        self.mox.StubOutWithMock(neutronapi, \u0027get_client\u0027)"},{"line_number":490,"context_line":"        self.moxed_client \u003d self.mox.CreateMock(client.Client)"},{"line_number":491,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":492,"context_line":"        self.addCleanup(self.mox.VerifyAll)"},{"line_number":493,"context_line":"        self.addCleanup(self.mox.UnsetStubs)"},{"line_number":494,"context_line":"        self.addCleanup(self.stubs.UnsetAll)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def _stub_allocate_for_instance(self, net_idx\u003d1, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_06703a40","line":493,"range":{"start_line":489,"start_character":0,"end_line":493,"end_character":44},"in_reply_to":"5f7c97a3_68469e7e","updated":"2018-06-28 04:05:30.000000000","message":"\u003e This part still uses mox because of just moving the code from\n \u003e _TestNeutronV2Common. Is that intentional?\n\nYes.\n\nThere are 2 test classes. The one is TestNeutronv2 including mox tests. The other is TestNeutronv2WithMock for mock tests.\n\n_TestNeutronv2Common includes instance variables for both TestNeutronv2 and TestNeutronv2WithMock (mox tests and mock tests).\nTestNeutronv2Base has methods for mox tests (TestNeutronv2) only.\n\nThen moves mox test methods from TestNeutronv2 to TestNeutronv2WithMock with replacing mox with mock in subsequent patches.","commit_id":"ac671367d5609a844b0752236a28315129cfb0d0"}]}