)]}'
{"nova/context.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"db6d78f3965d43b4af5d7e938d27df7bc94f8f35","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # Only include required parts of service_catalog"},{"line_number":120,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":121,"context_line":"                if s.get(\u0027type\u0027) in (\u0027image\u0027, \u0027block-storage\u0027, \u0027volumev2\u0027,"},{"line_number":122,"context_line":"                                     \u0027volumev3\u0027, \u0027key-manager\u0027, \u0027placement\u0027,"},{"line_number":123,"context_line":"                                     \u0027network\u0027)]"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            # if list is empty or none"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4c864cbd","line":122,"range":{"start_line":122,"start_character":38,"end_line":122,"end_character":46},"updated":"2018-06-04 21:49:06.000000000","message":"hm, can you describe a scenario where this would be necessary?  We ought to be getting the v3 endpoint - whatever it\u0027s called - based on \u0027block-storage\u0027, because v3 is the only thing that\u0027s supported starting with Queens.","commit_id":"11e1ae8b15ae5cc9c3b5df27c5223ad97fb4f009"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8b3a7651779f8123b703ffc2f6522a330c55e38f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # Only include required parts of service_catalog"},{"line_number":120,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":121,"context_line":"                if s.get(\u0027type\u0027) in (\u0027image\u0027, \u0027block-storage\u0027, \u0027volumev2\u0027,"},{"line_number":122,"context_line":"                                     \u0027volumev3\u0027, \u0027key-manager\u0027, \u0027placement\u0027,"},{"line_number":123,"context_line":"                                     \u0027network\u0027)]"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            # if list is empty or none"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c2b3fc09","line":122,"range":{"start_line":122,"start_character":38,"end_line":122,"end_character":46},"in_reply_to":"5f7c97a3_4c864cbd","updated":"2018-06-05 09:40:53.000000000","message":"As this is landing on stable/queens we want to allow both volumev2 _and_ volumev3 here, allowing the eventual consumer of the request context to decided which type they actually need through [cinder]catalog_info. There\u0027s no selection at this point and tbh there shouldn\u0027t be, if that\u0027s what you were getting at.","commit_id":"11e1ae8b15ae5cc9c3b5df27c5223ad97fb4f009"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"e6dca5f8e59e560eae53bedc0a747b1ec10da82a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # Only include required parts of service_catalog"},{"line_number":120,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":121,"context_line":"                if s.get(\u0027type\u0027) in (\u0027image\u0027, \u0027block-storage\u0027, \u0027volumev2\u0027,"},{"line_number":122,"context_line":"                                     \u0027volumev3\u0027, \u0027key-manager\u0027, \u0027placement\u0027,"},{"line_number":123,"context_line":"                                     \u0027network\u0027)]"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            # if list is empty or none"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c8e47be3","line":122,"range":{"start_line":122,"start_character":38,"end_line":122,"end_character":46},"in_reply_to":"5f7c97a3_4c864cbd","updated":"2018-06-05 11:10:29.000000000","message":"Eric, the context here is that a Queens n-api is creating a RequestContext which will subsequently be used by a Pike n-cpu. So while Queens may not require volumev2 here, we can\u0027t filter it out yet because it\u0027s still used by Pike.","commit_id":"11e1ae8b15ae5cc9c3b5df27c5223ad97fb4f009"}],"nova/tests/unit/test_context.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f0727401481d4dcd92758f71be4fda915a018b50","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        volume_catalog \u003d [{u\u0027type\u0027: u\u0027image\u0027, u\u0027name\u0027: u\u0027glance\u0027},"},{"line_number":116,"context_line":"                          {u\u0027type\u0027: u\u0027volumev2\u0027, u\u0027name\u0027: u\u0027cinderv2\u0027},"},{"line_number":117,"context_line":"                          {u\u0027type\u0027: u\u0027volumev3\u0027, u\u0027name\u0027: u\u0027cinderv3\u0027},"},{"line_number":118,"context_line":"                          {u\u0027type\u0027: u\u0027network\u0027, u\u0027name\u0027: u\u0027neutron\u0027},"},{"line_number":119,"context_line":"                          {u\u0027type\u0027: u\u0027block-storage\u0027, u\u0027name\u0027: u\u0027cinder\u0027}]"},{"line_number":120,"context_line":"        ctxt \u003d context.RequestContext(\u0027111\u0027, \u0027222\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ccbb3c73","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":71},"updated":"2018-06-04 21:49:44.000000000","message":"...as you can see by this.","commit_id":"11e1ae8b15ae5cc9c3b5df27c5223ad97fb4f009"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8b3a7651779f8123b703ffc2f6522a330c55e38f","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        volume_catalog \u003d [{u\u0027type\u0027: u\u0027image\u0027, u\u0027name\u0027: u\u0027glance\u0027},"},{"line_number":116,"context_line":"                          {u\u0027type\u0027: u\u0027volumev2\u0027, u\u0027name\u0027: u\u0027cinderv2\u0027},"},{"line_number":117,"context_line":"                          {u\u0027type\u0027: u\u0027volumev3\u0027, u\u0027name\u0027: u\u0027cinderv3\u0027},"},{"line_number":118,"context_line":"                          {u\u0027type\u0027: u\u0027network\u0027, u\u0027name\u0027: u\u0027neutron\u0027},"},{"line_number":119,"context_line":"                          {u\u0027type\u0027: u\u0027block-storage\u0027, u\u0027name\u0027: u\u0027cinder\u0027}]"},{"line_number":120,"context_line":"        ctxt \u003d context.RequestContext(\u0027111\u0027, \u0027222\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_42c7ec65","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":71},"in_reply_to":"5f7c97a3_ccbb3c73","updated":"2018-06-05 09:40:53.000000000","message":"Yup and again we want both to be allowed through this filter.","commit_id":"11e1ae8b15ae5cc9c3b5df27c5223ad97fb4f009"}]}