)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"44a52979eb05d76916926dd7f4e6b1de5df9ced8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"tests have been changed to have NoDBTestCase as a grandparent with an"},{"line_number":14,"context_line":"intervening parent class that sets self.context."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Where required, those tests which uses a database set USES_DB to True."},{"line_number":17,"context_line":"Subsequent patches will either remove or move these tests to functional"},{"line_number":18,"context_line":"tests where they belong."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_5f5eb5e9","line":16,"range":{"start_line":16,"start_character":34,"end_line":16,"end_character":38},"updated":"2018-06-06 22:59:58.000000000","message":"use","commit_id":"67ce24fad24e87fd934811683686cdbe62f4e405"}],"nova/tests/unit/api/openstack/placement/objects/test_resource_provider.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6f946c8589f58c62b3ba3b654fb550df92a791f7","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# FIXME(cdent): Tests which use the database aren\u0027t unit tests."},{"line_number":149,"context_line":"class TestResourceProvider(_TestCase):"},{"line_number":150,"context_line":"    USES_DB \u003d True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_create_no_parent(self):"},{"line_number":153,"context_line":"        rp \u003d resource_provider.ResourceProvider("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c971cae0","line":150,"range":{"start_line":150,"start_character":3,"end_line":150,"end_character":18},"updated":"2018-06-06 04:35:31.000000000","message":"because this case inert from NoDB test while we set USE_DB is true in this case, we probably need inherit from test.TestCase\ninstead of NoDBTest case by now to avoid confusion","commit_id":"67ce24fad24e87fd934811683686cdbe62f4e405"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"44a52979eb05d76916926dd7f4e6b1de5df9ced8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# FIXME(cdent): Tests which use the database aren\u0027t unit tests."},{"line_number":149,"context_line":"class TestResourceProvider(_TestCase):"},{"line_number":150,"context_line":"    USES_DB \u003d True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_create_no_parent(self):"},{"line_number":153,"context_line":"        rp \u003d resource_provider.ResourceProvider("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dff645d9","line":150,"range":{"start_line":150,"start_character":3,"end_line":150,"end_character":18},"in_reply_to":"5f7c97a3_c971cae0","updated":"2018-06-06 22:59:58.000000000","message":"I don\u0027t remember the details, but I seem to recall that NoDBTestCase + USE_DB \u003d True is a lot more efficient than TestCase.  I think maybe the latter implicitly does something heavyweight with nova service fixtures?","commit_id":"67ce24fad24e87fd934811683686cdbe62f4e405"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02fbee0f2592ee17a7c2454ca58dc11d1c478142","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.assertIsNone(inv_list.find(\u0027HOUSE\u0027))"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"# FIXME(cdent): Tests which use the database aren\u0027t unit tests."},{"line_number":363,"context_line":"class TestAllocation(_TestCase):"},{"line_number":364,"context_line":"    USES_DB \u003d True"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c6f1b06c","line":362,"updated":"2018-06-06 12:00:02.000000000","message":"++ yep.","commit_id":"67ce24fad24e87fd934811683686cdbe62f4e405"}]}
