)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2009968d8ecc03aa89f046dddefb0a8c95cb3ca2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In qemuDomainSetTime, VIR_ERR_OPERATION_UNSUPPORTED"},{"line_number":10,"context_line":"is used to report qemu doesn\u0027t support it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://github.com/libvirt/libvirt/blob/master/src/qemu/qemu_driver.c#L19436"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I84ddb9c434625fd4a57a4f54d0856044e1c56f3f"},{"line_number":15,"context_line":"Signed-off-by: Chen Hanxiao \u003cchenhx@certusnet.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_2c3f23b6","line":12,"range":{"start_line":12,"start_character":45,"end_line":12,"end_character":51},"updated":"2018-06-06 12:47:17.000000000","message":"It would be best to use a git hash or a tag when linking to source code otherwise this link is going to get stale quickly.","commit_id":"0eb8f5fac79d4dad03328e1bdc6e09d3cc1a3104"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"bc0731602b4a60b845bea942f86facce3bf08001","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In qemuDomainSetTime, VIR_ERR_OPERATION_UNSUPPORTED"},{"line_number":10,"context_line":"is used to report qemu doesn\u0027t support it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://github.com/libvirt/libvirt/blob/master/src/qemu/qemu_driver.c#L19436"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I84ddb9c434625fd4a57a4f54d0856044e1c56f3f"},{"line_number":15,"context_line":"Signed-off-by: Chen Hanxiao \u003cchenhx@certusnet.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_a82c6801","line":12,"range":{"start_line":12,"start_character":45,"end_line":12,"end_character":51},"in_reply_to":"5f7c97a3_2c3f23b6","updated":"2018-06-07 09:08:20.000000000","message":"Done","commit_id":"0eb8f5fac79d4dad03328e1bdc6e09d3cc1a3104"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2009968d8ecc03aa89f046dddefb0a8c95cb3ca2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            if code \u003d\u003d libvirt.VIR_ERR_AGENT_UNRESPONSIVE:"},{"line_number":169,"context_line":"                LOG.debug(\u0027Failed to set time: QEMU agent unresponsive\u0027,"},{"line_number":170,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":171,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_OPERATION_UNSUPPORTED:"},{"line_number":172,"context_line":"                LOG.debug(\u0027Failed to set time: not supported\u0027,"},{"line_number":173,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":174,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6c551bfa","line":171,"updated":"2018-06-06 12:47:17.000000000","message":"Is this possibly due to a change between different versions of libvirt?","commit_id":"0eb8f5fac79d4dad03328e1bdc6e09d3cc1a3104"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"bc0731602b4a60b845bea942f86facce3bf08001","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            if code \u003d\u003d libvirt.VIR_ERR_AGENT_UNRESPONSIVE:"},{"line_number":169,"context_line":"                LOG.debug(\u0027Failed to set time: QEMU agent unresponsive\u0027,"},{"line_number":170,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":171,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_OPERATION_UNSUPPORTED:"},{"line_number":172,"context_line":"                LOG.debug(\u0027Failed to set time: not supported\u0027,"},{"line_number":173,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":174,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e88b40bd","line":171,"in_reply_to":"5f7c97a3_6c551bfa","updated":"2018-06-07 09:08:20.000000000","message":"qemuDomainGetTime was introduce by 6f9c75a6f7cb.\nThe errno kept unchanged since then.\nI didn\u0027t find VIR_ERR_NO_SUPPORT for this case.","commit_id":"0eb8f5fac79d4dad03328e1bdc6e09d3cc1a3104"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d83c2e0fa1cb1be5efbcfd991a93a0c8787441fd","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            if code \u003d\u003d libvirt.VIR_ERR_AGENT_UNRESPONSIVE:"},{"line_number":169,"context_line":"                LOG.debug(\u0027Failed to set time: QEMU agent unresponsive\u0027,"},{"line_number":170,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":171,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_OPERATION_UNSUPPORTED:"},{"line_number":172,"context_line":"                LOG.debug(\u0027Failed to set time: not supported\u0027,"},{"line_number":173,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":174,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3843fc41","line":171,"updated":"2018-06-28 21:13:36.000000000","message":"This says only for x86 but we also support ppc64, s390x and arch64 now:\n\nhttps://github.com/libvirt/libvirt/blob/228ae70938d0cb85353e35f744fbc494de619481/src/qemu/qemu_driver.c#L19434\n\nSo was there some reason it was VIR_ERR_NO_SUPPORT before, or does it depend on the version of libvirt? Maybe it would be safer to handle both error codes?\n\nif code in (libvirt.VIR_ERR_NO_SUPPORT, libvirt.VIR_ERR_OPERATION_UNSUPPORTED):","commit_id":"a991471f3e14298a8b32d1b5d566c895cea1c8e4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a7e7be7b1b9ef3fd8500a494d0adceee7b900d9","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            if code \u003d\u003d libvirt.VIR_ERR_AGENT_UNRESPONSIVE:"},{"line_number":169,"context_line":"                LOG.debug(\u0027Failed to set time: QEMU agent unresponsive\u0027,"},{"line_number":170,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":171,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_OPERATION_UNSUPPORTED:"},{"line_number":172,"context_line":"                LOG.debug(\u0027Failed to set time: not supported\u0027,"},{"line_number":173,"context_line":"                          instance_uuid\u003dself.uuid)"},{"line_number":174,"context_line":"            elif code \u003d\u003d libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b8414c0d","line":171,"in_reply_to":"5f7c97a3_3843fc41","updated":"2018-06-28 21:20:48.000000000","message":"Nevermind, I see I already asked this once and you replied:\n\n\u003e qemuDomainGetTime was introduce by 6f9c75a6f7cb. The errno kept unchanged since then. I didn\u0027t find VIR_ERR_NO_SUPPORT for this case.\n\nLooking at the history on this, it was added with:\n\nI2732af50aab238502ccdc067f62290fd962c8c64\n\nWhich was copying this code from oVirt:\n\nhttps://gerrit.ovirt.org/#/c/50426\n\nWhich I guess basically had the same bug - kind of surprising given it was red hat people adding it, but...","commit_id":"a991471f3e14298a8b32d1b5d566c895cea1c8e4"}]}