)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9308059f526df9b230d272199a2d3e1c013b944e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add apache2 license header to all non empty files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Apache2 license says that each source file should include the license"},{"line_number":10,"context_line":"header. However, some non empty files don\u0027t have it."},{"line_number":11,"context_line":" This commit fixes it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BxTg%3D","line":9,"updated":"2013-11-20 12:49:48.000000000","message":"Indentation here is a little odd","commit_id":"34e290ae990c3c8ddffc50d17b1bb7a537326295"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e1a6fe6d875becba063d8f645385ec5e67719921","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add apache2 license header to all non empty files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Apache2 license says that each source file should include the license"},{"line_number":10,"context_line":"header. However, some non empty files don\u0027t have it."},{"line_number":11,"context_line":" This commit fixes it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BucU%3D","line":9,"in_reply_to":"AAAATn%2F%2BxTg%3D","updated":"2013-11-21 02:16:13.000000000","message":"Done","commit_id":"34e290ae990c3c8ddffc50d17b1bb7a537326295"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2fc7984da5306c36450391c6a0e1fa5134355f27","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9MBc%3D","line":15,"updated":"2013-12-15 03:33:02.000000000","message":"what license is it?","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f5921180435b646365e0e32bc8466933fd777baa","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9FA4%3D","line":15,"in_reply_to":"AAAATn%2F9GT4%3D","updated":"2013-12-17 00:42:43.000000000","message":"Thank you for checking it. And I saw your patch. IIUC, \u0027nova/contrib/boto_v6\u0027 will be removed. So I will depend on your patch for enabling H102 rule.","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"7808bc3461c81108742ce20587b564585d6bc933","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9GT4%3D","line":15,"in_reply_to":"AAAATn%2F9MAc%3D","updated":"2013-12-16 20:06:15.000000000","message":"So I checked and that is the MIT license, and we should add the apache2 license to the top too.\n\nSide note: https://review.openstack.org/62458","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cb53bdd0aca1068a76b709ff925ec2173a69c5a0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9MAc%3D","line":15,"in_reply_to":"AAAATn%2F9MBc%3D","updated":"2013-12-15 04:05:33.000000000","message":"Actually, I\u0027m not sure because contrib/boto_v6/__init__.py already has a copyright header. But it doesn\u0027t say about what license. Can we regard this as Apache2 license?","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2fc7984da5306c36450391c6a0e1fa5134355f27","unresolved":false,"context_lines":[{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] contrib/boto_v6/*"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9MBY%3D","line":16,"updated":"2013-12-15 03:33:02.000000000","message":"why not?","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f5921180435b646365e0e32bc8466933fd777baa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] contrib/boto_v6/*"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9FA0%3D","line":16,"in_reply_to":"AAAATn%2F9GT0%3D","updated":"2013-12-17 00:42:43.000000000","message":"OK. I\u0027ll add the license header to the placeholder files.","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"7808bc3461c81108742ce20587b564585d6bc933","unresolved":false,"context_lines":[{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] contrib/boto_v6/*"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9GT0%3D","line":16,"in_reply_to":"AAAATn%2F9MAE%3D","updated":"2013-12-16 20:06:15.000000000","message":"yes","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cb53bdd0aca1068a76b709ff925ec2173a69c5a0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"And we already have a hacking rule (H102) for this. We can enable it by"},{"line_number":14,"context_line":"removing \u0027H102\u0027 from the \u0027ignore\u0027 list of tox.ini file. But we can\u0027t"},{"line_number":15,"context_line":"enable at this time. Because some files are not Apache2 license[1] and"},{"line_number":16,"context_line":"db migration placeholder files[2] are not appropriate for Apache2"},{"line_number":17,"context_line":"license."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] contrib/boto_v6/*"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9MAE%3D","line":16,"in_reply_to":"AAAATn%2F9MBY%3D","updated":"2013-12-15 04:05:33.000000000","message":"Because these are just placeholder files for backporting fixes. So I guess we can allow the lacking the Apache2 License header like empty files. But this is not so strong opinion.\nShould we add the header of Apache2 license to these files?","commit_id":"421d2128acdd46b2cd9baf38bd972b17cd14044c"}],"nova/api/openstack/compute/contrib/extended_services.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b262e4a748deea61daa2c7afaaf461b6967246dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9MHk%3D","line":1,"updated":"2013-12-15 00:25:33.000000000","message":"don\u0027t need this line","commit_id":"416f1c2a7817df256422f91f6909b228916418c9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b15d66bb53bf9580c523e1d1a75f39144af41891","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F%2B40%3D","line":1,"updated":"2013-12-25 14:22:01.000000000","message":"Should this not also have:\n# Copyright 2013 OpenStack Foundation","commit_id":"731d25fdcf965a0a8763d2f372bea890c2c94801"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"7bbc97b9934abb93bc706bd8fd70ebb61e1d9a36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F%2BTs%3D","line":1,"in_reply_to":"AAAAT3%2F%2F%2B40%3D","updated":"2013-12-25 20:37:29.000000000","message":"short answer: NO. the foundation doesn\u0027t own this code.","commit_id":"731d25fdcf965a0a8763d2f372bea890c2c94801"}]}