)]}'
{"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"46a246d45297706d77f77860758c707ab6231da8","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        mocked_client \u003d mock.create_autospec(client.Client)"},{"line_number":505,"context_line":"        mock_get_client.return_value \u003d mocked_client"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        bind_host_id \u003d kwargs.get(\u0027bind_host_id\u0027) or None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        has_dns_extension \u003d False"},{"line_number":510,"context_line":"        if kwargs.get(\u0027dns_extension\u0027):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_4946a323","line":507,"range":{"start_line":507,"start_character":49,"end_line":507,"end_character":57},"updated":"2018-09-18 23:03:35.000000000","message":"nit: this \"or None\" seems unnecessary.","commit_id":"bf1cb2be59813efbb6b769c61fa0deddaa74a789"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"03c7c420d51897ca95f1836beb22a97483ec5df7","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        mocked_client \u003d mock.create_autospec(client.Client)"},{"line_number":505,"context_line":"        mock_get_client.return_value \u003d mocked_client"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        bind_host_id \u003d kwargs.get(\u0027bind_host_id\u0027) or None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        has_dns_extension \u003d False"},{"line_number":510,"context_line":"        if kwargs.get(\u0027dns_extension\u0027):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_be9d0f0a","line":507,"range":{"start_line":507,"start_character":49,"end_line":507,"end_character":57},"in_reply_to":"3f79a3b5_4946a323","updated":"2018-09-20 02:59:01.000000000","message":"Done","commit_id":"bf1cb2be59813efbb6b769c61fa0deddaa74a789"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"46a246d45297706d77f77860758c707ab6231da8","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            mocked_client.update_port.side_effect \u003d update_port_values"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"            mock_get_nw.return_value \u003d self._returned_nw_info"},{"line_number":636,"context_line":"        except test.TestingException:"},{"line_number":637,"context_line":"            pass"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        # Call the allocate_for_instance method"},{"line_number":640,"context_line":"        nw_info \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_c90873da","line":637,"range":{"start_line":636,"start_character":0,"end_line":637,"end_character":16},"updated":"2018-09-18 23:03:35.000000000","message":"How about moving this \"excpet\" block to line 631 for making the expectation range of the exception small as possible?\nThat could make the test code easy I feel.","commit_id":"bf1cb2be59813efbb6b769c61fa0deddaa74a789"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"03c7c420d51897ca95f1836beb22a97483ec5df7","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            mocked_client.update_port.side_effect \u003d update_port_values"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"            mock_get_nw.return_value \u003d self._returned_nw_info"},{"line_number":636,"context_line":"        except test.TestingException:"},{"line_number":637,"context_line":"            pass"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        # Call the allocate_for_instance method"},{"line_number":640,"context_line":"        nw_info \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_de19eb87","line":637,"range":{"start_line":636,"start_character":0,"end_line":637,"end_character":16},"in_reply_to":"3f79a3b5_c90873da","updated":"2018-09-20 02:59:01.000000000","message":"Done","commit_id":"bf1cb2be59813efbb6b769c61fa0deddaa74a789"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"46a246d45297706d77f77860758c707ab6231da8","unresolved":false,"context_lines":[{"line_number":747,"context_line":"                ordered_networks.append(request)"},{"line_number":748,"context_line":"            if show_port_values:"},{"line_number":749,"context_line":"                mocked_client.show_port.side_effect \u003d show_port_values"},{"line_number":750,"context_line":"        else:"},{"line_number":751,"context_line":"            for n in nets:"},{"line_number":752,"context_line":"                ordered_networks.append("},{"line_number":753,"context_line":"                    objects.NetworkRequest(network_id\u003dn[\u0027id\u0027]))"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return expected_show_port_calls"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_491d430d","line":753,"range":{"start_line":750,"start_character":0,"end_line":753,"end_character":63},"updated":"2018-09-18 23:03:35.000000000","message":"In this case, the fuction just append ordered_networks and returns []. In addition, the above case indent is very deep.\nHow about\n\n if not requested_networks:\n     for n in nets:\n         ordered_networks.append(..)\n     return []\n for request in requested_networks:\n     ...\n\nfor reducing the indents?","commit_id":"bf1cb2be59813efbb6b769c61fa0deddaa74a789"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"03c7c420d51897ca95f1836beb22a97483ec5df7","unresolved":false,"context_lines":[{"line_number":747,"context_line":"                ordered_networks.append(request)"},{"line_number":748,"context_line":"            if show_port_values:"},{"line_number":749,"context_line":"                mocked_client.show_port.side_effect \u003d show_port_values"},{"line_number":750,"context_line":"        else:"},{"line_number":751,"context_line":"            for n in nets:"},{"line_number":752,"context_line":"                ordered_networks.append("},{"line_number":753,"context_line":"                    objects.NetworkRequest(network_id\u003dn[\u0027id\u0027]))"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return expected_show_port_calls"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_e42d3846","line":753,"range":{"start_line":750,"start_character":0,"end_line":753,"end_character":63},"in_reply_to":"3f79a3b5_491d430d","updated":"2018-09-20 02:59:01.000000000","message":"\u003e for request in requested_networks:\n\nThere is a case that requested_networks is None.\nSo it is not appropriate. (I cannot do so.)","commit_id":"bf1cb2be59813efbb6b769c61fa0deddaa74a789"}]}