)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ca840f9e6b7420e4db7117bea9ec2735e50c8744","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return \"deleted\" time of instance when vm_state is DELETED or SOFT-DELETED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While showing deleted instances, we want to see instance\u0027s deleted time."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I60e1e092cfb3b9c30363d86c5d2431c1f48caa14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_46946537","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":0},"updated":"2018-06-11 08:37:28.000000000","message":"You should add bp ref in here.","commit_id":"d2576b2ded48c31581158bf115e0958e4ea839af"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ca840f9e6b7420e4db7117bea9ec2735e50c8744","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                           show_extra_specs),"},{"line_number":140,"context_line":"                \"created\": utils.isotime(instance[\"created_at\"]),"},{"line_number":141,"context_line":"                \"updated\": utils.isotime(instance[\"updated_at\"]),"},{"line_number":142,"context_line":"                \"deleted\": utils.isotime("},{"line_number":143,"context_line":"                    instance[\"deleted_at\"]) if instance.get(\"vm_state\") in ["},{"line_number":144,"context_line":"                    vm_states.DELETED, vm_states.SOFT_DELETED] else \u0027\u0027,"},{"line_number":145,"context_line":"                \"addresses\": self._get_addresses(request, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_86c27d52","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":40},"updated":"2018-06-11 08:37:28.000000000","message":"You added the \u0027deleted\u0027 field and change the behavior in API, so, we need introduce a new micro-version for this change, see ref [1]\n\n[1] https://docs.openstack.org/nova/latest/contributor/microversions.html","commit_id":"d2576b2ded48c31581158bf115e0958e4ea839af"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f76a7f6fde77912a28ee22d05405d6e6a20138a4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                           show_extra_specs),"},{"line_number":140,"context_line":"                \"created\": utils.isotime(instance[\"created_at\"]),"},{"line_number":141,"context_line":"                \"updated\": utils.isotime(instance[\"updated_at\"]),"},{"line_number":142,"context_line":"                \"deleted\": utils.isotime("},{"line_number":143,"context_line":"                    instance[\"deleted_at\"]) if instance.get(\"vm_state\") in ["},{"line_number":144,"context_line":"                    vm_states.DELETED, vm_states.SOFT_DELETED] else \u0027\u0027,"},{"line_number":145,"context_line":"                \"addresses\": self._get_addresses(request, instance,"},{"line_number":146,"context_line":"                                                 extend_address),"},{"line_number":147,"context_line":"                \"accessIPv4\": str(ip_v4) if ip_v4 is not None else \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c4ea5f0c","line":144,"range":{"start_line":142,"start_character":16,"end_line":144,"end_character":71},"updated":"2018-07-10 08:15:36.000000000","message":"this should be only available for admin, as only admins are able to list deleted instances.","commit_id":"8835584f16a42c40fe3f43e6680ebc904dcf0d4a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"1e105a688e2fd2e77333a46cd767620f883213ef","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                trusted_certs \u003d instance.trusted_certs.ids"},{"line_number":179,"context_line":"            server[\"server\"][\"trusted_image_certificates\"] \u003d trusted_certs"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if getattr(request.environ[\"nova.context\"], \u0027is_admin\u0027, False):"},{"line_number":182,"context_line":"            server[\"server\"][\"deleted\"] \u003d utils.isotime("},{"line_number":183,"context_line":"                instance[\"deleted_at\"]) if instance.get(\"vm_state\") in ["},{"line_number":184,"context_line":"                vm_states.DELETED, vm_states.SOFT_DELETED] else \u0027\u0027"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6211fa5b","line":182,"range":{"start_line":181,"start_character":8,"end_line":182,"end_character":56},"updated":"2018-07-10 10:36:31.000000000","message":"from this, I think we need mention it\u0027s a admin only API in the doc\n\nalso, I believe you need add 2.64 check here to avoid backward incompatible changes?","commit_id":"3f4046979d09cc58b003336ad2c26c679e589c5f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"44ad51995cf3d13809ac8a52081cfe181e8d93c0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                trusted_certs \u003d instance.trusted_certs.ids"},{"line_number":179,"context_line":"            server[\"server\"][\"trusted_image_certificates\"] \u003d trusted_certs"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if getattr(request.environ[\"nova.context\"], \u0027is_admin\u0027, False):"},{"line_number":182,"context_line":"            server[\"server\"][\"deleted\"] \u003d utils.isotime("},{"line_number":183,"context_line":"                instance[\"deleted_at\"]) if instance.get(\"vm_state\") in ["},{"line_number":184,"context_line":"                vm_states.DELETED, vm_states.SOFT_DELETED] else \u0027\u0027"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_93deea0d","line":182,"range":{"start_line":181,"start_character":8,"end_line":182,"end_character":56},"in_reply_to":"5f7c97a3_6211fa5b","updated":"2018-07-10 12:32:06.000000000","message":"yeah, backward compatibility should be added.","commit_id":"3f4046979d09cc58b003336ad2c26c679e589c5f"}]}