)]}'
{"id":"openstack%2Fnova~57430","triplet_id":"openstack%2Fnova~master~I8ba648a2c3068fb906f609eaa6f064ada0fc4b38","project":"openstack/nova","branch":"master","topic":"bug/1202965","hashtags":[],"change_id":"I8ba648a2c3068fb906f609eaa6f064ada0fc4b38","subject":"Fix total vcpu calculation in libvirt driver","status":"ABANDONED","created":"2013-11-20 12:05:35.000000000","updated":"2013-12-05 06:03:12.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"91f5ab8e52c692634d0e4f4ff6afe3053a73faf1","_number":57430,"virtual_id_number":57430,"owner":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":-1,"date":"2013-11-22 11:22:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"all":[{"value":-1,"date":"2013-11-27 10:48:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},{"value":0,"date":"2013-11-25 13:04:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2013-11-27 10:48:03.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-20 22:08:25.000000000","updated_by":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"reviewer":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"state":"REVIEWER"},{"updated":"2013-11-21 12:53:25.000000000","updated_by":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"reviewer":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"state":"REVIEWER"},{"updated":"2013-11-21 13:39:05.000000000","updated_by":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"reviewer":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"state":"REVIEWER"},{"updated":"2013-11-22 09:55:35.000000000","updated_by":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"reviewer":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"state":"REVIEWER"},{"updated":"2013-11-22 11:22:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-11-27 10:48:03.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"}],"messages":[{"id":"b4e1d70251c1d65f03b5fabd49218efa893bacd9","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-20 13:18:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6de7ef054a6c93a33925dc9e40d1d3813725cef1","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-20 14:49:58.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"5a582c0b125bf9dbe4411f817915c9c436509ae2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-20 14:50:53.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/30/57430/2/check/gate-nova-pep8/ef2e8fd : SUCCESS in 5m 48s\n- gate-nova-docs http://docs-draft.openstack.org/30/57430/2/check/gate-nova-docs/1e1109e/doc/build/html/ : SUCCESS in 4m 50s\n- gate-nova-python26 http://logs.openstack.org/30/57430/2/check/gate-nova-python26/b8fea53 : SUCCESS in 21m 44s\n- gate-nova-python27 http://logs.openstack.org/30/57430/2/check/gate-nova-python27/f763058 : SUCCESS in 20m 32s\n- check-tempest-devstack-vm-full http://logs.openstack.org/30/57430/2/check/check-tempest-devstack-vm-full/4f4b9a8 : SUCCESS in 1h 09m 47s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/30/57430/2/check/check-tempest-devstack-vm-postgres-full/bace9d9 : FAILURE in 1h 07m 14s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/30/57430/2/check/check-tempest-devstack-vm-neutron/f37e7ad : SUCCESS in 57m 50s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/30/57430/2/check/gate-tempest-devstack-vm-large-ops/c47f684 : SUCCESS in 31m 01s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/30/57430/2/check/gate-tempest-devstack-vm-neutron-large-ops/25e5ec3 : SUCCESS in 31m 27s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/30/57430/2/check/check-grenade-devstack-vm/b262479 : FAILURE in 1h 00m 23s\n- gate-devstack-vm-cells http://logs.openstack.org/30/57430/2/check/gate-devstack-vm-cells/414c427 : SUCCESS in 33m 40s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/30/57430/2/check/gate-nova-pylint/faaba42 : SUCCESS in 13m 55s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"382f520cdf4119b5702a38e1826246f77d50d874","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-20 15:21:26.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"9b7e0c656ee93ef30b9d68ef6393ae67d6330119","author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"date":"2013-11-20 16:40:48.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(6 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f4c12aa20d9a90a0592092abb56ea639e87afd8c","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-20 16:46:22.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"66259e9ab74c237d364afeab0d5eb7f8886fab6e","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-20 17:00:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a8b989fa7bfebd4115f2dc4a92962be804082ad2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-20 19:24:07.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/30/57430/3/check/gate-nova-pep8/8bcb487 : SUCCESS in 10m 04s\n- gate-nova-docs http://docs-draft.openstack.org/30/57430/3/check/gate-nova-docs/c93c682/doc/build/html/ : SUCCESS in 9m 06s\n- gate-nova-python26 http://logs.openstack.org/30/57430/3/check/gate-nova-python26/8f93148 : SUCCESS in 28m 59s\n- gate-nova-python27 http://logs.openstack.org/30/57430/3/check/gate-nova-python27/f74b094 : SUCCESS in 24m 08s\n- check-tempest-devstack-vm-full http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-full/e815c27 : SUCCESS in 1h 11m 24s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-postgres-full/e98128d : SUCCESS in 1h 11m 59s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-neutron/585e77d : SUCCESS in 1h 02m 42s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/30/57430/3/check/gate-tempest-devstack-vm-large-ops/94b4421 : SUCCESS in 51m 14s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/30/57430/3/check/gate-tempest-devstack-vm-neutron-large-ops/47e00c0 : SUCCESS in 54m 49s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/30/57430/3/check/check-grenade-devstack-vm/bb6f0ff : FAILURE in 1h 00m 39s\n- gate-devstack-vm-cells http://logs.openstack.org/30/57430/3/check/gate-devstack-vm-cells/ceb9afd : SUCCESS in 46m 18s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/30/57430/3/check/gate-nova-pylint/6b3569f : SUCCESS in 19m 45s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"1efc55bed343dbb392eca8c6388cdf3d00bd6815","author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"date":"2013-11-20 22:08:25.000000000","message":"Patch Set 3:\n\nrecheck bug 1233957","accounts_in_message":[],"_revision_number":3},{"id":"c35f8cf1bed27bf8691ff38e2760889b62d65cb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-20 23:03:48.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/30/57430/3/check/gate-nova-pep8/52529bd : SUCCESS in 4m 32s\n- gate-nova-docs http://docs-draft.openstack.org/30/57430/3/check/gate-nova-docs/76a2a96/doc/build/html/ : SUCCESS in 3m 45s\n- gate-nova-python26 http://logs.openstack.org/30/57430/3/check/gate-nova-python26/99284bf : SUCCESS in 17m 44s\n- gate-nova-python27 http://logs.openstack.org/30/57430/3/check/gate-nova-python27/9ffea4b : SUCCESS in 20m 35s\n- check-tempest-devstack-vm-full http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-full/4f03f29 : SUCCESS in 50m 22s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-postgres-full/345a413 : FAILURE in 46m 05s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-neutron/08abe75 : SUCCESS in 36m 37s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/30/57430/3/check/gate-tempest-devstack-vm-large-ops/484dece : SUCCESS in 14m 29s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/30/57430/3/check/gate-tempest-devstack-vm-neutron-large-ops/2715cbd : SUCCESS in 16m 44s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/30/57430/3/check/check-grenade-devstack-vm/46045bd : SUCCESS in 36m 30s\n- gate-devstack-vm-cells http://logs.openstack.org/30/57430/3/check/gate-devstack-vm-cells/f15d896 : SUCCESS in 9m 33s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/30/57430/3/check/gate-nova-pylint/f257509 : SUCCESS in 14m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"079e883eb731f0058ffdaae515a6934c39d7795f","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-11-20 23:04:00.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s): https://bugs.launchpad.net/bugs/1251920","accounts_in_message":[],"_revision_number":3},{"id":"66c75c9b85e00b4e12bfa2922e12e8708f9a1405","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-21 09:46:44.000000000","message":"Patch Set 3:\n\nrecheck bug 1251920","accounts_in_message":[],"_revision_number":3},{"id":"14c09ba16e7692f4b3ecb6db6beab558f9f80406","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-21 11:14:21.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/30/57430/3/check/gate-nova-pep8/86f0c08 : SUCCESS in 7m 21s\n- gate-nova-docs http://docs-draft.openstack.org/30/57430/3/check/gate-nova-docs/7c2a4ac/doc/build/html/ : SUCCESS in 7m 30s\n- gate-nova-python26 http://logs.openstack.org/30/57430/3/check/gate-nova-python26/7dfbcd1 : SUCCESS in 27m 03s\n- gate-nova-python27 http://logs.openstack.org/30/57430/3/check/gate-nova-python27/916c319 : SUCCESS in 16m 56s\n- check-tempest-devstack-vm-full http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-full/11dcbd3 : FAILURE in 1h 03m 17s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-postgres-full/ae5c908 : SUCCESS in 59m 52s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/30/57430/3/check/check-tempest-devstack-vm-neutron/a29c33e : FAILURE in 42m 55s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/30/57430/3/check/gate-tempest-devstack-vm-large-ops/7f8769f : SUCCESS in 32m 38s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/30/57430/3/check/gate-tempest-devstack-vm-neutron-large-ops/b77e8a1 : SUCCESS in 34m 03s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/30/57430/3/check/check-grenade-devstack-vm/40640ba : SUCCESS in 58m 03s\n- gate-devstack-vm-cells http://logs.openstack.org/30/57430/3/check/gate-devstack-vm-cells/b4005c9 : SUCCESS in 27m 34s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/30/57430/3/check/gate-nova-pylint/f408a6b : SUCCESS in 17m 42s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"83a27b8feeaf6286c40154c3a4388608fcc79daa","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-11-21 11:14:34.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s): https://bugs.launchpad.net/bugs/1249065","accounts_in_message":[],"_revision_number":3},{"id":"b7268f4820f4db963329e3cf474afd5fe32025e0","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-22 09:20:31.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"b0ab480b805808ea5e20cb2278f3ad43f1787c53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 09:20:40.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"a1d48b0bddeb5e24397b9da71521f071d92e997b","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-22 09:37:08.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"19b05561f8c649f221f03e51d8b93c642d0c0b5a","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-11-22 09:55:35.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nif you want to get the real number of vCPUs, you should change here, the corefilter will use the \u0027old\u0027 vcpus and multiple it by the cpu allocation ratio to get the real number of vCPUs of the host:\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/core_filter.py#L57","accounts_in_message":[],"_revision_number":4},{"id":"5863cb866cdfecb57372734936d2c976defa5b3b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 10:29:04.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/30/57430/4/check/gate-nova-pep8/344bbc6 : SUCCESS in 4m 31s\n- gate-nova-docs http://docs-draft.openstack.org/30/57430/4/check/gate-nova-docs/f8c5618/doc/build/html/ : SUCCESS in 4m 05s\n- gate-nova-python26 http://logs.openstack.org/30/57430/4/check/gate-nova-python26/8fb4391 : SUCCESS in 19m 48s\n- gate-nova-python27 http://logs.openstack.org/30/57430/4/check/gate-nova-python27/e32ce3d : SUCCESS in 16m 07s\n- check-tempest-devstack-vm-full http://logs.openstack.org/30/57430/4/check/check-tempest-devstack-vm-full/063303d : SUCCESS in 37m 58s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/30/57430/4/check/check-tempest-devstack-vm-postgres-full/66487a1 : SUCCESS in 33m 04s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/30/57430/4/check/check-tempest-devstack-vm-neutron/45a79a7 : SUCCESS in 25m 53s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/30/57430/4/check/gate-tempest-devstack-vm-large-ops/6882bc8 : SUCCESS in 17m 26s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/30/57430/4/check/gate-tempest-devstack-vm-neutron-large-ops/8281c59 : SUCCESS in 18m 38s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/30/57430/4/check/check-grenade-devstack-vm/cd0e8c2 : SUCCESS in 23m 36s\n- gate-devstack-vm-cells http://logs.openstack.org/30/57430/4/check/gate-devstack-vm-cells/cfe2c36 : SUCCESS in 9m 14s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/30/57430/4/check/gate-nova-pylint/fe36174 : SUCCESS in 13m 44s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"e0789bfabb3e9694b8fa42e07309617441b544a4","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-22 10:38:15.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"d6acb65a7dbdebca1993e583a5d2f3bb4c1032c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 11:22:03.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/30/57430/5/check/gate-nova-pep8/a1749b1 : SUCCESS in 5m 27s\n- gate-nova-docs http://docs-draft.openstack.org/30/57430/5/check/gate-nova-docs/87c573e/doc/build/html/ : SUCCESS in 3m 56s\n- gate-nova-python26 http://logs.openstack.org/30/57430/5/check/gate-nova-python26/570a06c : FAILURE in 19m 55s\n- gate-nova-python27 http://logs.openstack.org/30/57430/5/check/gate-nova-python27/7967175 : FAILURE in 15m 45s\n- check-tempest-devstack-vm-full http://logs.openstack.org/30/57430/5/check/check-tempest-devstack-vm-full/dfcba22 : SUCCESS in 31m 38s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/30/57430/5/check/check-tempest-devstack-vm-postgres-full/0cf20ae : SUCCESS in 34m 38s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/30/57430/5/check/check-tempest-devstack-vm-neutron/7f670f6 : SUCCESS in 28m 09s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/30/57430/5/check/gate-tempest-devstack-vm-large-ops/e8cc8d1 : SUCCESS in 13m 58s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/30/57430/5/check/gate-tempest-devstack-vm-neutron-large-ops/45135de : SUCCESS in 16m 24s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/30/57430/5/check/check-grenade-devstack-vm/bff7c43 : SUCCESS in 23m 41s\n- gate-devstack-vm-cells http://logs.openstack.org/30/57430/5/check/gate-devstack-vm-cells/6e7216a : SUCCESS in 9m 51s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/30/57430/5/check/gate-nova-pylint/b82b8c8 : SUCCESS in 14m 00s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"b131172c9aed6b1403f69b265f912c30a764b1fd","author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"date":"2013-11-25 13:04:57.000000000","message":"Patch Set 5:\n\nI\u0027m pretty new to Nova (and OpenStack in general...) and I\u0027m afraid this change will break the AggregateCoreFilter.\nAs I understand it, this change makes host_state.vcpus_total aware of the cpu_allocation_ratio. So I wonder if this aggregated ratio is still needed.\n\nIf there is different allocation ratio per aggregate, (if i understand correctly) this would already be taken care of in the host_state.vcpus_total calculation. Thus why would the AggregateCoreFilter need to get the minimum cpu_allocation_ratio ?","accounts_in_message":[],"_revision_number":5},{"id":"b65797a2211a9aef21f67577ae6d3c071eab91eb","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-11-27 10:48:03.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"412befca539137bc39109aebc3f2075664f24f94","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-12-05 06:03:12.000000000","message":"Patch Set 5: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":5},{"id":"1a804f536d9e7f02f5939e3d35225ece1fafd7e3","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-12-05 06:03:12.000000000","message":"Patch Set 5:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"93d29d91d1627f78434be9b8e13fe7b19bacceb9","revisions":{"301aae671c32ca8d2cff9b4f7df75efd8629fcf6":{"kind":"REWORK","_number":1,"created":"2013-11-20 12:05:35.000000000","uploader":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"ref":"refs/changes/30/57430/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/57430/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/57430/1"}}},"commit":{"parents":[{"commit":"84bddb030cfbae255941e17f100c1e51c697dbe6","subject":"Merge \"Remove unused local variable in test_compute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84bddb030cfbae255941e17f100c1e51c697dbe6"}]}],"author":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 13:01:20.000000000","tz":-300},"committer":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 13:03:17.000000000","tz":-300},"subject":"Fix total vcpu calculation in libvirt driver","message":"Fix total vcpu calculation in libvirt driver\n\nThe get_vcpu_total method in libvirt driver currently return the total\npcpu. This is not consistent with the get_vcpu_used method, which might\nreturns a greater vcpu_used than vcpu_total. This fix uses\ncpu_allocation_ratio parameter to calculate correct vcpu_total. Also\nprovide a test case to validate the data being returned.\n\nMore work is needed to return the pcpu.\n\nChange-Id: I8ba648a2c3068fb906f609eaa6f064ada0fc4b38\nPartial-Bug: #1202965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/301aae671c32ca8d2cff9b4f7df75efd8629fcf6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/301aae671c32ca8d2cff9b4f7df75efd8629fcf6"}]},"branch":"refs/heads/master"},"294b63b8fca08d645bae663f6f9902009e3ec165":{"kind":"REWORK","_number":2,"created":"2013-11-20 13:18:26.000000000","uploader":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"ref":"refs/changes/30/57430/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/57430/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/57430/2"}}},"commit":{"parents":[{"commit":"84bddb030cfbae255941e17f100c1e51c697dbe6","subject":"Merge \"Remove unused local variable in test_compute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84bddb030cfbae255941e17f100c1e51c697dbe6"}]}],"author":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 13:01:20.000000000","tz":-300},"committer":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 14:15:14.000000000","tz":-300},"subject":"Fix total vcpu calculation in libvirt driver","message":"Fix total vcpu calculation in libvirt driver\n\nThe get_vcpu_total method in libvirt driver currently return the total\npcpu. This is not consistent with the get_vcpu_used method, which might\nreturns a greater vcpu_used than vcpu_total. This fix uses\ncpu_allocation_ratio parameter to calculate correct vcpu_total. Also\nprovide a test case to validate the data being returned.\n\nMore work is needed to return the pcpu.\n\nChange-Id: I8ba648a2c3068fb906f609eaa6f064ada0fc4b38\nPartial-Bug: #1202965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/294b63b8fca08d645bae663f6f9902009e3ec165"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/294b63b8fca08d645bae663f6f9902009e3ec165"}]},"branch":"refs/heads/master"},"87b25b3c512af2aca355a62162cf74cfe1d409d0":{"kind":"REWORK","_number":3,"created":"2013-11-20 17:00:45.000000000","uploader":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"ref":"refs/changes/30/57430/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/57430/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/57430/3"}}},"commit":{"parents":[{"commit":"84bddb030cfbae255941e17f100c1e51c697dbe6","subject":"Merge \"Remove unused local variable in test_compute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84bddb030cfbae255941e17f100c1e51c697dbe6"}]}],"author":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 13:01:20.000000000","tz":-300},"committer":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 17:58:12.000000000","tz":-300},"subject":"Fix total vcpu calculation in libvirt driver","message":"Fix total vcpu calculation in libvirt driver\n\nThe get_vcpu_total method in libvirt driver currently returns the total\npcpu. This is not consistent with the get_vcpu_used method, which might\nreturn a greater vcpu_used than vcpu_total. This fix uses\ncpu_allocation_ratio parameter to calculate correct vcpu_total. Also\nprovide a test case to validate the data being returned.\n\nMore work is needed to return the pcpu.\n\nChange-Id: I8ba648a2c3068fb906f609eaa6f064ada0fc4b38\nPartial-Bug: #1202965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/87b25b3c512af2aca355a62162cf74cfe1d409d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/87b25b3c512af2aca355a62162cf74cfe1d409d0"}]},"branch":"refs/heads/master"},"84cfaf0973cef32e4fd9b0273caf9182daa21b16":{"kind":"REWORK","_number":4,"created":"2013-11-22 09:37:08.000000000","uploader":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"ref":"refs/changes/30/57430/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/57430/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/57430/4"}}},"commit":{"parents":[{"commit":"9b1cb0c1f8f427646a4782e5ba33e7c45b1ff876","subject":"Merge \"all_tenants\u003d0 should not return instances from all tenants\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b1cb0c1f8f427646a4782e5ba33e7c45b1ff876"}]}],"author":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 13:01:20.000000000","tz":-300},"committer":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-21 10:34:06.000000000","tz":-300},"subject":"Fix total vcpu calculation in libvirt driver","message":"Fix total vcpu calculation in libvirt driver\n\nThe get_vcpu_total method in libvirt driver currently returns the total\npcpu. This is not consistent with the get_vcpu_used method, which might\nreturn a greater vcpu_used than vcpu_total. This fix uses\ncpu_allocation_ratio parameter to calculate correct vcpu_total. Also\nprovide a test case to validate the data being returned.\n\nMore work is needed to return the pcpu.\n\nChange-Id: I8ba648a2c3068fb906f609eaa6f064ada0fc4b38\nPartial-Bug: #1202965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84cfaf0973cef32e4fd9b0273caf9182daa21b16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84cfaf0973cef32e4fd9b0273caf9182daa21b16"}]},"branch":"refs/heads/master"},"93d29d91d1627f78434be9b8e13fe7b19bacceb9":{"kind":"REWORK","_number":5,"created":"2013-11-22 10:38:15.000000000","uploader":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"ref":"refs/changes/30/57430/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/57430/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/57430/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/57430/5"}}},"commit":{"parents":[{"commit":"9b1cb0c1f8f427646a4782e5ba33e7c45b1ff876","subject":"Merge \"all_tenants\u003d0 should not return instances from all tenants\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b1cb0c1f8f427646a4782e5ba33e7c45b1ff876"}]}],"author":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-19 13:01:20.000000000","tz":-300},"committer":{"name":"Tristan Cacqueray","email":"tristan.cacqueray@enovance.com","date":"2013-11-21 11:35:44.000000000","tz":-300},"subject":"Fix total vcpu calculation in libvirt driver","message":"Fix total vcpu calculation in libvirt driver\n\nThe get_vcpu_total method in libvirt driver currently returns the total\npcpu. This is not consistent with the get_vcpu_used method, which might\nreturn a greater vcpu_used than vcpu_total. This fix uses\ncpu_allocation_ratio parameter to calculate correct vcpu_total. Also\nprovide a test case to validate the data being returned.\n\nMore work is needed to return the pcpu.\n\nChange-Id: I8ba648a2c3068fb906f609eaa6f064ada0fc4b38\nPartial-Bug: #1202965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93d29d91d1627f78434be9b8e13fe7b19bacceb9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93d29d91d1627f78434be9b8e13fe7b19bacceb9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
