)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5cca9451d845ef65717bff4ddd3db090ba4d5b5","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"                try:"},{"line_number":4084,"context_line":"                    attachment_record \u003d self.volume_api.attachment_get("},{"line_number":4085,"context_line":"                        ctxt, attachment_id)"},{"line_number":4086,"context_line":"                    # Note that the attachment record from Cinder has"},{"line_number":4087,"context_line":"                    # attach_mode in the top-level of the resource but the"},{"line_number":4088,"context_line":"                    # nova.volume.cinder code translates it and puts the"},{"line_number":4089,"context_line":"                    # attach_mode in the connection_info for some legacy"},{"line_number":4090,"context_line":"                    # reason..."},{"line_number":4091,"context_line":"                    if attachment_record[\u0027attach_mode\u0027] \u003d\u003d \u0027rw\u0027:"},{"line_number":4092,"context_line":"                        count +\u003d 1"},{"line_number":4093,"context_line":"                except exception.VolumeAttachmentNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b5477a1d","line":4090,"range":{"start_line":4086,"start_character":20,"end_line":4090,"end_character":31},"updated":"2018-08-24 15:33:34.000000000","message":"We can remove this now.","commit_id":"a3cfc11a0451d269d1ca3bce5687383b046b84d2"}],"nova/volume/cinder.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4e48bff310cef87241277c53031ab943bf737b9e","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        # Now the catch all..."},{"line_number":367,"context_line":"        for k, v in attachment_ref.items():"},{"line_number":368,"context_line":"            # Keep these as top-level fields on the attachment record."},{"line_number":369,"context_line":"            if k not in (\"id\", \"attach_mode\"):"},{"line_number":370,"context_line":"                translated_con_info[k] \u003d v"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    attachment_ref[\u0027connection_info\u0027] \u003d translated_con_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_70d8007e","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":46},"updated":"2018-06-13 06:40:01.000000000","message":"don\u0027t fully get this\n\ndoes this mean attach_mode will not be included in the \ntranslated_con_info at all?","commit_id":"a3cfc11a0451d269d1ca3bce5687383b046b84d2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0fe0fd72d3f0fa0b42feb243b5a6f4f5977d8c87","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        # Now the catch all..."},{"line_number":367,"context_line":"        for k, v in attachment_ref.items():"},{"line_number":368,"context_line":"            # Keep these as top-level fields on the attachment record."},{"line_number":369,"context_line":"            if k not in (\"id\", \"attach_mode\"):"},{"line_number":370,"context_line":"                translated_con_info[k] \u003d v"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    attachment_ref[\u0027connection_info\u0027] \u003d translated_con_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_30293e88","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":46},"in_reply_to":"5f7c97a3_70d8007e","updated":"2018-07-19 01:55:23.000000000","message":"No, it means we don\u0027t take the attach_mode from the attachment record as a top-level key and put it into the attachment[\u0027connection_info\u0027] dict, which already has an access_mode key. As the commit message mentions, the virt driver cares about access_mode in connection_info, but the nova API cares about attach_mode in the top-level of the attachment record. See the change below this in the series to see why I\u0027m doing this.","commit_id":"a3cfc11a0451d269d1ca3bce5687383b046b84d2"}]}