)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"8efc0a5d7254b863e0df266481bfb61fd4156136","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"    @wsgi.deserializers(xml\u003dActionDeserializer)"},{"line_number":1087,"context_line":"    @wsgi.action(\u0027reboot\u0027)"},{"line_number":1088,"context_line":"    def _action_reboot(self, req, id, body):"},{"line_number":1089,"context_line":"        if \u0027reboot\u0027 in body and \u0027type\u0027 in body[\u0027reboot\u0027] and body[\u0027reboot\u0027][\u0027type\u0027] is not None:"},{"line_number":1090,"context_line":"            valid_reboot_types \u003d [\u0027HARD\u0027, \u0027SOFT\u0027]"},{"line_number":1091,"context_line":"            reboot_type \u003d body[\u0027reboot\u0027][\u0027type\u0027].upper()"},{"line_number":1092,"context_line":"            if not valid_reboot_types.count(reboot_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bv2I%3D","line":1089,"updated":"2013-11-20 18:10:29.000000000","message":"Too long lines.","commit_id":"6d4f905a5359e2c801648179603df5c695435d25"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"8efc0a5d7254b863e0df266481bfb61fd4156136","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"                LOG.error(msg)"},{"line_number":1095,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1096,"context_line":"        else:"},{"line_number":1097,"context_line":"            msg \u003d _(\"Missing argument \u0027type\u0027 for reboot\")"},{"line_number":1098,"context_line":"            LOG.error(msg)"},{"line_number":1099,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bv1s%3D","line":1097,"updated":"2013-11-20 18:10:29.000000000","message":"This error information seems not accurate to me, but not idea if tge solution to make it better.","commit_id":"6d4f905a5359e2c801648179603df5c695435d25"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1d7ffebf9446f20e04140a5ceb1f987815462ee8","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"    @wsgi.action(\u0027reboot\u0027)"},{"line_number":1088,"context_line":"    def _action_reboot(self, req, id, body):"},{"line_number":1089,"context_line":"        if \u0027reboot\u0027 in body and \u0027type\u0027 in body[\u0027reboot\u0027]:"},{"line_number":1090,"context_line":"            if body[\u0027reboot\u0027][\u0027type\u0027] is None:"},{"line_number":1091,"context_line":"                msg \u003d _(\"Argument \u0027type\u0027 for reboot must not be None\")"},{"line_number":1092,"context_line":"                LOG.error(msg)"},{"line_number":1093,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BuUk%3D","line":1090,"updated":"2013-11-21 02:57:33.000000000","message":"We can use \"if not isinstance(body[\u0027reboot\u0027][\u0027type\u0027] six.string_types):\", That can avoid we pass other type(like dict, list...) to it.","commit_id":"6751929e38291d4590a66de59092af6fd95bc5f0"}]}