)]}'
{"id":"openstack%2Fnova~5750","triplet_id":"openstack%2Fnova~master~Ica9c65952b800d316d264db11f89e369e56bcade","project":"openstack/nova","branch":"master","topic":"bug/963357","hashtags":[],"change_id":"Ica9c65952b800d316d264db11f89e369e56bcade","subject":"makes volume versions display properly","status":"MERGED","created":"2012-03-23 20:30:23.000000000","updated":"2012-03-25 22:00:48.000000000","submitted":"2012-03-25 22:00:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2a39440ecb1a92f5ff44a21bd128edc4bb38f603","_number":5750,"virtual_id_number":5750,"owner":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-03-25 22:00:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"all":[{"value":2,"date":"2012-03-25 21:50:04.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":2,"date":"2012-03-23 22:09:07.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-03-23 21:54:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-03-25 22:00:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"all":[{"value":1,"date":"2012-03-25 21:50:04.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"date":"2012-03-23 22:09:07.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-03-23 21:54:57.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-23 20:33:47.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-03-23 21:12:51.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-03-23 22:09:07.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2012-03-25 21:50:04.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2012-03-25 22:00:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a76a3e155ffc5f7b0530126aa10a383f152b50c4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-23 20:33:47.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"59d802a4dd016643da5b1796d604d25a4c9354d9","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-03-23 20:34:47.000000000","message":"Patch Set 1:\n\nIsn\u0027t there a unit test that should have caught this?","accounts_in_message":[],"_revision_number":1},{"id":"d04e3c64a267a82295c2dec622605d76ca4f344f","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-03-23 21:12:51.000000000","message":"Patch Set 1:\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/16368\n\tLibvirt (Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/16366\n\tXenServer (Ubuntu 11.10) Success: http://smokestack.openstack.org/?go\u003d/jobs/16367","accounts_in_message":[],"_revision_number":1},{"id":"448d685abd7455ee22d2edaab2d90dd1a20988fe","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-23 21:30:16.000000000","message":"Patch Set 1:\n\nI\u0027ve been trying to create a test, but the error is lost somewhere in the wsgi processing. I can\u0027t actually make it fail in the test, just when I\u0027m running the whole stack.","accounts_in_message":[],"_revision_number":1},{"id":"7032ac5b466da4839a9deeab1648124bbc2ca6e5","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-23 21:30:39.000000000","message":"Patch Set 1:\n\nI can only reproduce this when running the whole stack.\n:(","accounts_in_message":[],"_revision_number":1},{"id":"cedc18d47207705d59c5e613f877590ff8b9290b","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-23 21:53:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8c777623c65ca9fe3cb54ecb44a40cc51465df22","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-23 21:54:57.000000000","message":"Patch Set 2:\n\nI made a very naive test which verifies that dispatch can be called properly.  I was trying to make a test which does the request as the api does and gets a traceback but I can\u0027t seem to do it without pulling in the whole stack.","accounts_in_message":[],"_revision_number":2},{"id":"2b5cd451a9b134ec4201a5e4d660982d05512a49","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-03-23 22:09:07.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nSome testing is better than no testing. Still curious why it requires the full stack to be pulled in to reproduce it.","accounts_in_message":[],"_revision_number":2},{"id":"f8bcbe8b8b1cb5f32f205284e02492c5ad5af11b","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-03-25 21:50:04.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nNasty issue, fix makes sense\n\nI might have completely removed the dependence on the compute Versions class by also copying the get_action_args() method, but whatever :)","accounts_in_message":[],"_revision_number":2},{"id":"1490397a72be7f85609b9f6ff194fef9593dfecd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-25 22:00:46.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2968/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/2017/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1673/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3398/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"094e40e8bdbe182550dd0bb19e008120c6f10aeb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-25 22:00:48.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aa29a67d5cecfa320f98fa9989bf0b9179240016","revisions":{"7b7dcce2d27e9cd845a57487d71363554dfcc788":{"kind":"REWORK","_number":1,"created":"2012-03-23 20:30:23.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/50/5750/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/5750/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/5750/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/5750/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/5750/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/5750/1"}}},"commit":{"parents":[{"commit":"30dc7d11c13c1075d441a72932957e26ef3355b7","subject":"Convert libvirt connection class to use config APIs for graphics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30dc7d11c13c1075d441a72932957e26ef3355b7"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-23 20:27:34.000000000","tz":0},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-23 20:30:20.000000000","tz":0},"subject":"makes volume versions display properly","message":"makes volume versions display properly\n\n * The compute versions controller changed during a refactor and broke\n   the volume versions controller (since we are using it as a base class)\n * fixes bug 963357\n\nChange-Id: Ica9c65952b800d316d264db11f89e369e56bcade\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7b7dcce2d27e9cd845a57487d71363554dfcc788"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7b7dcce2d27e9cd845a57487d71363554dfcc788"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"30dc7d11c13c1075d441a72932957e26ef3355b7","is_merged_in_target_branch":true,"change_id":"Ifa18cab2aa6983c9439c6230a9109e40a6a0bbe3","change_number":5615,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"aa29a67d5cecfa320f98fa9989bf0b9179240016":{"kind":"REWORK","_number":2,"created":"2012-03-23 21:53:35.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/50/5750/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/5750/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/5750/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/5750/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/5750/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/5750/2"}}},"commit":{"parents":[{"commit":"81ac4e729c0ca9e8fdb8064db30ae05eb8ce74a7","subject":"Introduce a class for storing libvirt CPU configuration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/81ac4e729c0ca9e8fdb8064db30ae05eb8ce74a7"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-23 20:27:34.000000000","tz":0},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-23 21:53:27.000000000","tz":0},"subject":"makes volume versions display properly","message":"makes volume versions display properly\n\n * The compute versions controller changed during a refactor and broke\n   the volume versions controller (since we are using it as a base class)\n * Added naive test\n * fixes bug 963357\n\nChange-Id: Ica9c65952b800d316d264db11f89e369e56bcade\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aa29a67d5cecfa320f98fa9989bf0b9179240016"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aa29a67d5cecfa320f98fa9989bf0b9179240016"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"81ac4e729c0ca9e8fdb8064db30ae05eb8ce74a7","is_merged_in_target_branch":true,"change_id":"Ib508637c1e0ca69860d461b0a480347c59165e6b","change_number":5622,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}