)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"723e4c31f9c210872d65725189b9bf194d0168a3","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        for location in locations:"},{"line_number":924,"context_line":"            if self.driver.is_cloneable(location, image_meta):"},{"line_number":925,"context_line":"                LOG.debug(\u0027Selected location: %(loc)s\u0027, {\u0027loc\u0027: location})"},{"line_number":926,"context_line":"                return self.driver.clone(location, self.rbd_name, dest_pool\u003dself.pool)"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"        reason \u003d _(\u0027No image locations are accessible\u0027)"},{"line_number":929,"context_line":"        raise exception.ImageUnacceptable(image_id\u003dimage_id_or_uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2509cc2f","line":926,"range":{"start_line":926,"start_character":65,"end_line":926,"end_character":86},"updated":"2018-06-14 05:07:11.000000000","message":"need fix pep8, others LGTM","commit_id":"dcd0f84e14295b41e1bca2f048102e3d7e3916c3"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"f6834682513d53dbb3d32d51807b32e91ffa0251","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        for location in locations:"},{"line_number":924,"context_line":"            if self.driver.is_cloneable(location, image_meta):"},{"line_number":925,"context_line":"                LOG.debug(\u0027Selected location: %(loc)s\u0027, {\u0027loc\u0027: location})"},{"line_number":926,"context_line":"                return self.driver.clone(location, self.rbd_name, dest_pool\u003dself.pool)"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"        reason \u003d _(\u0027No image locations are accessible\u0027)"},{"line_number":929,"context_line":"        raise exception.ImageUnacceptable(image_id\u003dimage_id_or_uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_343d7c8d","line":926,"range":{"start_line":926,"start_character":65,"end_line":926,"end_character":86},"in_reply_to":"5f7c97a3_2509cc2f","updated":"2018-06-14 09:15:56.000000000","message":"ok thx","commit_id":"dcd0f84e14295b41e1bca2f048102e3d7e3916c3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3a315d98fcfa453782e79bc225e6784801b5c8e8","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        for location in locations:"},{"line_number":924,"context_line":"            if self.driver.is_cloneable(location, image_meta):"},{"line_number":925,"context_line":"                LOG.debug(\u0027Selected location: %(loc)s\u0027, {\u0027loc\u0027: location})"},{"line_number":926,"context_line":"                return self.driver.clone(location,"},{"line_number":927,"context_line":"                                         self.rbd_name,"},{"line_number":928,"context_line":"                                         dest_pool\u003dself.pool)"},{"line_number":929,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_bedba6e7","line":926,"updated":"2018-06-14 12:28:43.000000000","message":"It took me a bit to trace through this.  At first glance, this appears to be a nontrivial change, because the value of dest_pool is being passed around to constructors and helpers a couple of layers deep.  It ultimately lands in nova.virt.libvirt.storage.rbd_utils.RBDDriver._connect_to_rados where, if unset, it gets set to the RBDDriver\u0027s self.pool attribute.  So I go back up the stack to find where *that* guy is set... and it eventually turns out to be the same thing you\u0027re passing in here.  Maybe.  Unless there\u0027s some intervening code I didn\u0027t see that sets the default to some other value.\n\nOpportunities for grand refactoring aside, this certainly warrants unit testing to make sure the appropriate value is being percolated through the stack.","commit_id":"250b5a2b7f2a49c7310e98b48a8ab7b7ddd5787e"}]}