)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3cdb6baceb4d5d48e206bd60aa8159bd4ed967fe","unresolved":false,"context_lines":[{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        return vnic_type, trusted"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def create_resource_requests(self, context, requested_networks,"},{"line_number":1599,"context_line":"                                 pci_requests\u003dNone):"},{"line_number":1600,"context_line":"        \"\"\"Retrieve all information for the networks passed at the time of"},{"line_number":1601,"context_line":"        creating the server."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_72127ab6","line":1598,"range":{"start_line":1598,"start_character":8,"end_line":1598,"end_character":32},"updated":"2018-06-22 10:05:59.000000000","message":"I like this generic name. This is where I could plug the bandwidth resource gathering from the port in the bandwidth series. \n\nI think the following structure would be better:\n\ncreate_resource_requests():\n    for req in requested_networks:\n        if req is a port:\n            port \u003d show_port(req)  # the only show_port call\n\n            get_port_vnic_info(port)\n\n            network \u003d show_network(port)\n            get_physnet(network)\n\n            # later on I will add \n            get_resource_request(port) # get the bandwidth req\n        elif req is a network:\n            network \u003d show_network(req)\n            get_physnet(network)\n    ...\n\n\nThis would only call show port and show network once per requested network","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"24cf3ec9147addc938ff6ba0398080ed8e90c50e","unresolved":false,"context_lines":[{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        return vnic_type, trusted"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def create_resource_requests(self, context, requested_networks,"},{"line_number":1599,"context_line":"                                 pci_requests\u003dNone):"},{"line_number":1600,"context_line":"        \"\"\"Retrieve all information for the networks passed at the time of"},{"line_number":1601,"context_line":"        creating the server."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_611da6bc","line":1598,"range":{"start_line":1598,"start_character":8,"end_line":1598,"end_character":32},"in_reply_to":"5f7c97a3_52773909","updated":"2018-06-25 12:54:08.000000000","message":"I\u0027m OK with the one in the next patch in the latest patch set.","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"be7f30c1ccbc0c4f2056f1c8d8f3ba85538fef92","unresolved":false,"context_lines":[{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        return vnic_type, trusted"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def create_resource_requests(self, context, requested_networks,"},{"line_number":1599,"context_line":"                                 pci_requests\u003dNone):"},{"line_number":1600,"context_line":"        \"\"\"Retrieve all information for the networks passed at the time of"},{"line_number":1601,"context_line":"        creating the server."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_52773909","line":1598,"range":{"start_line":1598,"start_character":8,"end_line":1598,"end_character":32},"in_reply_to":"5f7c97a3_72127ab6","updated":"2018-06-22 15:01:39.000000000","message":"I don\u0027t think this is necessary anymore but if you\u0027d rather a different pattern, the change should be in the next patch, I think","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2c2d2b33dc7a71c6998dcc1845fe5a2aae253f85","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"                network_id \u003d self._show_port("},{"line_number":1614,"context_line":"                    context, request_net.port_id, neutron_client\u003dneutron,"},{"line_number":1615,"context_line":"                    fields\u003d[\u0027network_id\u0027])[\u0027network_id\u0027]"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"                physnet \u003d self._get_network_info("},{"line_number":1618,"context_line":"                    context, neutron, network_id)"},{"line_number":1619,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c8c6499d","line":1616,"updated":"2018-06-21 19:01:50.000000000","message":"random whitespace?","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"be7f30c1ccbc0c4f2056f1c8d8f3ba85538fef92","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"                network_id \u003d self._show_port("},{"line_number":1614,"context_line":"                    context, request_net.port_id, neutron_client\u003dneutron,"},{"line_number":1615,"context_line":"                    fields\u003d[\u0027network_id\u0027])[\u0027network_id\u0027]"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"                physnet \u003d self._get_network_info("},{"line_number":1618,"context_line":"                    context, neutron, network_id)"},{"line_number":1619,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_727cb5ea","line":1616,"in_reply_to":"5f7c97a3_c8c6499d","updated":"2018-06-22 15:01:39.000000000","message":"Done","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2c2d2b33dc7a71c6998dcc1845fe5a2aae253f85","unresolved":false,"context_lines":[{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"                physnet \u003d self._get_network_info("},{"line_number":1618,"context_line":"                    context, neutron, network_id)"},{"line_number":1619,"context_line":""},{"line_number":1620,"context_line":"                vnic_type, trusted \u003d self._get_port_vnic_info("},{"line_number":1621,"context_line":"                    context, neutron, request_net.port_id)"},{"line_number":1622,"context_line":"                LOG.debug(\"Creating PCI device request for port_id\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e8cb05a1","line":1619,"updated":"2018-06-21 19:01:50.000000000","message":"and here?","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"be7f30c1ccbc0c4f2056f1c8d8f3ba85538fef92","unresolved":false,"context_lines":[{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"                physnet \u003d self._get_network_info("},{"line_number":1618,"context_line":"                    context, neutron, network_id)"},{"line_number":1619,"context_line":""},{"line_number":1620,"context_line":"                vnic_type, trusted \u003d self._get_port_vnic_info("},{"line_number":1621,"context_line":"                    context, neutron, request_net.port_id)"},{"line_number":1622,"context_line":"                LOG.debug(\"Creating PCI device request for port_id\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_127d41e5","line":1619,"in_reply_to":"5f7c97a3_e8cb05a1","updated":"2018-06-22 15:01:39.000000000","message":"Done","commit_id":"ea50f76d6e1c3566cddfc01b58d27b3105b37ea9"}]}