)]}'
{"nova/compute/instance_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"63aecfb16132244b18b73b3a8f5e38c087ede54c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # got here and there is no cell for the instance mapping, that means"},{"line_number":67,"context_line":"        # the build request is also gone and we really screwed up somewhere,"},{"line_number":68,"context_line":"        # so log an error for the operator and raise a 500."},{"line_number":69,"context_line":"        # if im.cell_mapping is None:"},{"line_number":70,"context_line":"        if instance_mapping.cell_mapping is None:"},{"line_number":71,"context_line":"            # TODO(mriedem): Should we check if a BuildRequest actually does"},{"line_number":72,"context_line":"            # exist for the instance? Like what if the user is listing"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_54426511","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":37},"updated":"2018-06-15 01:22:55.000000000","message":"oops, need to remove this","commit_id":"d6b8035d39df62ecbedf8c26f610204a60bb8aec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ee9757941533fb2587503260db77904a28e4539","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # so log an error for the operator and raise a 500."},{"line_number":69,"context_line":"        # if im.cell_mapping is None:"},{"line_number":70,"context_line":"        if instance_mapping.cell_mapping is None:"},{"line_number":71,"context_line":"            # TODO(mriedem): Should we check if a BuildRequest actually does"},{"line_number":72,"context_line":"            # exist for the instance? Like what if the user is listing"},{"line_number":73,"context_line":"            # instances and filtering on something that won\u0027t be in build"},{"line_number":74,"context_line":"            # requests, like ip, and also providing a marker that is still"},{"line_number":75,"context_line":"            # a build request?"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c6f3f99e","line":72,"range":{"start_line":71,"start_character":29,"end_line":72,"end_character":37},"updated":"2018-06-18 13:46:56.000000000","message":"I\u0027m going to write a functional regression test which does the following:\n\n1. create server but block the rpc cast to conductor so the instance stays a build request - we have a fixture for that\n2. list instances using the build request uuid as the marker and filter with the ip filter which due to change Ic02206e887e3fea7752d615bbed680510c482097 will skip the build requests filtering and go straight to the cells instance lister - at which point I think we\u0027ll blow up here.","commit_id":"d6b8035d39df62ecbedf8c26f610204a60bb8aec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b34324a1952866fe51d056423bb9c8647380414","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # so log an error for the operator and raise a 500."},{"line_number":69,"context_line":"        # if im.cell_mapping is None:"},{"line_number":70,"context_line":"        if instance_mapping.cell_mapping is None:"},{"line_number":71,"context_line":"            # TODO(mriedem): Should we check if a BuildRequest actually does"},{"line_number":72,"context_line":"            # exist for the instance? Like what if the user is listing"},{"line_number":73,"context_line":"            # instances and filtering on something that won\u0027t be in build"},{"line_number":74,"context_line":"            # requests, like ip, and also providing a marker that is still"},{"line_number":75,"context_line":"            # a build request?"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e4694df8","line":72,"range":{"start_line":71,"start_character":29,"end_line":72,"end_character":37},"in_reply_to":"5f7c97a3_c6f3f99e","updated":"2018-06-18 15:01:20.000000000","message":"https://review.openstack.org/#/c/576161/","commit_id":"d6b8035d39df62ecbedf8c26f610204a60bb8aec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d6eff5a662bf320afdb9142a4a87232eae0a4b5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            # instances and filtering on something that won\u0027t be in build"},{"line_number":74,"context_line":"            # requests, like ip, and also providing a marker that is still"},{"line_number":75,"context_line":"            # a build request?"},{"line_number":76,"context_line":"            LOG.error(\u0027Found instance_mappings record for instance but it is \u0027"},{"line_number":77,"context_line":"                      \u0027not mapped to a cell, nor is there a build_requests \u0027"},{"line_number":78,"context_line":"                      \u0027entry for this instance, which indicates an internal \u0027"},{"line_number":79,"context_line":"                      \u0027error occurred during scheduling of the instance and \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_114b8928","line":76,"updated":"2018-07-23 20:40:45.000000000","message":"It looks like we could hit a case where the instance is deleted via the build request record during scheduling, we handle the build request not found here:\n\nhttps://github.com/openstack/nova/blob/bcbc1f9aeddb060513768489450c429bf53e1e46/nova/conductor/manager.py#L1244\n\nbut we don\u0027t bury the instance in cell0 so the instance mapping wouldn\u0027t have a cell_mapping record on it....","commit_id":"d6b8035d39df62ecbedf8c26f610204a60bb8aec"}]}