)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78a833ba5f86a69071e7a880da3c629dc49eca63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Surya Seetharaman \u003csuryaseetharaman.9@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-17 20:55:36 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make nova list ignore down cells"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes InstanceLister ignore down cells and list the"},{"line_number":10,"context_line":"instances from the up cell as opposed to giving 500 to the users"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_953d25be","line":7,"updated":"2018-06-18 16:28:16.000000000","message":"This isn\u0027t just handling down cells for listing instances, it\u0027s also for listing migration records which use the multi-cell lister framework.","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"1e1a9d50da4043909f2b5d675277df78715bad1a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Surya Seetharaman \u003csuryaseetharaman.9@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-17 20:55:36 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make nova list ignore down cells"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes InstanceLister ignore down cells and list the"},{"line_number":10,"context_line":"instances from the up cell as opposed to giving 500 to the users"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_263984d7","line":7,"in_reply_to":"5f7c97a3_953d25be","updated":"2018-06-18 19:41:06.000000000","message":"I keep forgetting we use this for migrations listing.","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78a833ba5f86a69071e7a880da3c629dc49eca63","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make nova list ignore down cells"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes InstanceLister ignore down cells and list the"},{"line_number":10,"context_line":"instances from the up cell as opposed to giving 500 to the users"},{"line_number":11,"context_line":"as is the current situation."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_157355b6","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":31},"updated":"2018-06-18 16:28:16.000000000","message":"and MigrationLister","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"1e1a9d50da4043909f2b5d675277df78715bad1a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make nova list ignore down cells"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes InstanceLister ignore down cells and list the"},{"line_number":10,"context_line":"instances from the up cell as opposed to giving 500 to the users"},{"line_number":11,"context_line":"as is the current situation."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_a62594b0","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":31},"in_reply_to":"5f7c97a3_157355b6","updated":"2018-06-18 19:41:06.000000000","message":"my bad,","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"3ad8f5ac2f2f0f8c2fbeaf650b1c43988fe61944","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make nova list and migration-list ignore down cells"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes InstanceLister and MigrationLister ignore down"},{"line_number":10,"context_line":"cells and list the instances from the up cell as opposed to"},{"line_number":11,"context_line":"giving 500 to the users as is the current situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I308b494ab07f6936bef94f4c9da45e9473e3534d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_4d030111","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":28},"updated":"2018-06-25 11:03:10.000000000","message":"records(instances or migrations)","commit_id":"233ed0047235e27753782c1af8e0b1c403c670c0"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"ea69e1f9e497cdea48310f9d4cca36fe846fe6c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make nova list and migration-list ignore down cells"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes InstanceLister and MigrationLister ignore down"},{"line_number":10,"context_line":"cells and list the instances from the up cell as opposed to"},{"line_number":11,"context_line":"giving 500 to the users as is the current situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I308b494ab07f6936bef94f4c9da45e9473e3534d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_3cd6f528","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":28},"in_reply_to":"5f7c97a3_4d030111","updated":"2018-06-25 13:02:36.000000000","message":"oops.","commit_id":"233ed0047235e27753782c1af8e0b1c403c670c0"}],"nova/compute/multi_cell_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78a833ba5f86a69071e7a880da3c629dc49eca63","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            return (RecordWrapper(self.sort_ctx, inst) for inst in"},{"line_number":244,"context_line":"                    itertools.chain(local_marker_prefix, main_query_result))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # FIXME(danms): If we raise or timeout on a cell we need to handle"},{"line_number":247,"context_line":"        # that here gracefully. The below routine will provide sentinels"},{"line_number":248,"context_line":"        # to indicate that, which will crash the merge below, but we don\u0027t"},{"line_number":249,"context_line":"        # handle this anywhere yet anyway."},{"line_number":250,"context_line":"        if self.cells:"},{"line_number":251,"context_line":"            results \u003d context.scatter_gather_cells(ctx, self.cells, 60,"},{"line_number":252,"context_line":"                                                   do_query)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_752f2988","line":249,"range":{"start_line":246,"start_character":8,"end_line":249,"end_character":42},"updated":"2018-06-18 16:28:16.000000000","message":"Does this get updated or removed?","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"1e1a9d50da4043909f2b5d675277df78715bad1a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            return (RecordWrapper(self.sort_ctx, inst) for inst in"},{"line_number":244,"context_line":"                    itertools.chain(local_marker_prefix, main_query_result))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # FIXME(danms): If we raise or timeout on a cell we need to handle"},{"line_number":247,"context_line":"        # that here gracefully. The below routine will provide sentinels"},{"line_number":248,"context_line":"        # to indicate that, which will crash the merge below, but we don\u0027t"},{"line_number":249,"context_line":"        # handle this anywhere yet anyway."},{"line_number":250,"context_line":"        if self.cells:"},{"line_number":251,"context_line":"            results \u003d context.scatter_gather_cells(ctx, self.cells, 60,"},{"line_number":252,"context_line":"                                                   do_query)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_66545cff","line":249,"range":{"start_line":246,"start_character":8,"end_line":249,"end_character":42},"in_reply_to":"5f7c97a3_752f2988","updated":"2018-06-18 19:41:06.000000000","message":"whoops, I think this part of the change did not get reflected. On it!","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":23654,"name":"tianmaofu","email":"tianmaofu@126.com","username":"tianmaofu"},"change_message_id":"9f01dde4ed36322222c552b1c81c14fafec63518","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                                   do_query)"},{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":255,"context_line":"        for k in results.copy():"},{"line_number":256,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":257,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":258,"context_line":"                results.pop(k)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f12f83a4","line":255,"range":{"start_line":255,"start_character":14,"end_line":255,"end_character":16},"updated":"2018-06-21 09:25:30.000000000","message":"Can we make did_not_respond_sentinel and raised_exception_sentinel to empty list in context.py? so we don\u0027t need to delete those here.","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"52d921fa5714492f709d971b4bbd9ec9eacf9852","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                                   do_query)"},{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":255,"context_line":"        for k in results.copy():"},{"line_number":256,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":257,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":258,"context_line":"                results.pop(k)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d9dc18e3","line":255,"range":{"start_line":255,"start_character":17,"end_line":255,"end_character":31},"updated":"2018-06-19 17:35:08.000000000","message":"This could be large, wouldn\u0027t it be better to iterate a copy of just the keys?","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"f12b2bacc42102b0e4ded17e01b807a3bc6b4167","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                                   do_query)"},{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":255,"context_line":"        for k in results.copy():"},{"line_number":256,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":257,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":258,"context_line":"                results.pop(k)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_119c8dbd","line":255,"range":{"start_line":255,"start_character":17,"end_line":255,"end_character":31},"in_reply_to":"5f7c97a3_d9dc18e3","updated":"2018-06-20 16:48:49.000000000","message":"ack","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78a833ba5f86a69071e7a880da3c629dc49eca63","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":255,"context_line":"        for k in results.copy():"},{"line_number":256,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":257,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":258,"context_line":"                results.pop(k)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_956685ee","line":256,"updated":"2018-06-18 16:28:16.000000000","message":"I\u0027m thinking we should probably log a warning in here?","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"1e1a9d50da4043909f2b5d675277df78715bad1a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":255,"context_line":"        for k in results.copy():"},{"line_number":256,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":257,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":258,"context_line":"                results.pop(k)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_06432841","line":256,"in_reply_to":"5f7c97a3_956685ee","updated":"2018-06-18 19:41:06.000000000","message":"Done","commit_id":"3b5dc64870161e2e26ddb009837441a1bc11e880"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3a075b1a22b2300b7d4c2b82b77e7990482dcce","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                                                   do_query)"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0a3ad0cb","line":261,"range":{"start_line":261,"start_character":17,"end_line":261,"end_character":30},"updated":"2018-06-25 06:39:52.000000000","message":"Do we need to copy the keys for a particular reason?\nIf not then you can drop the list() call as iterating a dict means iterating the keys by default.","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3a075b1a22b2300b7d4c2b82b77e7990482dcce","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                                                   do_query)"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_ea2c3494","line":261,"range":{"start_line":261,"start_character":12,"end_line":261,"end_character":13},"updated":"2018-06-25 06:39:52.000000000","message":"I would rename \u0027k\u0027 to \u0027cell\u0027 or \u0027cell_uuid\u0027 for readability","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"08a90bbd51b34ffd82b3fb0af0565f120b0971f6","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                                                   do_query)"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_bc1c4513","line":261,"range":{"start_line":261,"start_character":12,"end_line":261,"end_character":13},"in_reply_to":"5f7c97a3_8d4a7924","updated":"2018-06-25 13:10:04.000000000","message":"I see, you are popping from the dict below. I missed that, sorry. Then I\u0027m OK copying the keys for the iteration.","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"ac6fe5a5cf86bf7b024877dbef8bbc23d5638389","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                                                   do_query)"},{"line_number":259,"context_line":"        else:"},{"line_number":260,"context_line":"            results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_8d4a7924","line":261,"range":{"start_line":261,"start_character":12,"end_line":261,"end_character":13},"in_reply_to":"5f7c97a3_ea2c3494","updated":"2018-06-25 09:00:09.000000000","message":"We need to copy keys because python3.x raises a “RuntimeError: dictionary changed size during iteration” , yes you are right, I will rename k to a more meaning-full name.","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3a075b1a22b2300b7d4c2b82b77e7990482dcce","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"},{"line_number":265,"context_line":"                results.pop(k)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        # If a limit was provided, it was passed to the per-cell query"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_af664e28","line":264,"updated":"2018-06-25 06:39:52.000000000","message":"I would state in the log that the cell %s is skipped from the result to ease the troubleshooting a bit.","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"ac6fe5a5cf86bf7b024877dbef8bbc23d5638389","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"},{"line_number":265,"context_line":"                results.pop(k)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        # If a limit was provided, it was passed to the per-cell query"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2d6325b3","line":264,"in_reply_to":"5f7c97a3_4d8d417a","updated":"2018-06-25 09:00:09.000000000","message":"ack, I will change this to be more verbose like you have said.","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"cc08c8d6d8285e99fa492d3b12de5488cb7caced","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        for k in list(results):"},{"line_number":262,"context_line":"            if results[k] in (context.did_not_respond_sentinel,"},{"line_number":263,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":264,"context_line":"                LOG.warning(\"Cell %s is not responding\", k)"},{"line_number":265,"context_line":"                results.pop(k)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        # If a limit was provided, it was passed to the per-cell query"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_4d8d417a","line":264,"in_reply_to":"5f7c97a3_af664e28","updated":"2018-06-25 08:52:07.000000000","message":"+1","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"}],"nova/tests/unit/compute/test_instance_list.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3a075b1a22b2300b7d4c2b82b77e7990482dcce","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def test_get_instances_with_down_cells(self, mock_sg):"},{"line_number":144,"context_line":"        inst_cell0 \u003d self.insts[uuids.cell0]"},{"line_number":145,"context_line":"        # storing the uuids of the instances from the up cell"},{"line_number":146,"context_line":"        uuid_initial \u003d []"},{"line_number":147,"context_line":"        for inst in inst_cell0:"},{"line_number":148,"context_line":"            uuid_initial.append(inst[\u0027uuid\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        instances \u003d (multi_cell_list.RecordWrapper(self.context, inst)"},{"line_number":151,"context_line":"                     for inst in inst_cell0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_6a56e407","line":148,"range":{"start_line":146,"start_character":1,"end_line":148,"end_character":45},"updated":"2018-06-25 06:39:52.000000000","message":"you could write:\n\n    uuid_initial \u003d [inst for inst in inst_cell0]\n\nor even:\n\n    uuid_initial \u003d [inst for inst in self.insts[uuids.cell0]]\n\nfor a bit more pythonic style","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"ac6fe5a5cf86bf7b024877dbef8bbc23d5638389","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def test_get_instances_with_down_cells(self, mock_sg):"},{"line_number":144,"context_line":"        inst_cell0 \u003d self.insts[uuids.cell0]"},{"line_number":145,"context_line":"        # storing the uuids of the instances from the up cell"},{"line_number":146,"context_line":"        uuid_initial \u003d []"},{"line_number":147,"context_line":"        for inst in inst_cell0:"},{"line_number":148,"context_line":"            uuid_initial.append(inst[\u0027uuid\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        instances \u003d (multi_cell_list.RecordWrapper(self.context, inst)"},{"line_number":151,"context_line":"                     for inst in inst_cell0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_ed0d2de7","line":148,"range":{"start_line":146,"start_character":1,"end_line":148,"end_character":45},"in_reply_to":"5f7c97a3_6a56e407","updated":"2018-06-25 09:00:09.000000000","message":"ack, sorry for the style-issues.","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3a075b1a22b2300b7d4c2b82b77e7990482dcce","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        res \u003d instance_list.get_instances_sorted(self.context, {}, None, None,"},{"line_number":161,"context_line":"                                                 [], None, None)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        uuid_final \u003d []"},{"line_number":164,"context_line":"        for inst in res:"},{"line_number":165,"context_line":"            uuid_final.append(inst[\u0027uuid\u0027])"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # return the results from the up cell, ignoring the down cell."},{"line_number":168,"context_line":"        self.assertEqual(uuid_initial, uuid_final)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0a3f30b5","line":165,"range":{"start_line":163,"start_character":1,"end_line":165,"end_character":43},"updated":"2018-06-25 06:39:52.000000000","message":"ditto:\n\n    uuid_final \u003d [inst for inst in res]","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"ac6fe5a5cf86bf7b024877dbef8bbc23d5638389","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        res \u003d instance_list.get_instances_sorted(self.context, {}, None, None,"},{"line_number":161,"context_line":"                                                 [], None, None)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        uuid_final \u003d []"},{"line_number":164,"context_line":"        for inst in res:"},{"line_number":165,"context_line":"            uuid_final.append(inst[\u0027uuid\u0027])"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # return the results from the up cell, ignoring the down cell."},{"line_number":168,"context_line":"        self.assertEqual(uuid_initial, uuid_final)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_adf3b5e6","line":165,"range":{"start_line":163,"start_character":1,"end_line":165,"end_character":43},"in_reply_to":"5f7c97a3_0a3f30b5","updated":"2018-06-25 09:00:09.000000000","message":"Done","commit_id":"c094fbb5aa3e8adad41e9a7034c9e701c4bd516e"}],"releasenotes/notes/instance-migration-lister-behaviour-change-82726cac592e9728.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7a408da6ea8f0675dc3a3cb73a9fd0c820e549d7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Listing instances and migrations records used to give a 500 to the users"},{"line_number":5,"context_line":"    when a cell DB was unreachable. This fix changes this behavior by"},{"line_number":6,"context_line":"    returning a 200 instead along with results from the up cells. The down"},{"line_number":7,"context_line":"    cells are basically skipped when forming the results and this solution is"},{"line_number":8,"context_line":"    planned to be further enhanced through the `bp handling-down-cell`_."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_1ee20331","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":44},"updated":"2018-06-25 21:16:33.000000000","message":"This should be updated - release notes are read in batches and referring to something like \"this fix\" out of context will be confusing to readers.","commit_id":"a009e919a5a6993cfa40c34910a733a01d2c484f"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"0f4e62edc80f629a93acb0c9f78cddbdf7d97f42","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Listing instances and migrations records used to give a 500 to the users"},{"line_number":5,"context_line":"    when a cell DB was unreachable. This fix changes this behavior by"},{"line_number":6,"context_line":"    returning a 200 instead along with results from the up cells. The down"},{"line_number":7,"context_line":"    cells are basically skipped when forming the results and this solution is"},{"line_number":8,"context_line":"    planned to be further enhanced through the `bp handling-down-cell`_."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_c76b57b6","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":44},"in_reply_to":"5f7c97a3_1ee20331","updated":"2018-06-26 06:03:30.000000000","message":"Thanks for fixing this.","commit_id":"a009e919a5a6993cfa40c34910a733a01d2c484f"}]}