)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"20a59f3d06282bdd4126bd7e78ba312ce57dd3c7","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"                \"Compute driver doesn\u0027t require allocation refresh and we\u0027re \""},{"line_number":1230,"context_line":"                \"on a compute host in a deployment that only has compute\""},{"line_number":1231,"context_line":"                \"hosts with Nova versions \u003e\u003d16 (Pike). Skipping \""},{"line_number":1232,"context_line":"                \"of auto-correction allocations. \")"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        LOG.debug(msg_allocation_refresh)"},{"line_number":1235,"context_line":"        for instance in instances:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a3f00b68","line":1232,"range":{"start_line":1232,"start_character":17,"end_line":1232,"end_character":35},"updated":"2018-06-19 16:12:59.000000000","message":"auto-correction of","commit_id":"62161bdb02aa80f4ea9021d0d7b1f0f7807263ab"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"20a59f3d06282bdd4126bd7e78ba312ce57dd3c7","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"                \"hosts with Nova versions \u003e\u003d16 (Pike). Skipping \""},{"line_number":1232,"context_line":"                \"of auto-correction allocations. \")"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        LOG.debug(msg_allocation_refresh)"},{"line_number":1235,"context_line":"        for instance in instances:"},{"line_number":1236,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"},{"line_number":1237,"context_line":"                self._update_usage_from_instance(context, instance, nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c37d07b3","line":1234,"range":{"start_line":1234,"start_character":8,"end_line":1234,"end_character":41},"updated":"2018-06-19 16:12:59.000000000","message":"Why did you move this?  It looks like the purpose of the weird boolean+conditional was to ensure that the message was printed at most once - but not at all if all instances have vm_state in ALLOW_RESOURCE_REMOVAL.","commit_id":"62161bdb02aa80f4ea9021d0d7b1f0f7807263ab"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6be8b1d6d9004298e8288132b450a5f173f0272b","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"                \"hosts with Nova versions \u003e\u003d16 (Pike). Skipping \""},{"line_number":1232,"context_line":"                \"of auto-correction allocations. \")"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        LOG.debug(msg_allocation_refresh)"},{"line_number":1235,"context_line":"        for instance in instances:"},{"line_number":1236,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"},{"line_number":1237,"context_line":"                self._update_usage_from_instance(context, instance, nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_23db8d21","line":1234,"range":{"start_line":1234,"start_character":8,"end_line":1234,"end_character":41},"in_reply_to":"5f7c97a3_c37d07b3","updated":"2018-06-20 05:56:00.000000000","message":"um... yes, maybe I need keep the logic here","commit_id":"62161bdb02aa80f4ea9021d0d7b1f0f7807263ab"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ddf1b4055b10e4cd8d3f3493116aaf0afe985fe9","unresolved":false,"context_lines":[{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        for instance in instances:"},{"line_number":1235,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"},{"line_number":1236,"context_line":"                LOG.debug(msg_allocation_refresh)"},{"line_number":1237,"context_line":"                self._update_usage_from_instance(context, instance, nodename,"},{"line_number":1238,"context_line":"                    require_allocation_refresh\u003drequire_allocation_refresh)"},{"line_number":1239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_24006a00","line":1236,"range":{"start_line":1236,"start_character":16,"end_line":1236,"end_character":49},"updated":"2018-06-20 14:05:17.000000000","message":"This will now get logged once per instance.  I think you want to keep the original logic here, with the conditional and then setting msg_allocation_refresh to False.","commit_id":"7f869f9a393243a9c6b921c4b483931bae99daf3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"06cf6fa9ed32e3a8fd5ad4c2050d9a8ed67bfa3c","unresolved":false,"context_lines":[{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        for instance in instances:"},{"line_number":1235,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"},{"line_number":1236,"context_line":"                LOG.debug(msg_allocation_refresh)"},{"line_number":1237,"context_line":"                self._update_usage_from_instance(context, instance, nodename,"},{"line_number":1238,"context_line":"                    require_allocation_refresh\u003drequire_allocation_refresh)"},{"line_number":1239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b1ece2f4","line":1236,"range":{"start_line":1236,"start_character":16,"end_line":1236,"end_character":49},"in_reply_to":"5f7c97a3_24006a00","updated":"2018-07-18 03:12:39.000000000","message":"ok, will update","commit_id":"7f869f9a393243a9c6b921c4b483931bae99daf3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ea40bae9edfb1592aa72568bae26156603616ed7","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        cn.current_workload \u003d 0"},{"line_number":1157,"context_line":"        cn.running_vms \u003d 0"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        # NOTE(jaypipes): In Pike, we need to be tolerant of Ocata compute"},{"line_number":1160,"context_line":"        # nodes that overwrite placement allocations to look like what the"},{"line_number":1161,"context_line":"        # resource tracker *thinks* is correct. When an instance is"},{"line_number":1162,"context_line":"        # migrated from an Ocata compute node to a Pike compute node, the"},{"line_number":1163,"context_line":"        # Pike scheduler will have created a \"doubled-up\" allocation that"},{"line_number":1164,"context_line":"        # contains allocated resources against both the source and"},{"line_number":1165,"context_line":"        # destination hosts. The Ocata source compute host, during its"},{"line_number":1166,"context_line":"        # update_available_resource() periodic call will find the instance"},{"line_number":1167,"context_line":"        # in its list of known instances and will call"},{"line_number":1168,"context_line":"        # update_instance_allocation() in the report client. That call will"},{"line_number":1169,"context_line":"        # pull the allocations for the instance UUID which will contain"},{"line_number":1170,"context_line":"        # both the source and destination host providers in the allocation"},{"line_number":1171,"context_line":"        # set. Seeing that this is different from what the Ocata source"},{"line_number":1172,"context_line":"        # host thinks it should be and will overwrite the allocation to"},{"line_number":1173,"context_line":"        # only be an allocation against itself."},{"line_number":1174,"context_line":"        #"},{"line_number":1175,"context_line":"        # And therefore, here we need to have Pike compute hosts"},{"line_number":1176,"context_line":"        # \"correct\" the improper healing that the Ocata source host did"},{"line_number":1177,"context_line":"        # during its periodic interval. When the instance is fully migrated"},{"line_number":1178,"context_line":"        # to the Pike compute host, the Ocata compute host will find an"},{"line_number":1179,"context_line":"        # allocation that refers to itself for an instance it no longer"},{"line_number":1180,"context_line":"        # controls and will *delete* all allocations that refer to that"},{"line_number":1181,"context_line":"        # instance UUID, assuming that the instance has been deleted. We"},{"line_number":1182,"context_line":"        # need the destination Pike compute host to recreate that"},{"line_number":1183,"context_line":"        # allocation to refer to its own resource provider UUID."},{"line_number":1184,"context_line":"        #"},{"line_number":1185,"context_line":"        # For Pike compute nodes that migrate to either a Pike compute host"},{"line_number":1186,"context_line":"        # or a Queens compute host, we do NOT want the Pike compute host to"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_8c64db22","line":1183,"range":{"start_line":1159,"start_character":8,"end_line":1183,"end_character":64},"updated":"2018-07-18 01:16:56.000000000","message":"This is all still talking about Ocata.","commit_id":"9602c431f3f348f2e6ff15973cdf13ab2aead20c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d2b82aa62142501c5784de839e3615454b8ec244","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"                if msg_allocation_refresh:"},{"line_number":1226,"context_line":"                    LOG.debug(msg_allocation_refresh)"},{"line_number":1227,"context_line":"                    msg_allocation_refresh \u003d False"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"                self._update_usage_from_instance(context, instance, nodename,"},{"line_number":1230,"context_line":"                    require_allocation_refresh\u003drequire_allocation_refresh)"},{"line_number":1231,"context_line":"            instance_by_uuid[instance.uuid] \u003d instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f20d5ce7","line":1228,"updated":"2018-07-16 12:47:51.000000000","message":"unrelated","commit_id":"9602c431f3f348f2e6ff15973cdf13ab2aead20c"}]}