)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9dd4fba8db4917c161e5dfbb4b999aa4e489864","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            sign \u003d -1"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1129,"context_line":"        cn.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        # if it\u0027s a new or deleted instance:"},{"line_number":1132,"context_line":"        if is_new_instance or is_removed_instance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_79170456","line":1129,"range":{"start_line":1129,"start_character":8,"end_line":1129,"end_character":73},"updated":"2018-06-19 17:43:06.000000000","message":"Well, this isn\u0027t going to do quiiite the same thing.\n\nI think we can preserve the original effect while (hopefully) preserving the efficiency by running update_stats_for_instance on both copies here.","commit_id":"9fb6464a94a7435eeb33bc2282ad8fbe0ac661f4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bb787d03bb56a6c3abd78d3bb02114cd2fdd18ef","unresolved":false,"context_lines":[{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1129,"context_line":"        self.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1130,"context_line":"        cn.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        # if it\u0027s a new or deleted instance:"},{"line_number":1133,"context_line":"        if is_new_instance or is_removed_instance:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a3a0fd92","line":1130,"updated":"2018-06-20 05:53:10.000000000","message":"2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager Traceback (most recent call last):\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager   File \"/usr/lib/python2.7/dist-packages/nova/compute/manager.py\", line 7395, in update_available_resource_for_node\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager     rt.update_available_resource(context, nodename)\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager   File \"/usr/lib/python2.7/dist-packages/nova/compute/resource_tracker.py\", line 679, in update_available_resource\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager     self._update_available_resource(context, resources)\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager   File \"/usr/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py\", line 277, in inner\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager     return f(*args, **kwargs)\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager   File \"/usr/lib/python2.7/dist-packages/nova/compute/resource_tracker.py\", line 724, in _update_available_resource\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager     self._update_usage_from_instances(context, instances, nodename)\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager   File \"/usr/lib/python2.7/dist-packages/nova/compute/resource_tracker.py\", line 1233, in _update_usage_from_instances\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager     require_allocation_refresh\u003drequire_allocation_refresh)\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager   File \"/usr/lib/python2.7/dist-packages/nova/compute/resource_tracker.py\", line 1110, in _update_usage_from_instance\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager     cn.stats.update_stats_for_instance(instance, is_removed_instance)\n2018-06-20 05:52:01.195 17545 ERROR nova.compute.manager AttributeError: \u0027CoercedDict\u0027 object has no attribute \u0027update_stats_for_instance\u0027","commit_id":"cc42712985995d6b644392097246d28882755523"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"62e58c1c920e0fcdee9a0f686eea8993e06d0879","unresolved":false,"context_lines":[{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1129,"context_line":"        self.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1130,"context_line":"        cn.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        # if it\u0027s a new or deleted instance:"},{"line_number":1133,"context_line":"        if is_new_instance or is_removed_instance:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_bb59f88e","line":1130,"in_reply_to":"5f7c97a3_a3a0fd92","updated":"2018-06-20 15:54:46.000000000","message":"Weird","commit_id":"cc42712985995d6b644392097246d28882755523"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0f26de18fa78f6ce8e8cb08c28961fc0e459f5ef","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            sign \u003d -1"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1129,"context_line":"        self.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1130,"context_line":"        cn.stats \u003d self.stats"},{"line_number":1131,"context_line":"        cn.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1132,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_85a7490a","line":1129,"range":{"start_line":1129,"start_character":8,"end_line":1129,"end_character":75},"updated":"2018-06-28 20:33:24.000000000","message":"did you forget to remove this?","commit_id":"2e04b2e7ffeefd81ae76c2d79d6a2b6669793380"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cba9026bc2676da8a2d79ee74be41389511abdf2","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            sign \u003d -1"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1129,"context_line":"        self.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1130,"context_line":"        cn.stats \u003d self.stats"},{"line_number":1131,"context_line":"        cn.stats.update_stats_for_instance(instance, is_removed_instance)"},{"line_number":1132,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6568ed21","line":1129,"range":{"start_line":1129,"start_character":8,"end_line":1129,"end_character":75},"in_reply_to":"5f7c97a3_85a7490a","updated":"2018-06-28 21:02:40.000000000","message":"I tried that in PS1, though without including the line below.\n\nReally none of this makes sense to me, so I quit playing with it after the first couple of attempts did wildly not what I expected.\n\nBut I can try removing L1129 and leaving the rest in place, see if that sticks...","commit_id":"2e04b2e7ffeefd81ae76c2d79d6a2b6669793380"}]}