)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6a5f10663c4b4146d064d209c3144f5afeca0657","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     f965d6f3 (libvirt: use dest host vif migrate details for live migration)"},{"line_number":2,"context_line":"Author:     Matt Riedemann \u003cmriedem.os@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2018-06-19 19:33:25 -0400"},{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem.os@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_29d4c31e","line":1,"updated":"2018-06-20 13:43:32.000000000","message":"surely there\u0027s a bug for this","commit_id":"d591aa8014ff8dca8a362df4738d8a92b377791e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"46daeaa852f12bf8b8762b3455c2852f8b5249aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This uses the strutils.bool_from_string utility to convert"},{"line_number":23,"context_line":"strings (if there are strings) to booleans."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I53223da95da61440d0f9b1cd02bf9e8e5ccde818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_89cdd787","line":24,"updated":"2018-06-20 13:43:00.000000000","message":"No bug are associated. Don\u0027t you want to add one so we can backport this change? I understand that this issue just happened for this release but since we did not really discovered the root cause perhaps that would be safer, no?","commit_id":"d591aa8014ff8dca8a362df4738d8a92b377791e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21308c594c67c8d262ed20c561b74068affa6ea5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This uses the strutils.bool_from_string utility to convert"},{"line_number":23,"context_line":"strings (if there are strings) to booleans."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I53223da95da61440d0f9b1cd02bf9e8e5ccde818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_e1b3f698","line":24,"in_reply_to":"5f7c97a3_89cdd787","updated":"2018-06-25 12:44:14.000000000","message":"I don\u0027t plan on backporting this. If it turns out to be an issue on stable branches and someone reports a bug for it, we can backport using that bug at that time.","commit_id":"d591aa8014ff8dca8a362df4738d8a92b377791e"}],"nova/network/model.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6a5f10663c4b4146d064d209c3144f5afeca0657","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":461,"context_line":"        # Handle an ML2 mechanism driver passing the value as a string rather"},{"line_number":462,"context_line":"        # than a boolean."},{"line_number":463,"context_line":"        return strutils.bool_from_string("},{"line_number":464,"context_line":"            self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG), default\u003dFalse)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def is_neutron_filtering_enabled(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a9c8d374","line":463,"updated":"2018-06-20 13:43:32.000000000","message":"This will also evaluate strings like \"42\" as False, which is a turnaround from what was happening before.  Is that okay?  (I don\u0027t know what values these things can realistically have, but their names alone don\u0027t imply boolean-ness.)","commit_id":"d591aa8014ff8dca8a362df4738d8a92b377791e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21308c594c67c8d262ed20c561b74068affa6ea5","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":461,"context_line":"        # Handle an ML2 mechanism driver passing the value as a string rather"},{"line_number":462,"context_line":"        # than a boolean."},{"line_number":463,"context_line":"        return strutils.bool_from_string("},{"line_number":464,"context_line":"            self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG), default\u003dFalse)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def is_neutron_filtering_enabled(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e168d6f4","line":463,"in_reply_to":"5f7c97a3_a9c8d374","updated":"2018-06-25 12:44:14.000000000","message":"Well, we could pass strict\u003dTrue but then we lose the ability to pass a default.","commit_id":"d591aa8014ff8dca8a362df4738d8a92b377791e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23390a541b6d84ef4085ce94b183f5375c7aad96","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":461,"context_line":"        # Handle an ML2 mechanism driver passing the value as a string rather"},{"line_number":462,"context_line":"        # than a boolean."},{"line_number":463,"context_line":"        return strutils.bool_from_string("},{"line_number":464,"context_line":"            self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG), default\u003dFalse)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def is_neutron_filtering_enabled(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d6ca3d6c","line":463,"in_reply_to":"5f7c97a3_e168d6f4","updated":"2018-06-25 14:41:30.000000000","message":"You mean without another couple lines of code?\n\nI was genuinely asking the question, since I have no idea what the possibilities are.","commit_id":"d591aa8014ff8dca8a362df4738d8a92b377791e"}]}