)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0846c92043204ca0a8ba263dec5cb5b2dba3d75e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename auth_uri to www_authenticate_uri"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated \u0027auth_uri\u0027 to bring \u0027www_authenticate_uri\u0027,"},{"line_number":10,"context_line":"so \u0027auth_uri\u0027 should be removed from all openstack projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":13,"context_line":"Related-Bug: https://storyboard-dev.openstack.org/#!/story/1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_9553b26c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":60},"updated":"2018-06-20 10:58:34.000000000","message":"Got a link to the release note where this changed?","commit_id":"380416b6c590891dc9867d754a1a466391e0e114"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0846c92043204ca0a8ba263dec5cb5b2dba3d75e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"so \u0027auth_uri\u0027 should be removed from all openstack projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":13,"context_line":"Related-Bug: https://storyboard-dev.openstack.org/#!/story/1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_3563be43","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":66},"updated":"2018-06-20 10:58:34.000000000","message":"This isn\u0027t a valid link. Could you link to the main instance or use Launchpad? https://bugs.launchpad.net/keystonemiddleware/+bug/1755728","commit_id":"380416b6c590891dc9867d754a1a466391e0e114"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e05a859dad91ac8cdb8582f52cf245817b940932","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated \u0027auth_uri\u0027 to bring \u0027www_authenticate_uri\u0027 in"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/508522/, so \u0027auth_uri\u0027"},{"line_number":11,"context_line":"should be removed from all openstack projects. And it should be"},{"line_number":12,"context_line":"\u0027auth_url\u0027 rather than \u0027www_authenticate_uri\u0027 in api/client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":15,"context_line":"Related-Bug: 1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_ea584158","line":12,"range":{"start_line":11,"start_character":47,"end_line":12,"end_character":60},"updated":"2018-06-29 06:54:39.000000000","message":"I could not fine the reason of this part.\nCould you put the reason why we need to change to auth_url in the client?","commit_id":"b533a4109350aaa5c41eed78f7c7e76a1777de71"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e6b12ae6c8c1d1367ba98c0ba5b2f089a1f892d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated \u0027auth_uri\u0027 to bring \u0027www_authenticate_uri\u0027 in"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/508522/, so \u0027auth_uri\u0027"},{"line_number":11,"context_line":"should be removed from all openstack projects. And it should be"},{"line_number":12,"context_line":"\u0027auth_url\u0027 rather than \u0027www_authenticate_uri\u0027 in api/client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":15,"context_line":"Related-Bug: 1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_e0aa7ed1","line":12,"range":{"start_line":11,"start_character":47,"end_line":12,"end_character":60},"in_reply_to":"5f7c97a3_7a1ab6c6","updated":"2018-07-02 09:07:48.000000000","message":"It would still be good for the commit message to explain the reasoning for the auth_uri-\u003eauth_url switch for the sake of historical context.","commit_id":"b533a4109350aaa5c41eed78f7c7e76a1777de71"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ad7c8990b9d7c55af74e0aafd496d2089a5a3831","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated \u0027auth_uri\u0027 to bring \u0027www_authenticate_uri\u0027 in"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/508522/, so \u0027auth_uri\u0027"},{"line_number":11,"context_line":"should be removed from all openstack projects. And it should be"},{"line_number":12,"context_line":"\u0027auth_url\u0027 rather than \u0027www_authenticate_uri\u0027 in api/client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":15,"context_line":"Related-Bug: 1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_7a1ab6c6","line":12,"range":{"start_line":11,"start_character":47,"end_line":12,"end_character":60},"in_reply_to":"5f7c97a3_ad4823b3","updated":"2018-06-29 16:04:33.000000000","message":"Ken\u0027ichi, the referenced patch explains why \u0027auth_uri\u0027 was changed to \u0027www_authenticate_uri\u0027 - it was exactly because they were always getting confused, which had obviously happened in this case.  So we\u0027re changing it to be consistent with how it\u0027s being used, and basically to avoid the token \u0027auth_uri\u0027 existing anywhere.  See also the discussions in PS3 [1][2].\n\n[1] https://review.openstack.org/#/c/576820/3/nova/tests/fixtures.py@879\n[2] https://review.openstack.org/#/c/576820/3/nova/tests/functional/api/client.py@127","commit_id":"b533a4109350aaa5c41eed78f7c7e76a1777de71"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9ee3627a33a9826f591476a3a192cc0ecac071c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated \u0027auth_uri\u0027 to bring \u0027www_authenticate_uri\u0027 in"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/508522/, so \u0027auth_uri\u0027"},{"line_number":11,"context_line":"should be removed from all openstack projects. And it should be"},{"line_number":12,"context_line":"\u0027auth_url\u0027 rather than \u0027www_authenticate_uri\u0027 in api/client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":15,"context_line":"Related-Bug: 1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_2a45359b","line":12,"range":{"start_line":11,"start_character":47,"end_line":12,"end_character":60},"in_reply_to":"5f7c97a3_e0aa7ed1","updated":"2018-07-09 10:29:52.000000000","message":"when starting the review by reading this line, i was confused till i read the discussion to understand the auth_url and www_authenticate_uri usage. \n\ngood to explain the difference here, for history as well as for education also.\n\nThese kind of patches need long long commit message to explain and market such global change :)","commit_id":"b533a4109350aaa5c41eed78f7c7e76a1777de71"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"626a6db368a7673e8d289510eb8c3f11edb165e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated \u0027auth_uri\u0027 to bring \u0027www_authenticate_uri\u0027 in"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/508522/, so \u0027auth_uri\u0027"},{"line_number":11,"context_line":"should be removed from all openstack projects. And it should be"},{"line_number":12,"context_line":"\u0027auth_url\u0027 rather than \u0027www_authenticate_uri\u0027 in api/client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7f878974fe8bebb8fe5803ca4e2f8839cdc971d0"},{"line_number":15,"context_line":"Related-Bug: 1755728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_ad4823b3","line":12,"range":{"start_line":11,"start_character":47,"end_line":12,"end_character":60},"in_reply_to":"5f7c97a3_ea584158","updated":"2018-06-29 07:38:42.000000000","message":"Because it should be the same here and in the fixture.py [1]\n[1]https://github.com/openstack/nova/blob/46ef5738ad9a5db342be04081ce31f8ac7ad6cca/nova/tests/fixtures.py#L880\nWe choose to change here and keep fixture unchange after discussion.","commit_id":"b533a4109350aaa5c41eed78f7c7e76a1777de71"}],"nova/tests/fixtures.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c999c027fc1b1bb6cefa7c7188c19d91c60e179f","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        intercept.install_intercept()"},{"line_number":872,"context_line":"        self.addCleanup(intercept.uninstall_intercept)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        self.auth_url \u003d \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 % ({"},{"line_number":875,"context_line":"            \u0027host\u0027: hostname, \u0027port\u0027: port, \u0027api_version\u0027: self.api_version})"},{"line_number":876,"context_line":"        self.api \u003d client.TestOpenStackClient(\u0027fake\u0027, \u0027fake\u0027, self.auth_url,"},{"line_number":877,"context_line":"                                              self.project_id)"},{"line_number":878,"context_line":"        self.admin_api \u003d client.TestOpenStackClient("},{"line_number":879,"context_line":"            \u0027admin\u0027, \u0027admin\u0027, self.auth_url, self.project_id)"},{"line_number":880,"context_line":"        # Provide a way to access the wsgi application to tests using"},{"line_number":881,"context_line":"        # the fixture."},{"line_number":882,"context_line":"        self.app \u003d app"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_485ea6e9","line":879,"range":{"start_line":874,"start_character":0,"end_line":879,"end_character":61},"updated":"2018-06-22 16:04:25.000000000","message":"Is this supposed to be auth_url or www_authenticate_uri?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1873a0adc430f3bba240803b751e06b8129912b8","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        intercept.install_intercept()"},{"line_number":872,"context_line":"        self.addCleanup(intercept.uninstall_intercept)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        self.auth_url \u003d \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 % ({"},{"line_number":875,"context_line":"            \u0027host\u0027: hostname, \u0027port\u0027: port, \u0027api_version\u0027: self.api_version})"},{"line_number":876,"context_line":"        self.api \u003d client.TestOpenStackClient(\u0027fake\u0027, \u0027fake\u0027, self.auth_url,"},{"line_number":877,"context_line":"                                              self.project_id)"},{"line_number":878,"context_line":"        self.admin_api \u003d client.TestOpenStackClient("},{"line_number":879,"context_line":"            \u0027admin\u0027, \u0027admin\u0027, self.auth_url, self.project_id)"},{"line_number":880,"context_line":"        # Provide a way to access the wsgi application to tests using"},{"line_number":881,"context_line":"        # the fixture."},{"line_number":882,"context_line":"        self.app \u003d app"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ceb04cdf","line":879,"range":{"start_line":874,"start_character":0,"end_line":879,"end_character":61},"in_reply_to":"5f7c97a3_10e2ec30","updated":"2018-06-26 10:44:41.000000000","message":"I\u0027m going to call in the cavalry here.\n\nColleen/Lance, I don\u0027t have the background on auth_url/auth_uri/www_authenticate_uri - can y\u0027all tell by looking which one this is supposed to be?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"a445ff8eec7cf35fcdca5518c1c4f8be29696476","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        intercept.install_intercept()"},{"line_number":872,"context_line":"        self.addCleanup(intercept.uninstall_intercept)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        self.auth_url \u003d \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 % ({"},{"line_number":875,"context_line":"            \u0027host\u0027: hostname, \u0027port\u0027: port, \u0027api_version\u0027: self.api_version})"},{"line_number":876,"context_line":"        self.api \u003d client.TestOpenStackClient(\u0027fake\u0027, \u0027fake\u0027, self.auth_url,"},{"line_number":877,"context_line":"                                              self.project_id)"},{"line_number":878,"context_line":"        self.admin_api \u003d client.TestOpenStackClient("},{"line_number":879,"context_line":"            \u0027admin\u0027, \u0027admin\u0027, self.auth_url, self.project_id)"},{"line_number":880,"context_line":"        # Provide a way to access the wsgi application to tests using"},{"line_number":881,"context_line":"        # the fixture."},{"line_number":882,"context_line":"        self.app \u003d app"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6dea7da0","line":879,"range":{"start_line":874,"start_character":0,"end_line":879,"end_character":61},"in_reply_to":"5f7c97a3_485ea6e9","updated":"2018-06-25 09:32:23.000000000","message":"It should be auth_url.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"37399a7b823da527ac0b8b5f74fa7d89fe38bc0d","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        intercept.install_intercept()"},{"line_number":872,"context_line":"        self.addCleanup(intercept.uninstall_intercept)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        self.auth_url \u003d \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 % ({"},{"line_number":875,"context_line":"            \u0027host\u0027: hostname, \u0027port\u0027: port, \u0027api_version\u0027: self.api_version})"},{"line_number":876,"context_line":"        self.api \u003d client.TestOpenStackClient(\u0027fake\u0027, \u0027fake\u0027, self.auth_url,"},{"line_number":877,"context_line":"                                              self.project_id)"},{"line_number":878,"context_line":"        self.admin_api \u003d client.TestOpenStackClient("},{"line_number":879,"context_line":"            \u0027admin\u0027, \u0027admin\u0027, self.auth_url, self.project_id)"},{"line_number":880,"context_line":"        # Provide a way to access the wsgi application to tests using"},{"line_number":881,"context_line":"        # the fixture."},{"line_number":882,"context_line":"        self.app \u003d app"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_10e2ec30","line":879,"range":{"start_line":874,"start_character":0,"end_line":879,"end_character":61},"in_reply_to":"5f7c97a3_67a85677","updated":"2018-06-26 03:59:27.000000000","message":"In fact, I think the www_authenticate_uri include the auth_url and auth_url just is a special case of www_authenticate_uri.\nBecause \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 is standard url format, so there could use auth_url. Of course, it just is my private opinions. Maybe we could change it to www_authenticate_uri for keeping the variables consistent.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"19f0696baf1c6fed41df1410888ed446e66de9a0","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        intercept.install_intercept()"},{"line_number":872,"context_line":"        self.addCleanup(intercept.uninstall_intercept)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        self.auth_url \u003d \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 % ({"},{"line_number":875,"context_line":"            \u0027host\u0027: hostname, \u0027port\u0027: port, \u0027api_version\u0027: self.api_version})"},{"line_number":876,"context_line":"        self.api \u003d client.TestOpenStackClient(\u0027fake\u0027, \u0027fake\u0027, self.auth_url,"},{"line_number":877,"context_line":"                                              self.project_id)"},{"line_number":878,"context_line":"        self.admin_api \u003d client.TestOpenStackClient("},{"line_number":879,"context_line":"            \u0027admin\u0027, \u0027admin\u0027, self.auth_url, self.project_id)"},{"line_number":880,"context_line":"        # Provide a way to access the wsgi application to tests using"},{"line_number":881,"context_line":"        # the fixture."},{"line_number":882,"context_line":"        self.app \u003d app"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_67a85677","line":879,"range":{"start_line":874,"start_character":0,"end_line":879,"end_character":61},"in_reply_to":"5f7c97a3_6dea7da0","updated":"2018-06-25 13:45:28.000000000","message":"But you renamed the parameter in TestOpenStackClient.__init__ to www_authenticate_uri - so why the discrepancy?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c7f05c683b2592aaa3c7b87a2c6be3222a8d8f5a","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        intercept.install_intercept()"},{"line_number":872,"context_line":"        self.addCleanup(intercept.uninstall_intercept)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        self.auth_url \u003d \u0027http://%(host)s:%(port)s/%(api_version)s\u0027 % ({"},{"line_number":875,"context_line":"            \u0027host\u0027: hostname, \u0027port\u0027: port, \u0027api_version\u0027: self.api_version})"},{"line_number":876,"context_line":"        self.api \u003d client.TestOpenStackClient(\u0027fake\u0027, \u0027fake\u0027, self.auth_url,"},{"line_number":877,"context_line":"                                              self.project_id)"},{"line_number":878,"context_line":"        self.admin_api \u003d client.TestOpenStackClient("},{"line_number":879,"context_line":"            \u0027admin\u0027, \u0027admin\u0027, self.auth_url, self.project_id)"},{"line_number":880,"context_line":"        # Provide a way to access the wsgi application to tests using"},{"line_number":881,"context_line":"        # the fixture."},{"line_number":882,"context_line":"        self.app \u003d app"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a8684c87","line":879,"range":{"start_line":874,"start_character":0,"end_line":879,"end_character":61},"in_reply_to":"5f7c97a3_ceb04cdf","updated":"2018-06-27 09:04:24.000000000","message":"When used in the [keystone_authtoken] section of a config file, auth_url is the parameter passed to the keystoneauth plugin. It\u0027s what the nova service user uses to talk to keystone directly. auth_uri is the parameter specific to keystonemiddleware, it\u0027s what the middleware returns to the end user when it figures out that the end user hasn\u0027t authenticated yet. That was obviously confusing so we renamed auth_uri to www_authenticate_uri since it\u0027s populating the WWW-Authenticate header.\n\nI\u0027m a little unclear on what this fixture is for, but the object client.TestOpenStackClient seems like it\u0027s setting up an end-user client, in which case auth_url would be appropriate since that\u0027s going to be passed straight to keystoneauth.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"}],"nova/tests/functional/api/client.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"efefa92c7b78586c7c54d4b399d9a5990fcababd","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                                headers\u003dheaders)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        http_status \u003d response.status_code"},{"line_number":159,"context_line":"        LOG.debug(\"%()s \u003d\u003e code %(http_status)s\","},{"line_number":160,"context_line":"                  {\u0027www_authenticate_uri\u0027: www_authenticate_uri,"},{"line_number":161,"context_line":"                   \u0027http_status\u0027: http_status})"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1151df0e","line":159,"range":{"start_line":159,"start_character":19,"end_line":159,"end_character":23},"updated":"2018-06-21 08:35:25.000000000","message":"wrong format\n\n%(www_authenticate_uri)","commit_id":"3faae341068983b37ec1cb160e3ec7ce3625a73c"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"3e69d1395e3928468bd39fc03092de092639669a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                                headers\u003dheaders)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        http_status \u003d response.status_code"},{"line_number":159,"context_line":"        LOG.debug(\"%()s \u003d\u003e code %(http_status)s\","},{"line_number":160,"context_line":"                  {\u0027www_authenticate_uri\u0027: www_authenticate_uri,"},{"line_number":161,"context_line":"                   \u0027http_status\u0027: http_status})"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_52409e06","line":159,"range":{"start_line":159,"start_character":19,"end_line":159,"end_character":23},"in_reply_to":"5f7c97a3_1151df0e","updated":"2018-06-22 10:33:36.000000000","message":"Done","commit_id":"3faae341068983b37ec1cb160e3ec7ce3625a73c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c999c027fc1b1bb6cefa7c7188c19d91c60e179f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_28b56aed","line":127,"updated":"2018-06-22 16:04:25.000000000","message":"Based on how this is being used [1], it\u0027s not clear to me whether this is actually supposed to be the auth_url or the www_authenticate_uri.\n\nIn any case, correct me if I\u0027m wrong, but the changes in this file are purely variable renames - no functional change to conf or headers or anything.\n\n[1] https://review.openstack.org/#/c/576820/3/nova/tests/fixtures.py@879","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"a445ff8eec7cf35fcdca5518c1c4f8be29696476","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_cde5d1a5","line":127,"in_reply_to":"5f7c97a3_28b56aed","updated":"2018-06-25 09:32:23.000000000","message":"Yes, you are right, it just variable renames. I just want to prevent people from confusing auth_url and www_authenticate_uri when people look at this code. If you think it is unnecessary, I will remove the change.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f27965412f339d906f56b7ce0436fc021a27c5ce","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4a14ff4d","line":127,"in_reply_to":"5f7c97a3_2d58c6f6","updated":"2018-06-27 18:42:16.000000000","message":"Yeah I think I would agree with that. If this is supposed to represent a client rather than a wsgi service then using auth_url would make a little more sense here.\n\nOn the other hand, it looks like this is just using straight up requests rather than keystoneauth so you could really call it whatever you want. Maybe keystone_url would be a little less overloaded?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"ed16bfe93d27d06461d0db5123a41abb31564e2b","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4ccc0c62","line":127,"in_reply_to":"5f7c97a3_2d8198a1","updated":"2018-06-28 10:19:23.000000000","message":"Thanks for Eric and Colleen, so we both agree to change it to auth_url here, right?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8324b0d5380481b3bd2e8ec45129b8ce6ab1171","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2d8198a1","line":127,"in_reply_to":"5f7c97a3_4a14ff4d","updated":"2018-06-27 23:43:04.000000000","message":"Either would work for me.  The main thing you\u0027ve helped conclude is that it should *not* be called auth_uri *or* www_authenticate_uri.\n\nWhatever we call it, it should be the same here and in the fixture.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a95bd3977f0df719101e6d2f806aa151f8985138","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d128b186","line":127,"in_reply_to":"5f7c97a3_4ccc0c62","updated":"2018-06-28 14:30:12.000000000","message":"That would be fine, yes.  Then the fixture can go unchanged.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1afa7766fa9ff785ab47909bdbe51a443fc1b2ae","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2d58c6f6","line":127,"in_reply_to":"5f7c97a3_6773764f","updated":"2018-06-27 13:58:53.000000000","message":"Thanks Colleen.  I agree by looking at this that it appears to be the \"talking to keystone\" thing rather than the \"setting a header\" thing.  Which would mean the changes in this file should have been s/auth_uri/auth_url/g rather than s/auth_uri/www_authenticate_uri/g.  Agree?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"19f0696baf1c6fed41df1410888ed446e66de9a0","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6773764f","line":127,"in_reply_to":"5f7c97a3_cde5d1a5","updated":"2018-06-25 13:45:28.000000000","message":"No, I think it\u0027s fine to rename the variables; I just wanted to make sure we both understood that that part of the change is purely visual, not functional.","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"415e0684f0f7c49f41af5ddc62cda04e9e9a798c","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __init__(self, auth_user, auth_key, www_authenticate_uri,"},{"line_number":128,"context_line":"                 project_id\u003dNone):"},{"line_number":129,"context_line":"        super(TestOpenStackClient, self).__init__()"},{"line_number":130,"context_line":"        self.auth_result \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_71518f63","line":127,"in_reply_to":"5f7c97a3_d128b186","updated":"2018-06-29 01:59:09.000000000","message":"Done","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"}],"nova/tests/unit/api/openstack/placement/test_deploy.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c999c027fc1b1bb6cefa7c7188c19d91c60e179f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        the keystone middleware correctly."},{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        www_authenticate_uri \u003d \u0027http://example.com/identity\u0027"},{"line_number":33,"context_line":"        CONF.set_override(\u0027www_authenticate_uri\u0027, www_authenticate_uri,"},{"line_number":34,"context_line":"                          group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":35,"context_line":"        # ensure that the auth_token middleware is chosen"},{"line_number":36,"context_line":"        CONF.set_override(\u0027auth_strategy\u0027, \u0027keystone\u0027, group\u003d\u0027api\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a8c09a4b","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":48},"updated":"2018-06-22 16:04:25.000000000","message":"This appears to be the only functional change in the patch.  The rest is just variable/parameter renames.  Right?","commit_id":"363a69b4fff0a9fc825313bf124ec987a8e840b5"}]}