)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3f2723127e0e8c2e4fbb1615230765bc399e6900","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    if fields.ResourceClass.PCPU in inv_data:"},{"line_number":110,"context_line":"        cpu_inv \u003d inv_data[fields.ResourceClass.PCPU]"},{"line_number":111,"context_line":"        if \u0027allocation_ratio\u0027 not in cpu_inv:"},{"line_number":112,"context_line":"            cpu_inv[\u0027allocation_ratio\u0027] \u003d 1"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    if fields.ResourceClass.MEMORY_MB in inv_data:"},{"line_number":115,"context_line":"        mem_inv \u003d inv_data[fields.ResourceClass.MEMORY_MB]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_59341efb","line":112,"updated":"2018-06-25 15:49:21.000000000","message":"The other clauses in here set the `reserved` value based on a conf option.  Can you explain why this one is different?","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"85ddc7c8b3058c67ae4d88f2068d37a6ba38bda3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    if fields.ResourceClass.PCPU in inv_data:"},{"line_number":110,"context_line":"        cpu_inv \u003d inv_data[fields.ResourceClass.PCPU]"},{"line_number":111,"context_line":"        if \u0027allocation_ratio\u0027 not in cpu_inv:"},{"line_number":112,"context_line":"            cpu_inv[\u0027allocation_ratio\u0027] \u003d 1"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    if fields.ResourceClass.MEMORY_MB in inv_data:"},{"line_number":115,"context_line":"        mem_inv \u003d inv_data[fields.ResourceClass.MEMORY_MB]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_cac60117","line":112,"in_reply_to":"5f7c97a3_59341efb","updated":"2018-06-26 02:14:06.000000000","message":"This is under discussion on the Spec: https://review.openstack.org/#/c/555081/15/specs/rocky/approved/cpu-resources.rst@224\n\nWill fix it after consensus.","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"9f56b92b310ef3cea551c79cbc9bcdcffbe1b06f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    if fields.ResourceClass.PCPU in inv_data:"},{"line_number":110,"context_line":"        cpu_inv \u003d inv_data[fields.ResourceClass.PCPU]"},{"line_number":111,"context_line":"        if \u0027allocation_ratio\u0027 not in cpu_inv:"},{"line_number":112,"context_line":"            cpu_inv[\u0027allocation_ratio\u0027] \u003d 1"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    if fields.ResourceClass.MEMORY_MB in inv_data:"},{"line_number":115,"context_line":"        mem_inv \u003d inv_data[fields.ResourceClass.MEMORY_MB]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_980fc38a","line":112,"in_reply_to":"5f7c97a3_cac60117","updated":"2018-06-28 09:34:07.000000000","message":"Hi Eric,\nThis will be fixed in next PS.","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3f2723127e0e8c2e4fbb1615230765bc399e6900","unresolved":false,"context_lines":[{"line_number":15005,"context_line":"                if key not in [\u0027phys_function\u0027, \u0027virt_functions\u0027, \u0027label\u0027]:"},{"line_number":15006,"context_line":"                    self.assertEqual(expectvfs[dev][key], actualvfs[dev][key])"},{"line_number":15007,"context_line":""},{"line_number":15008,"context_line":"    def _test_get_host_numa_topology(self, mempages, new_numa_cell\u003dFalse):"},{"line_number":15009,"context_line":"        caps \u003d vconfig.LibvirtConfigCaps()"},{"line_number":15010,"context_line":"        caps.host \u003d vconfig.LibvirtConfigCapsHost()"},{"line_number":15011,"context_line":"        caps.host.cpu \u003d vconfig.LibvirtConfigCPU()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ec6be6b5","line":15008,"range":{"start_line":15008,"start_character":53,"end_line":15008,"end_character":72},"updated":"2018-06-25 15:49:21.000000000","message":"With the size of the if/else this is producing, they should just be separate methods.  If you really wanted to, you could factor out these first ten lines into a common helper.","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"85ddc7c8b3058c67ae4d88f2068d37a6ba38bda3","unresolved":false,"context_lines":[{"line_number":15005,"context_line":"                if key not in [\u0027phys_function\u0027, \u0027virt_functions\u0027, \u0027label\u0027]:"},{"line_number":15006,"context_line":"                    self.assertEqual(expectvfs[dev][key], actualvfs[dev][key])"},{"line_number":15007,"context_line":""},{"line_number":15008,"context_line":"    def _test_get_host_numa_topology(self, mempages, new_numa_cell\u003dFalse):"},{"line_number":15009,"context_line":"        caps \u003d vconfig.LibvirtConfigCaps()"},{"line_number":15010,"context_line":"        caps.host \u003d vconfig.LibvirtConfigCapsHost()"},{"line_number":15011,"context_line":"        caps.host.cpu \u003d vconfig.LibvirtConfigCPU()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_eac97d24","line":15008,"range":{"start_line":15008,"start_character":53,"end_line":15008,"end_character":72},"in_reply_to":"5f7c97a3_ec6be6b5","updated":"2018-06-26 02:14:06.000000000","message":"Will fix this in next PS.","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"}],"nova/virt/hardware.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3f2723127e0e8c2e4fbb1615230765bc399e6900","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# TODO(Dinesh_Bhor) Remove this method once we deprecate and remove"},{"line_number":90,"context_line":"# CONF.vcpu_pin_set"},{"line_number":91,"context_line":"def does_compute_supports_shared_and_dedicated_cpus(context):"},{"line_number":92,"context_line":"    \"\"\"Determines whether this compute host supports new config options to"},{"line_number":93,"context_line":"    configure VCPU and PCPU or the old one i.e CONF.vcpu_pin_set."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b6681821","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":25},"updated":"2018-06-25 15:49:21.000000000","message":"support","commit_id":"ceb5d17f920e7651adc0097edf2ac8b9370aeae9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3f2723127e0e8c2e4fbb1615230765bc399e6900","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# TODO(Dinesh_Bhor) Remove this method once we deprecate and remove"},{"line_number":90,"context_line":"# CONF.vcpu_pin_set"},{"line_number":91,"context_line":"def does_compute_supports_shared_and_dedicated_cpus(context):"},{"line_number":92,"context_line":"    \"\"\"Determines whether the compute host supports new config options."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    :param context: admin user context"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_cca94add","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":25},"updated":"2018-06-25 15:49:21.000000000","message":"support","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"85ddc7c8b3058c67ae4d88f2068d37a6ba38bda3","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# TODO(Dinesh_Bhor) Remove this method once we deprecate and remove"},{"line_number":90,"context_line":"# CONF.vcpu_pin_set"},{"line_number":91,"context_line":"def does_compute_supports_shared_and_dedicated_cpus(context):"},{"line_number":92,"context_line":"    \"\"\"Determines whether the compute host supports new config options."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    :param context: admin user context"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8acc8934","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":25},"in_reply_to":"5f7c97a3_cca94add","updated":"2018-06-26 02:14:06.000000000","message":"Will fix this in next PS.","commit_id":"7b3bc894d151620e21ef3743ec1080851cf07294"}]}