)]}'
{"id":"openstack%2Fnova~57708","triplet_id":"openstack%2Fnova~master~I4a18bf023a64d0cb198f77aab9daecb0786e93ff","project":"openstack/nova","branch":"master","topic":"bug/1253599","hashtags":[],"change_id":"I4a18bf023a64d0cb198f77aab9daecb0786e93ff","subject":"Correct host managers free disk calculation","status":"MERGED","created":"2013-11-21 16:03:11.000000000","updated":"2014-02-13 12:10:25.000000000","submitted":"2014-02-13 12:10:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f3cc5d0e54f4315a7295f49e4f0daa18bf1417e0","_number":57708,"virtual_id_number":57708,"owner":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2014-02-13 12:10:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":1,"date":"2014-01-24 12:31:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":1,"date":"2014-01-25 01:51:12.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},{"value":0,"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},{"value":0,"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},{"value":0,"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"all":[{"value":2,"date":"2014-01-24 17:48:18.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-02-04 22:36:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"date":"2014-01-25 01:51:12.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2014-02-13 09:40:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},{"value":0,"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},{"value":0,"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},{"value":0,"date":"2014-01-24 13:22:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},{"value":1,"date":"2014-01-24 15:55:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":2,"date":"2014-02-13 10:48:44.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"all":[{"value":0,"date":"2014-01-24 16:14:46.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},{"value":0,"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},{"value":0,"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},{"value":0,"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":1,"date":"2014-02-13 10:48:44.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},{"value":0,"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},{"value":0,"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},{"value":0,"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},{"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-07 17:20:46.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-12-20 16:29:28.000000000","updated_by":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"reviewer":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"state":"REVIEWER"},{"updated":"2013-12-30 01:21:21.000000000","updated_by":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"reviewer":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"state":"REVIEWER"},{"updated":"2013-12-30 03:35:04.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2014-01-24 12:31:03.000000000","updated_by":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-01-24 15:55:40.000000000","updated_by":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"reviewer":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"state":"REVIEWER"},{"updated":"2014-01-24 16:14:46.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2014-01-25 01:51:12.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-02-04 22:36:47.000000000","updated_by":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"reviewer":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"state":"REVIEWER"},{"updated":"2014-02-13 09:40:13.000000000","updated_by":{"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},"reviewer":{"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},"state":"REVIEWER"},{"updated":"2014-02-13 10:48:44.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2014-02-13 12:10:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4988bf9f184d9f9c1a3114dfe1b66a3d5b64a00c","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2013-11-21 16:06:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5c976ec6b97bf0a00ece61bdbd950176fb393306","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-21 17:49:18.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/08/57708/2/check/gate-nova-pep8/8f475b3 : SUCCESS in 8m 31s\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/2/check/gate-nova-docs/b7bb7e5/doc/build/html/ : SUCCESS in 7m 52s\n- gate-nova-python26 http://logs.openstack.org/08/57708/2/check/gate-nova-python26/6944c92 : SUCCESS in 28m 25s\n- gate-nova-python27 http://logs.openstack.org/08/57708/2/check/gate-nova-python27/b088ef7 : SUCCESS in 23m 47s\n- check-tempest-devstack-vm-full http://logs.openstack.org/08/57708/2/check/check-tempest-devstack-vm-full/f703ce3 : SUCCESS in 1h 16m 03s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/08/57708/2/check/check-tempest-devstack-vm-postgres-full/4cfedd6 : SUCCESS in 1h 15m 32s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/08/57708/2/check/check-tempest-devstack-vm-neutron/5a9a87f : SUCCESS in 1h 21m 09s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/08/57708/2/check/gate-tempest-devstack-vm-large-ops/9b6ef62 : SUCCESS in 41m 30s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/08/57708/2/check/gate-tempest-devstack-vm-neutron-large-ops/dccb752 : SUCCESS in 45m 02s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/08/57708/2/check/check-grenade-devstack-vm/d0e7f52 : FAILURE in 1h 00m 48s\n- gate-devstack-vm-cells http://logs.openstack.org/08/57708/2/check/gate-devstack-vm-cells/8b28db9 : SUCCESS in 37m 53s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/08/57708/2/check/gate-nova-pylint/ae1a296 : SUCCESS in 18m 32s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"2b71354c6bea530d39ca97c07db609d9db7e3744","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2013-11-22 09:06:49.000000000","message":"Patch Set 2:\n\nRecheck bug 1240175","accounts_in_message":[],"_revision_number":2},{"id":"c4055384e069eced99aa1781e402d2815013053b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 09:49:36.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/08/57708/2/check/gate-nova-pep8/3c53ac1 : SUCCESS in 3m 47s\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/2/check/gate-nova-docs/69f3030/doc/build/html/ : SUCCESS in 3m 24s\n- gate-nova-python26 http://logs.openstack.org/08/57708/2/check/gate-nova-python26/5aef221 : SUCCESS in 22m 17s\n- gate-nova-python27 http://logs.openstack.org/08/57708/2/check/gate-nova-python27/1b2796b : SUCCESS in 18m 08s\n- check-tempest-devstack-vm-full http://logs.openstack.org/08/57708/2/check/check-tempest-devstack-vm-full/96fa65c : SUCCESS in 29m 33s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/08/57708/2/check/check-tempest-devstack-vm-postgres-full/7e30427 : SUCCESS in 32m 24s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/08/57708/2/check/check-tempest-devstack-vm-neutron/d337156 : SUCCESS in 29m 28s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/08/57708/2/check/gate-tempest-devstack-vm-large-ops/135507b : SUCCESS in 18m 11s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/08/57708/2/check/gate-tempest-devstack-vm-neutron-large-ops/19c73d0 : SUCCESS in 16m 32s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/08/57708/2/check/check-grenade-devstack-vm/a0dde98 : SUCCESS in 26m 33s\n- gate-devstack-vm-cells http://logs.openstack.org/08/57708/2/check/gate-devstack-vm-cells/39744ae : SUCCESS in 10m 02s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/08/57708/2/check/gate-nova-pylint/5e80750 : SUCCESS in 14m 01s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"3a3d039461ae54b7b24c804012299fefa32e918c","author":{"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},"date":"2013-12-03 09:54:43.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"4fdbb10268d24a880d4d02168a17a929a449180d","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2013-12-06 21:15:11.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"e1266e098e2cf99ad0ced1a021c63a817855f33a","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-12-07 17:20:46.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"44101e071d66527073e21260ab1ca157632146ed","author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"date":"2013-12-12 17:54:29.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"70de0685575058080ba69f68b9f4fe0e7c6d9371","author":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"date":"2013-12-20 16:29:28.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"aa94c38304d3bfb8ec2041e4af22e65d84999658","author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"date":"2013-12-30 01:21:21.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1cabbf58c47c421a90cd52351d6092581cd3008c","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2013-12-30 03:35:04.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a195250d48443d4d3948038c64be210351708313","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-12-30 16:22:23.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nI would rather see effort going into fixing a root cause than papering over the issue.  But at the very least let\u0027s not silently paper over it.","accounts_in_message":[],"_revision_number":2},{"id":"92225ca21666ee62bf6648b318402a5a637411b0","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-07 06:03:11.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"803a006a8b109fb9223ceee9cd06d52206b8b1b6","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-07 06:03:11.000000000","message":"Patch Set 2:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"a152b833a243e4b061a8ff6a2fffaa79f015ce2f","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2014-01-21 06:54:47.000000000","message":"Patch Set 2: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"858db77f9f1b3b8b4ca8927fc0b62c9cfe16c823","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2014-01-21 06:54:53.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"86693965a43d7ffad6912382f81325b4dc9e3976","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2014-01-21 09:01:48.000000000","message":"Patch Set 2: Restored","accounts_in_message":[],"_revision_number":2},{"id":"374e929ee48cef21bed0970a97fd26e79bfbaa98","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-01-21 09:20:13.000000000","message":"Patch Set 2: Works for me\n\nDatabase migration testing successful.\n\n- gate-real-db-upgrade_nova_mysql_devstack_131007 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_mysql_devstack_131007/4ddfe17/131007_devstack_export.log : SUCCESS in 5m 18s\n- gate-real-db-upgrade_nova_mysql_devstack_150 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_mysql_devstack_150/1391a6a/datasets_devstack_150.log : No migrations run in 4m 22s (non-voting)\n- gate-real-db-upgrade_nova_mysql_user_001 http://www.rcbops.com/turbo_hipster/results/62/62896/12/check/gate-real-db-upgrade_nova_mysql_user_001/ab88c0a/user_001.log : SUCCESS in 0s\n- gate-real-db-upgrade_nova_percona_devstack_131007 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_percona_devstack_131007/1e574eb/131007_devstack_export.log : SUCCESS in 5m 28s\n- gate-real-db-upgrade_nova_percona_devstack_150 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_percona_devstack_150/c7e04ab/datasets_devstack_150.log : No migrations run in 4m 20s (non-voting)\n- gate-real-db-upgrade_nova_percona_user_001 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_percona_user_001/f7a2dc4/user_001.log : SUCCESS in 17m 58s\n- gate-real-db-upgrade_nova_mysql_user_002 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_mysql_user_002/1f66419/user_002.log : SUCCESS in 7m 36s (non-voting)\n- gate-real-db-upgrade_nova_percona_user_002 http://www.rcbops.com/turbo_hipster/results/57/57708/2/check/gate-real-db-upgrade_nova_percona_user_002/e8c46f5/user_002.log : SUCCESS in 8m 03s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"9fecfc35056ef6796c274f93a3311dbcc7957e44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-21 10:28:38.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/08/57708/2/check/gate-nova-pep8/44f0d74 : SUCCESS in 7m 35s\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/2/check/gate-nova-docs/82f0bcd/doc/build/html/ : SUCCESS in 7m 50s\n- gate-nova-python26 http://logs.openstack.org/08/57708/2/check/gate-nova-python26/23aacc8 : SUCCESS in 19m 39s\n- gate-nova-python27 http://logs.openstack.org/08/57708/2/check/gate-nova-python27/80e3cd1 : SUCCESS in 15m 00s\n- check-tempest-dsvm-full http://logs.openstack.org/08/57708/2/check/check-tempest-dsvm-full/970a99b : SUCCESS in 55m 07s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/57708/2/check/check-tempest-dsvm-postgres-full/7a106e3 : SUCCESS in 57m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/57708/2/check/check-tempest-dsvm-neutron/cda2cda : SUCCESS in 31m 14s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/57708/2/check/gate-tempest-dsvm-large-ops/95576db : SUCCESS in 15m 55s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/57708/2/check/gate-tempest-dsvm-neutron-large-ops/538a2da : SUCCESS in 17m 31s\n- check-grenade-dsvm http://logs.openstack.org/08/57708/2/check/check-grenade-dsvm/d29ab5f : SUCCESS in 35m 03s\n- gate-devstack-dsvm-cells http://logs.openstack.org/08/57708/2/check/gate-devstack-dsvm-cells/10ceec7 : SUCCESS in 10m 24s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/08/57708/2/check/gate-nova-pylint/88f516c : SUCCESS in 15m 07s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"f1338d1a5a61bd067c6a36878232f4133338afe3","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2014-01-21 14:03:20.000000000","message":"Patch Set 2: (1 inline comment)\n\n@Andrew - Commented in line why I think this is a valid fix and not a paper over the cracks.   I\u0027ve also updated the original bug text as I realise now that I didn\u0027t do that once we\u0027d worked out why this happens.\n\nCommit message should include some of the core points from the revised bug text as to why either of disk_available_least or free_gb could be the true minimum value","accounts_in_message":[],"_revision_number":2},{"id":"2762e37d9bb6f6ba19cb681b2d1f828b8a109f17","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2014-01-21 16:25:55.000000000","message":"Patch Set 2: (1 inline comment)\n\nWould like to see an updated commit message and _gb suffix comment addressed, otherwise lgtm.","accounts_in_message":[],"_revision_number":2},{"id":"dcb13558c3062e34c76832f97e8de60ac073b4fe","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2014-01-24 10:54:41.000000000","message":"Patch Set 2: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a2c379d5b0c2a2bc9f875ccad0a0683ab20dcd8c","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2014-01-24 12:11:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b1186e7b2e7e1ad3ecf490d142da31a559cebf95","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-01-24 12:31:03.000000000","message":"Patch Set 3: Works for me\n\nDatabase migration testing successful.\n\n- gate-real-db-upgrade_nova_mysql_devstack_131007 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_mysql_devstack_131007/1b85d4e/131007_devstack_export.log : SUCCESS in 5m 34s\n- gate-real-db-upgrade_nova_mysql_devstack_150 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_mysql_devstack_150/755c437/datasets_devstack_150.log : No migrations run in 4m 21s (non-voting)\n- gate-real-db-upgrade_nova_mysql_user_001 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_mysql_user_001/b04fa92/user_001.log : SUCCESS in 16m 54s\n- gate-real-db-upgrade_nova_percona_devstack_131007 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_devstack_131007/027c473/131007_devstack_export.log : SUCCESS in 5m 16s\n- gate-real-db-upgrade_nova_percona_devstack_150 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_devstack_150/6d66f9d/datasets_devstack_150.log : No migrations run in 1m 36s (non-voting)\n- gate-real-db-upgrade_nova_percona_user_001 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_user_001/9a26cd7/user_001.log : SUCCESS in 18m 47s\n- gate-real-db-upgrade_nova_mysql_user_002 http://www.rcbops.com/turbo_hipster/results/62/62896/11/check/gate-real-db-upgrade_nova_mysql_user_002/82654af/user_002.log : No migrations run in 0s (non-voting)\n- gate-real-db-upgrade_nova_percona_user_002 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_user_002/0567707/user_002.log : SUCCESS in 7m 41s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"e36d6e27fff85480fab2b7a47008a2f2db299992","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-24 13:08:21.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/08/57708/3/check/gate-nova-pep8/d1d58cd : SUCCESS in 7m 40s\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/3/check/gate-nova-docs/6eee857/doc/build/html/ : SUCCESS in 8m 21s\n- gate-nova-python26 http://logs.openstack.org/08/57708/3/check/gate-nova-python26/0fd3202 : SUCCESS in 23m 10s\n- gate-nova-python27 http://logs.openstack.org/08/57708/3/check/gate-nova-python27/ea2f929 : SUCCESS in 11m 45s\n- check-tempest-dsvm-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-full/fe79e5f : SUCCESS in 51m 44s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-postgres-full/73b2cba : SUCCESS in 55m 24s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-neutron/0770d6d : SUCCESS in 32m 28s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/57708/3/check/gate-tempest-dsvm-large-ops/6ffb550 : SUCCESS in 11m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/57708/3/check/gate-tempest-dsvm-neutron-large-ops/03a3399 : SUCCESS in 14m 17s\n- check-grenade-dsvm http://logs.openstack.org/08/57708/3/check/check-grenade-dsvm/f426e52 : FAILURE in 20m 44s\n- gate-devstack-dsvm-cells http://logs.openstack.org/08/57708/3/check/gate-devstack-dsvm-cells/e8d8519 : SUCCESS in 10m 41s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/08/57708/3/check/gate-nova-pylint/7cffdac : SUCCESS in 14m 37s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"d1101775f1ef7e4dd054a5032ac2dc09b38065cc","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-24 13:08:38.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1209086\n- https://bugs.launchpad.net/bugs/1240256\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1209086\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1209086","accounts_in_message":[],"_revision_number":3},{"id":"27c915d5157c212d0747b383316ecbb12fe9ef33","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2014-01-24 13:22:18.000000000","message":"Patch Set 3:\n\nrecheck bug 1240256","accounts_in_message":[],"_revision_number":3},{"id":"82f022eede7517a9f4fa03e8d2655f8ea2a52281","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-01-24 13:40:16.000000000","message":"Patch Set 3:\n\nDatabase migration testing successful.\n\n- gate-real-db-upgrade_nova_mysql_devstack_131007 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_mysql_devstack_131007/dbb66a5/131007_devstack_export.log : SUCCESS in 6m 25s\n- gate-real-db-upgrade_nova_mysql_devstack_150 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_mysql_devstack_150/fad50a3/datasets_devstack_150.log : No migrations run in 4m 33s (non-voting)\n- gate-real-db-upgrade_nova_mysql_user_001 http://www.rcbops.com/turbo_hipster/results/62/62896/12/check/gate-real-db-upgrade_nova_mysql_user_001/ab88c0a/user_001.log : SUCCESS in 0s\n- gate-real-db-upgrade_nova_percona_devstack_131007 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_devstack_131007/d37dc74/131007_devstack_export.log : SUCCESS in 5m 37s\n- gate-real-db-upgrade_nova_percona_devstack_150 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_devstack_150/84f1c3c/datasets_devstack_150.log : No migrations run in 4m 29s (non-voting)\n- gate-real-db-upgrade_nova_percona_user_001 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_user_001/63997db/user_001.log : SUCCESS in 17m 34s\n- gate-real-db-upgrade_nova_mysql_user_002 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_mysql_user_002/dfca0ef/user_002.log : SUCCESS in 8m 02s (non-voting)\n- gate-real-db-upgrade_nova_percona_user_002 http://www.rcbops.com/turbo_hipster/results/57/57708/3/check/gate-real-db-upgrade_nova_percona_user_002/88db829/user_002.log : SUCCESS in 8m 05s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"16ce5181c3d56a2f4bbcad806eb000ee3c424efd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-24 14:30:06.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/08/57708/3/check/gate-nova-pep8/1784c4b : SUCCESS in 7m 26s\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/3/check/gate-nova-docs/3e086d6/doc/build/html/ : SUCCESS in 6m 58s\n- gate-nova-python26 http://logs.openstack.org/08/57708/3/check/gate-nova-python26/93d30a5 : SUCCESS in 19m 51s\n- gate-nova-python27 http://logs.openstack.org/08/57708/3/check/gate-nova-python27/d197842 : SUCCESS in 13m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-full/c79e0c8 : SUCCESS in 1h 00m 39s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-postgres-full/f7d1922 : SUCCESS in 1h 00m 26s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-neutron/a50241e : SUCCESS in 29m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/57708/3/check/gate-tempest-dsvm-large-ops/7eb0492 : SUCCESS in 11m 07s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/57708/3/check/gate-tempest-dsvm-neutron-large-ops/e80e91b : SUCCESS in 14m 55s\n- check-grenade-dsvm http://logs.openstack.org/08/57708/3/check/check-grenade-dsvm/74b266c : SUCCESS in 30m 28s\n- gate-devstack-dsvm-cells http://logs.openstack.org/08/57708/3/check/gate-devstack-dsvm-cells/9069cc2 : SUCCESS in 10m 01s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/08/57708/3/check/gate-nova-pylint/cd1e526 : SUCCESS in 15m 08s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"72826d79cfd248d1e63c96757693b5654b6bdbfc","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2014-01-24 15:55:40.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8012dac32ec927b8146a22367a921bd5ff4cb53d","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2014-01-24 16:14:46.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nLooks much better.  I\u0027m unclear on one thing though.","accounts_in_message":[],"_revision_number":3},{"id":"abcd189ab033bb6d72d67d87f0654fca27097d48","author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"date":"2014-01-24 17:04:08.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d54ef3a2aa9828454e38b9d256d2126d2d75fcae","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2014-01-24 17:48:18.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"42db666924db58175a90f76b2e1f64c0b8d0c904","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2014-01-25 01:51:12.000000000","message":"Patch Set 3: Works for me\n\nBuild successful. Logs: http://208.91.1.172/logs/nova/57708/3","accounts_in_message":[],"_revision_number":3},{"id":"bc8c4b23a8a9cbda48c721d858ca3dd30c808b07","author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"date":"2014-02-04 22:36:47.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"eda60315b4b27ca352f0172d70e5a56e62c382e0","author":{"_account_id":7537,"name":"Matthew Macdonald-Wallace","email":"mmw@hp.com","username":"macdomat"},"date":"2014-02-13 09:40:13.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nMakes sense","accounts_in_message":[],"_revision_number":3},{"id":"a79e461e39a9df7d8227973b977a7b4194330c17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 09:40:16.000000000","message":"Patch Set 3: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"726a1f81f19cb7080280f8686288cecd8f479354","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 10:27:09.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/08/57708/3/check/gate-nova-pep8/3b2ac00 : SUCCESS in 8m 00s\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/3/check/gate-nova-docs/da18b5f/doc/build/html/ : SUCCESS in 7m 31s\n- gate-nova-python26 http://logs.openstack.org/08/57708/3/check/gate-nova-python26/6849942 : SUCCESS in 21m 58s\n- gate-nova-python27 http://logs.openstack.org/08/57708/3/check/gate-nova-python27/dd2f128 : SUCCESS in 13m 09s\n- check-devstack-dsvm-cells http://logs.openstack.org/08/57708/3/check/check-devstack-dsvm-cells/cf998ed : SUCCESS in 12m 28s\n- check-tempest-dsvm-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-full/1bbe87f : SUCCESS in 46m 39s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-postgres-full/b27b1cb : SUCCESS in 45m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-neutron/c82eecc : SUCCESS in 30m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/57708/3/check/gate-tempest-dsvm-large-ops/b8ea97b : SUCCESS in 11m 55s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/57708/3/check/gate-tempest-dsvm-neutron-large-ops/0536fe5 : SUCCESS in 14m 26s\n- check-grenade-dsvm http://logs.openstack.org/08/57708/3/check/check-grenade-dsvm/0762c17 : SUCCESS in 32m 54s\n- check-tempest-dsvm-cells-full http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-cells-full/7a8d7f9 : FAILURE in 24m 49s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/08/57708/3/check/gate-nova-pylint/c706fc5 : SUCCESS in 14m 06s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/08/57708/3/check/check-tempest-dsvm-neutron-heat-slow/37b19d9 : FAILURE in 20m 59s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"4a95f2375b55be006be6de2eb162903edb59239e","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2014-02-13 10:48:44.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n(2 inline comments)\n\nAs a robustness fix, I think this is fine ... but it does point to an underlying screwiness. Would be nice to get to the root cause over why disk_available_least can wind up being less than free_disk_gb","accounts_in_message":[],"_revision_number":3},{"id":"968565d1b394a9c161622172fc9b7d8c50a1c322","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 10:48:47.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ba63b8a9025351977bfa340fa9569e411469ee21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 12:10:22.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- gate-nova-docs http://docs-draft.openstack.org/08/57708/3/gate/gate-nova-docs/39c07a8/doc/build/html/ : SUCCESS in 7m 59s\n- gate-nova-pep8 http://logs.openstack.org/08/57708/3/gate/gate-nova-pep8/a7accb1 : SUCCESS in 7m 53s\n- gate-nova-python26 http://logs.openstack.org/08/57708/3/gate/gate-nova-python26/8223d08 : SUCCESS in 21m 59s\n- gate-nova-python27 http://logs.openstack.org/08/57708/3/gate/gate-nova-python27/5906d33 : SUCCESS in 11m 34s\n- gate-devstack-dsvm-cells http://logs.openstack.org/08/57708/3/gate/gate-devstack-dsvm-cells/8af84f6 : SUCCESS in 13m 07s\n- gate-tempest-dsvm-full http://logs.openstack.org/08/57708/3/gate/gate-tempest-dsvm-full/cca2450 : SUCCESS in 44m 03s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/08/57708/3/gate/gate-tempest-dsvm-postgres-full/b9cca89 : SUCCESS in 46m 23s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/08/57708/3/gate/gate-tempest-dsvm-neutron/5d6177d : SUCCESS in 34m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/57708/3/gate/gate-tempest-dsvm-large-ops/f0ad659 : SUCCESS in 13m 14s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/57708/3/gate/gate-tempest-dsvm-neutron-large-ops/6704149 : SUCCESS in 16m 48s\n- gate-grenade-dsvm http://logs.openstack.org/08/57708/3/gate/gate-grenade-dsvm/5436dc0 : SUCCESS in 36m 07s\n","accounts_in_message":[],"_revision_number":3},{"id":"65455d1d32390c65c63ec76c3898af530639babd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-13 12:10:25.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"56688707138d2343a65e25f8c27586ffd44875cf","revisions":{"fafca035ba6d093c0e51aee18c2afc832debd041":{"kind":"REWORK","_number":1,"created":"2013-11-21 16:03:11.000000000","uploader":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"ref":"refs/changes/08/57708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/08/57708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/08/57708/1"}}},"commit":{"parents":[{"commit":"9b44d9d75d3767c6b7d1af4f237da8c1cf16266a","subject":"Sync local from oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b44d9d75d3767c6b7d1af4f237da8c1cf16266a"}]}],"author":{"name":"Ryan Moore","email":"ryan.moore@hp.com","date":"2013-11-21 15:38:56.000000000","tz":0},"committer":{"name":"Ryan Moore","email":"ryan.moore@hp.com","date":"2013-11-21 15:38:56.000000000","tz":0},"subject":"Correct host managers free disk calculation","message":"Correct host managers free disk calculation\n\nTake lower of disk_least_available/free_disk_gb if they exist.\n\nTesting:\nCOMPUTE_NODES in fakes.py includes the 4 possible test cases:\n    disk_least_available or free_disk_gb \u003d free_disk_mb\n        None             or     512      \u003d    524288\n        1024             or    None      \u003d   1048576\n        3333             or    3072      \u003d   3145728\n        8192             or    8888      \u003d   8388608\n   test: test_host_manager.py(test_get_all_host_states)\n         already has existing tests looking for these\n         cases - I\u0027ve modifed the test data rather than\n         creating new test data.\n         No impact on other tests.\n\nChange-Id: I4a18bf023a64d0cb198f77aab9daecb0786e93ff\nCloses-Bug: 1253599\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fafca035ba6d093c0e51aee18c2afc832debd041"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fafca035ba6d093c0e51aee18c2afc832debd041"}]},"branch":"refs/heads/master"},"668eecdef1c39ba2a2085a886f65b44e67e9ad30":{"kind":"REWORK","_number":2,"created":"2013-11-21 16:06:00.000000000","uploader":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"ref":"refs/changes/08/57708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/08/57708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/08/57708/2"}}},"commit":{"parents":[{"commit":"9b44d9d75d3767c6b7d1af4f237da8c1cf16266a","subject":"Sync local from oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b44d9d75d3767c6b7d1af4f237da8c1cf16266a"}]}],"author":{"name":"Ryan Moore","email":"ryan.moore@hp.com","date":"2013-11-21 15:38:56.000000000","tz":0},"committer":{"name":"Ryan Moore","email":"ryan.moore@hp.com","date":"2013-11-21 16:05:38.000000000","tz":0},"subject":"Correct host managers free disk calculation","message":"Correct host managers free disk calculation\n\nTake lower of disk_least_available/free_disk_gb if they exist.\n\nTesting:\nCOMPUTE_NODES in fakes.py includes the 4 possible test cases:\n    disk_least_available or free_disk_gb \u003d free_disk_mb\n        None             or     512      \u003d    524288\n        1024             or    None      \u003d   1048576\n        3333             or    3072      \u003d   3145728\n        8192             or    8888      \u003d   8388608\n   test: test_host_manager.py(test_get_all_host_states)\n         already has existing tests looking for these\n         cases - I\u0027ve modifed the test data rather than\n         creating new test data.\n         No impact on other tests.\n\nChange-Id: I4a18bf023a64d0cb198f77aab9daecb0786e93ff\nCloses-Bug: 1253599\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/668eecdef1c39ba2a2085a886f65b44e67e9ad30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/668eecdef1c39ba2a2085a886f65b44e67e9ad30"}]},"branch":"refs/heads/master"},"56688707138d2343a65e25f8c27586ffd44875cf":{"kind":"REWORK","_number":3,"created":"2014-01-24 12:11:45.000000000","uploader":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"ref":"refs/changes/08/57708/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/08/57708/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/08/57708/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/08/57708/3"}}},"commit":{"parents":[{"commit":"d7986fe1ee72cf8478954b40644c572718d6d65c","subject":"Merge \"VMware: fix rescue with disks are not hot-addable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d7986fe1ee72cf8478954b40644c572718d6d65c"}]}],"author":{"name":"Ryan Moore","email":"ryan.moore@hp.com","date":"2013-11-21 15:38:56.000000000","tz":0},"committer":{"name":"Ryan Moore","email":"ryan.moore@hp.com","date":"2014-01-24 12:12:05.000000000","tz":0},"subject":"Correct host managers free disk calculation","message":"Correct host managers free disk calculation\n\nTake lower of disk_least_available/free_disk_gb if they exist.\n\nWhen an instance exists in the database but not on the hypervisor\n(which can happen in some error cases), the \u0027missing\u0027 instance\nis included in the calculation of \u0027free_gb\u0027 but not included in\n\u0027disk_available_least\u0027.\nNeed to take the value that represents the minimum amount of free\ndisk space available.\n\nTesting:\nCOMPUTE_NODES in fakes.py includes the 4 possible test cases:\n    disk_least_available or free_disk_gb \u003d free_disk_mb\n        None             or     512      \u003d    524288\n        1024             or    None      \u003d   1048576\n        3333             or    3072      \u003d   3145728\n        8192             or    8888      \u003d   8388608\n   test: test_host_manager.py\n           test_get_all_host_states:\n             Already has existing tests looking for these\n             cases - I\u0027ve modifed the test data (in fakes.py)\n             rather than creating new test data.\n             Added check for Warning message for node 3 where\n             physical disk (3333) is greater than database (3072)\n         No impact on other tests.\n\nChange-Id: I4a18bf023a64d0cb198f77aab9daecb0786e93ff\nCloses-Bug: 1253599\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56688707138d2343a65e25f8c27586ffd44875cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56688707138d2343a65e25f8c27586ffd44875cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}