)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"090a0d51eea3ac294530f32d51440a9e9933d0c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gergely Csatari \u003cgergely.csatari@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-22 09:01:14 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding oslo.service to test-requirements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Doc building requires oslo.service and it is missing from the"},{"line_number":10,"context_line":"documentation requirements."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_d25d8948","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":40},"updated":"2018-06-22 15:05:46.000000000","message":"doc requirements","commit_id":"953232aede2ae1b06b26c61e864332d0b722962f"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"008b353e7cb97320ed55019b47f5f7aed975ac80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gergely Csatari \u003cgergely.csatari@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-22 09:01:14 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding oslo.service to test-requirements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Doc building requires oslo.service and it is missing from the"},{"line_number":10,"context_line":"documentation requirements."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_ea95143e","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":40},"in_reply_to":"5f7c97a3_d25d8948","updated":"2018-06-25 07:14:59.000000000","message":"Done","commit_id":"953232aede2ae1b06b26c61e864332d0b722962f"}],"test-requirements.txt":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9efcd3586146404179afa05ec368f6b7d488ba8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":22,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"gabbi\u003e\u003d1.35.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.service!\u003d1.28.1,\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# vmwareapi driver specific dependencies"},{"line_number":27,"context_line":"oslo.vmware\u003e\u003d2.17.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_0493db50","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":42},"updated":"2018-06-21 09:35:26.000000000","message":"this is present in requirements.txt so we do not need to add the duplicate entry. \n\n- https://github.com/openstack/nova/blob/9882a60e69a5ab8da314a199a56defc05098b743/requirements.txt#L50","commit_id":"48296129c84e415309b0907e4f2bb6b810f3ad48"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"e1d8c05951f1ccc8cac5db095b4f540482c5685f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":22,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"gabbi\u003e\u003d1.35.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.service!\u003d1.28.1,\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# vmwareapi driver specific dependencies"},{"line_number":27,"context_line":"oslo.vmware\u003e\u003d2.17.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_7d7ca21f","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":42},"in_reply_to":"5f7c97a3_0493db50","updated":"2018-06-21 12:07:25.000000000","message":"Wasn\u0027t it so that everything what is needed for the docs building should be in test-requirements.txt? Without this docs building fails for me.","commit_id":"48296129c84e415309b0907e4f2bb6b810f3ad48"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53074cf385041d55b8fe521e589bda1ce713b498","unresolved":false,"context_lines":[{"line_number":21,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":22,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"gabbi\u003e\u003d1.35.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.service!\u003d1.28.1,\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# vmwareapi driver specific dependencies"},{"line_number":27,"context_line":"oslo.vmware\u003e\u003d2.17.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_985bcc52","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":42},"in_reply_to":"5f7c97a3_7d7ca21f","updated":"2018-06-21 13:02:50.000000000","message":"Yeah but if those dependency are present in requirements.txt then it is not need to be here. test-requirements.txt should have those dependency which are not present in requirements.txt\n\nWhen we try to install the nova then all the dependency present in requirements.txt are being installed already to those need not to be duplicate in test_requirements.txt","commit_id":"48296129c84e415309b0907e4f2bb6b810f3ad48"}]}