)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e94949366f9221f70c927e5ec81a644cdf669d81","unresolved":false,"context_lines":[{"line_number":7448,"context_line":"                     \u0027dev\u0027: \u0027vdb\u0027}"},{"line_number":7449,"context_line":"        libvirt_exc \u003d fakelibvirt.make_libvirtError(fakelibvirt.libvirtError,"},{"line_number":7450,"context_line":"            \"unable to execute QEMU command \u0027object-add\u0027: Incorrect number\""},{"line_number":7451,"context_line":"            \" of padding bytes (57) found on decrypted data\","},{"line_number":7452,"context_line":"            error_code\u003dfakelibvirt.VIR_ERR_INTERNAL_ERROR)"},{"line_number":7453,"context_line":""},{"line_number":7454,"context_line":"        with test.nested("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_39edd924","line":7451,"updated":"2018-06-21 15:14:45.000000000","message":"Nit: Shouldn\u0027t that padding bytes number be 56?  Because 56 is the \u0027ordinal\u0027 value of character \u00278\u0027.\n\nI just did two tests with a buggy version of libvirt and two pass-phrases that are multiples of 16 bytes.  In both scenarios, the error is always with \u002756\u0027:\n\n\n$\u003e sudo /opt/libvirt/3.1.0/bin/virsh start luks-cvm1\nerror: Failed to start domain luks-cvm1\nerror: internal error: process exited while connecting to monitor: 2018-06-21T14:48:04.266212Z qemu-system-x86_64: -object secret,id\u003dvirtio-disk1-luks-secret0,data\u003dJYFE5hCfE3HLB2sg+ijBxA\u003d\u003d,keyid\u003dmasterKey0,iv\u003d82KdTwVNsSy2Oh6heddufQ\u003d\u003d,format\u003dbase64: Incorrect number of padding bytes (56) found on decrypted data","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"928f76a9dfab2358b24ecf4eda9a0c2ba3826514","unresolved":false,"context_lines":[{"line_number":7472,"context_line":"            self.assertRaises(fakelibvirt.libvirtError, drvr.attach_volume,"},{"line_number":7473,"context_line":"                self.context, connection_info, instance, \"/dev/vdb\","},{"line_number":7474,"context_line":"                disk_bus\u003dbdm[\u0027disk_bus\u0027], device_type\u003dbdm[\u0027device_type\u0027])"},{"line_number":7475,"context_line":"            mock_log.warning.assert_called_once()"},{"line_number":7476,"context_line":""},{"line_number":7477,"context_line":"    @mock.patch(\u0027nova.utils.get_image_from_system_metadata\u0027)"},{"line_number":7478,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.blockinfo.get_info_from_bdm\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3e51290e","line":7475,"range":{"start_line":7475,"start_character":29,"end_line":7475,"end_character":47},"updated":"2018-06-22 13:34:45.000000000","message":"nit: assert_called_once_with would be better, or assert_called_once and then call_args (or call_args_list) to do an assertIn style check to make sure the warning is coming from the thing you expect and not something else.","commit_id":"78891c2305bff6e16706339a9c5eca99a84e409c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a321d44aa2f76f67d82eea65d50114309c10c2e7","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1420,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1421,"context_line":"                LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1422,"context_line":"                    \u0027known Libvirt issue, see the following bug for details: \u0027"},{"line_number":1423,"context_line":"                    \u0027https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f6a45009","line":1420,"updated":"2018-06-21 14:41:41.000000000","message":"Hum this is not going to work for none English local.\n\nWhat you can do is introduce a constant with the minimum version needed and check the error code returned by libvirt.\n\nThat will result something like:\n\n  if MIN_LIBVIRT_VERSION_ENCYPTED_VOLUME_ISSUE and err_code \u003d\u003d X:\n     LOG.warning(..)","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"fd27ee4bfb992b74a85a283377ff8deccf43064c","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1420,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1421,"context_line":"                LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1422,"context_line":"                    \u0027known Libvirt issue, see the following bug for details: \u0027"},{"line_number":1423,"context_line":"                    \u0027https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e26fa6c1","line":1420,"in_reply_to":"5f7c97a3_96263c16","updated":"2018-06-21 17:29:01.000000000","message":"I agree with Lee here.  It\u0027s an overkill to introduce yet another version constant.","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ad233e87bd0df48c4ef217595d5ecec08717d0e9","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1420,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1421,"context_line":"                LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1422,"context_line":"                    \u0027known Libvirt issue, see the following bug for details: \u0027"},{"line_number":1423,"context_line":"                    \u0027https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dcc6139d","line":1420,"in_reply_to":"5f7c97a3_96263c16","updated":"2018-06-21 15:55:15.000000000","message":"We usually base our versions on libvirt releases not on internal backport that distro are doing.","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2789b29becc96802961cfd17b942dcf2d0ec7770","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1420,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1421,"context_line":"                LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1422,"context_line":"                    \u0027known Libvirt issue, see the following bug for details: \u0027"},{"line_number":1423,"context_line":"                    \u0027https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc0933dc","line":1420,"in_reply_to":"5f7c97a3_dcc6139d","updated":"2018-06-21 15:58:08.000000000","message":"I understand that works for features but for bugfixes? Do you have any examples?","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5c226ae0893d5e6277e8c4f640faa63ae5f391e","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1420,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1421,"context_line":"                LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1422,"context_line":"                    \u0027known Libvirt issue, see the following bug for details: \u0027"},{"line_number":1423,"context_line":"                    \u0027https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6cc5bf09","line":1420,"in_reply_to":"5f7c97a3_e26fa6c1","updated":"2018-06-22 08:15:57.000000000","message":"I understand and mostly agree with the above. However, can you put a TODO here indicating the upstream version this is actually fixed in? This would provide an indication as to when the check can be removed","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"58302ce58dab453fc9d62d62ae3b27674a840398","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1420,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"},{"line_number":1421,"context_line":"                LOG.warning(_(\u0027Failed to attach encrypted volume due to a \u0027"},{"line_number":1422,"context_line":"                    \u0027known Libvirt issue, see the following bug for details: \u0027"},{"line_number":1423,"context_line":"                    \u0027https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_96263c16","line":1420,"in_reply_to":"5f7c97a3_f6a45009","updated":"2018-06-21 14:58:13.000000000","message":"Yeah that\u0027s true regarding this only working for an English locale. \n\nHowever we can\u0027t use your suggestion as the fix has landed in various versions of Libvirt depending on the underlying distro (3.2.0-4 in RHEL for example) and the code returned is `internal error` that is too generic to use here.\n\nI think this is the best we can do and after all we are only providing a breadcrumb here, nothing more.","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"928f76a9dfab2358b24ecf4eda9a0c2ba3826514","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"            instance.save()"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        # TODO(lyarwood) Remove the following breadcrumb once all supported"},{"line_number":1420,"context_line":"        # distributions provide Libvirt 3.3.0 or earlier with"},{"line_number":1421,"context_line":"        # https://libvirt.org/git/?p\u003dlibvirt.git;a\u003dcommit;h\u003d7189099 applied."},{"line_number":1422,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":1423,"context_line":"            if \u0027Incorrect number of padding bytes\u0027 in six.text_type(ex):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9e795d94","line":1420,"range":{"start_line":1420,"start_character":40,"end_line":1420,"end_character":45},"updated":"2018-06-22 13:34:45.000000000","message":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297 says this is fixed in 3.2.0?\n\nFixed In Version: \tlibvirt-3.2.0-4.el7\n\nOr is that the RHEL distro version it was fixed in and the upstream tag is 3.3.0?\n\n(later)\n\nOK it\u0027s on the 3.3.0 tag in the libvirt git repo:\n\nhttps://github.com/libvirt/libvirt/commit/7189099\n\nSo this is OK.","commit_id":"78891c2305bff6e16706339a9c5eca99a84e409c"}],"releasenotes/notes/bug-1778044-f498ee2f2cfb35ea.yaml":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e94949366f9221f70c927e5ec81a644cdf669d81","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    Libvirt to a version where this issue has been fixed to resolve the issue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _known issue: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297"},{"line_number":15,"context_line":"    .. _resolved: https://www.redhat.com/archives/libvir-list/2017-May/msg00030.html"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_534f5634","line":15,"updated":"2018-06-21 15:14:45.000000000","message":"If you need to respin for any reason, might want to link to the commit message instead -- https://libvirt.org/git/?p\u003dlibvirt.git;a\u003dcommit;h\u003d7189099","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e8d04490d57a9132032c8e73c76f806dff4f58ae","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    Libvirt to a version where this issue has been fixed to resolve the issue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _known issue: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1447297"},{"line_number":15,"context_line":"    .. _resolved: https://www.redhat.com/archives/libvir-list/2017-May/msg00030.html"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_5cfd23b0","line":15,"in_reply_to":"5f7c97a3_534f5634","updated":"2018-06-21 16:00:42.000000000","message":"ACK will do thanks.","commit_id":"526c03c14c9a4f00965aa9b1adc6f41db0410f1d"}]}