)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e29ba365e553af5a7b5a62fe5131b07024ab3e9","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c8ede924","line":1525,"updated":"2018-06-21 19:01:14.000000000","message":"I really think this is too generic to be a useful name. It returns very specific information, none of which is what the rest of nova calls \"network info\". If other people feel differently please speak up, but I think this needs to have \"phy\" or \"physical\" in the name. Even the docstring makes it sound like this returns general details about a network, but..it doesn\u0027t.","commit_id":"3939d978fefff71e474c1edb97ca737ff7bfa85b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"618652e69f6cc2f61f671b5aa2423b4e1c7e1c8b","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_32cba21d","line":1525,"in_reply_to":"5f7c97a3_72883a21","updated":"2018-06-22 10:10:50.000000000","message":"OK, I see now that this will be extended with reading the tunelling information from the network later in https://review.openstack.org/#/c/564445\n\nIf the network info name already taken in nova for something else, then we could try something like get_neutron_network_details() maybe.","commit_id":"3939d978fefff71e474c1edb97ca737ff7bfa85b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"121011c6bcc14e7868a456b8549f47390949f602","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72883a21","line":1525,"in_reply_to":"5f7c97a3_c8ede924","updated":"2018-06-22 10:06:17.000000000","message":"I agree with Dan. If in the future it will return more information than just the physnet then we can agree on making the name more generic.","commit_id":"3939d978fefff71e474c1edb97ca737ff7bfa85b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea4f438e4459099b69eb482894e05a308188a8e7","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_12930150","line":1525,"in_reply_to":"5f7c97a3_c8ede924","updated":"2018-06-22 14:48:40.000000000","message":"This changes as soon as I merge the tunnel support gibi mentions below. I\u0027ve left this as is for now but can change if you still think I should","commit_id":"3939d978fefff71e474c1edb97ca737ff7bfa85b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8ebbcf0d0f49d0d12d96c0b0ef3f3f6c87dd500","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"                pci_requests.requests.append(request)"},{"line_number":1640,"context_line":"                pci_request_id \u003d request.request_id"},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"            # Add pci_request_id into the requested network"},{"line_number":1643,"context_line":"            request_net.pci_request_id \u003d pci_request_id"},{"line_number":1644,"context_line":""},{"line_number":1645,"context_line":"    def _can_auto_allocate_network(self, context, neutron):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_96d125fb","side":"PARENT","line":1642,"updated":"2018-06-25 14:48:24.000000000","message":"Also unrelated.","commit_id":"d137fd1b64624e9e4c2ea87b69c3a85614441e4d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"536af6d9b573ca2efaa8179ad73e15ccc0dc053b","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"                pci_requests.requests.append(request)"},{"line_number":1640,"context_line":"                pci_request_id \u003d request.request_id"},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"            # Add pci_request_id into the requested network"},{"line_number":1643,"context_line":"            request_net.pci_request_id \u003d pci_request_id"},{"line_number":1644,"context_line":""},{"line_number":1645,"context_line":"    def _can_auto_allocate_network(self, context, neutron):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f383b554","side":"PARENT","line":1642,"in_reply_to":"5f7c97a3_96d125fb","updated":"2018-06-26 09:57:56.000000000","message":"Done","commit_id":"d137fd1b64624e9e4c2ea87b69c3a85614441e4d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8ebbcf0d0f49d0d12d96c0b0ef3f3f6c87dd500","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f6309957","line":1525,"range":{"start_line":1525,"start_character":8,"end_line":1525,"end_character":25},"updated":"2018-06-25 14:48:24.000000000","message":"This does seem weird in that it only returns the physnet name, and eventually you\u0027re also going to be returning the tunneled value in what, a tuple? If I\u0027m passing context, neutron (the client) and a network ID, I\u0027d expect this to just be a GET /networks/{id} call, which is the get() method in this class already.\n\nDoes tunneled have nothing to do with physical networks? If it does, then I\u0027d say just leave this as it was. If it doesn\u0027t, make the method specific to what you\u0027re getting:\n\n_get_physnet_name_and_tunneled (_and_tunneled when you add that).","commit_id":"3e2b3d819365598eca4f30e7a8c54dfee27f1556"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"536af6d9b573ca2efaa8179ad73e15ccc0dc053b","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_139e71b7","line":1525,"range":{"start_line":1525,"start_character":8,"end_line":1525,"end_character":25},"in_reply_to":"5f7c97a3_f6309957","updated":"2018-06-26 09:57:56.000000000","message":"Done","commit_id":"3e2b3d819365598eca4f30e7a8c54dfee27f1556"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f540ca2854f4b539706a4f5ba0417a2ff39f17d","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"        raise exception.FixedIpNotFoundForSpecificInstance("},{"line_number":1523,"context_line":"                instance_uuid\u003dinstance.uuid, ip\u003daddress)"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"    def _get_network_info(self, context, neutron, net_id):"},{"line_number":1526,"context_line":"        \"\"\"Retrieve detailed network info."},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8ae01299","line":1525,"range":{"start_line":1525,"start_character":8,"end_line":1525,"end_character":25},"in_reply_to":"5f7c97a3_f6309957","updated":"2018-06-25 17:39:58.000000000","message":"Yep, 29 other mentions of \"network_info\" or \"nw_info\" in this file before this change, all of which (AFAICT) mean the network_info structure.","commit_id":"3e2b3d819365598eca4f30e7a8c54dfee27f1556"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8ebbcf0d0f49d0d12d96c0b0ef3f3f6c87dd500","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"            return strutils.bool_from_string(value)"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"    def _get_port_vnic_info(self, context, neutron, port_id):"},{"line_number":1579,"context_line":"        \"\"\"Retrieve port vNIC info."},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        :param context: The request context."},{"line_number":1582,"context_line":"        :param neutron: The neutron client object."},{"line_number":1583,"context_line":"        :param port_id: ID of port to retrieve information for."},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"        :return: A tuple of vNIC type, trusted status and network ID. Trusted"},{"line_number":1586,"context_line":"            status only affects SR-IOV ports and will always be None for other"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b6cb0151","line":1583,"range":{"start_line":1579,"start_character":8,"end_line":1583,"end_character":63},"updated":"2018-06-25 14:48:24.000000000","message":"None of this needed to change right?","commit_id":"3e2b3d819365598eca4f30e7a8c54dfee27f1556"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"536af6d9b573ca2efaa8179ad73e15ccc0dc053b","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"            return strutils.bool_from_string(value)"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"    def _get_port_vnic_info(self, context, neutron, port_id):"},{"line_number":1579,"context_line":"        \"\"\"Retrieve port vNIC info."},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        :param context: The request context."},{"line_number":1582,"context_line":"        :param neutron: The neutron client object."},{"line_number":1583,"context_line":"        :param port_id: ID of port to retrieve information for."},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"        :return: A tuple of vNIC type, trusted status and network ID. Trusted"},{"line_number":1586,"context_line":"            status only affects SR-IOV ports and will always be None for other"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_53886969","line":1583,"range":{"start_line":1579,"start_character":8,"end_line":1583,"end_character":63},"in_reply_to":"5f7c97a3_b6cb0151","updated":"2018-06-26 09:57:56.000000000","message":"Done","commit_id":"3e2b3d819365598eca4f30e7a8c54dfee27f1556"}]}