)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa5b46b92b16896278596a0ab135b7493e3792b1","unresolved":false,"context_lines":[{"line_number":661,"context_line":"  mode in production environments."},{"line_number":662,"context_line":"\"\"\"),"},{"line_number":663,"context_line":"    cfg.StrOpt(\u0027rng_dev_path\u0027,"},{"line_number":664,"context_line":"               help\u003d\u0027A path to a device that will be used as source of \u0027"},{"line_number":665,"context_line":"                    \u0027entropy on the host. Since libvirt 1.3.4, any \u0027"},{"line_number":666,"context_line":"                    \u0027path (that returns random numbers when read) is \u0027"},{"line_number":667,"context_line":"                    \u0027accepted. The recommended source of entropy is \u0027"},{"line_number":668,"context_line":"                    \u0027``/dev/urandom`` (it is non blocking, therefore \u0027"},{"line_number":669,"context_line":"                    \u0027relatively fast; and avoids the limitations of \u0027"},{"line_number":670,"context_line":"                    \u0027``/dev/random``, which is a legacy interface.)\u0027),"},{"line_number":671,"context_line":"    cfg.ListOpt(\u0027hw_machine_type\u0027,"},{"line_number":672,"context_line":"                help\u003d\u0027For qemu or KVM guests, set this option to specify \u0027"},{"line_number":673,"context_line":"                     \u0027a default machine type per host architecture. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_68bb62c3","line":670,"range":{"start_line":664,"start_character":20,"end_line":670,"end_character":68},"updated":"2018-06-22 16:08:08.000000000","message":"nit: If you need to rework for any reason, you might take the opportunity to reflow this as multi-line string as above","commit_id":"32986d1cad981e0322b898426973f8bb0b552984"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"55346753e305c4ba030087680b07303f82e46999","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    cfg.StrOpt(\u0027rng_dev_path\u0027,"},{"line_number":664,"context_line":"               help\u003d\u0027A path to a device that will be used as source of \u0027"},{"line_number":665,"context_line":"                    \u0027entropy on the host. Permitted options are: \u0027"},{"line_number":666,"context_line":"                    \u0027/dev/random or /dev/hwrng\u0027),"},{"line_number":667,"context_line":"    cfg.ListOpt(\u0027hw_machine_type\u0027,"},{"line_number":668,"context_line":"                help\u003d\u0027For qemu or KVM guests, set this option to specify \u0027"},{"line_number":669,"context_line":"                     \u0027a default machine type per host architecture. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_bb41460d","side":"PARENT","line":666,"range":{"start_line":666,"start_character":41,"end_line":666,"end_character":46},"updated":"2018-06-28 22:10:39.000000000","message":"hmm?","commit_id":"2fb5be45e697bdceea9573e60b8b7417e40a5d4b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cbf86f39acd31ac38d208277b9051d2b3443649b","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    cfg.StrOpt(\u0027rng_dev_path\u0027,"},{"line_number":664,"context_line":"               help\u003d\u0027A path to a device that will be used as source of \u0027"},{"line_number":665,"context_line":"                    \u0027entropy on the host. Permitted options are: \u0027"},{"line_number":666,"context_line":"                    \u0027/dev/random or /dev/hwrng\u0027),"},{"line_number":667,"context_line":"    cfg.ListOpt(\u0027hw_machine_type\u0027,"},{"line_number":668,"context_line":"                help\u003d\u0027For qemu or KVM guests, set this option to specify \u0027"},{"line_number":669,"context_line":"                     \u0027a default machine type per host architecture. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1b171af1","side":"PARENT","line":666,"range":{"start_line":666,"start_character":41,"end_line":666,"end_character":46},"in_reply_to":"5f7c97a3_bb41460d","updated":"2018-06-28 22:16:10.000000000","message":"I was wondering where that came from and I guess I found it in the libvirt docs:\n\n random\n\n    This backend type expects a non-blocking character device as input. The file name is specified as contents of the backend element. Since 1.3.4 any path is accepted. Before that /dev/random and /dev/hwrng were the only accepted paths. When no file name is specified, the hypervisor default is used. For QEMU, the default is /dev/random. However, the recommended source of entropy is /dev/urandom (as it doesn\u0027t have the limitations of /dev/random).","commit_id":"2fb5be45e697bdceea9573e60b8b7417e40a5d4b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6c408779d733c56d52534a6497cd533be9c7fc24","unresolved":false,"context_lines":[{"line_number":661,"context_line":"  mode in production environments."},{"line_number":662,"context_line":"\"\"\"),"},{"line_number":663,"context_line":"    cfg.StrOpt(\u0027rng_dev_path\u0027,"},{"line_number":664,"context_line":"               default\u003d\u0027/dev/urandom\u0027,"},{"line_number":665,"context_line":"               help\u003d\"\"\""},{"line_number":666,"context_line":"The path to an RNG (Random Number Generator) device that will be used as"},{"line_number":667,"context_line":"the source of entropy on the host.  Since libvirt 1.3.4, any path (that"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_3b6696bd","line":664,"updated":"2018-06-28 22:14:09.000000000","message":"This is going to require updating:\n\nhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html\n\nI\u0027ll be damned but our flavor extra specs docs actually even talk about this:\n\nhttps://docs.openstack.org/nova/latest/user/flavors.html#extra-specs","commit_id":"814bfd937238cbd211ea30805c36ae682cfd7b48"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"b162e52cfa0b8febefca28797e1ea44c42ef1716","unresolved":false,"context_lines":[{"line_number":661,"context_line":"  mode in production environments."},{"line_number":662,"context_line":"\"\"\"),"},{"line_number":663,"context_line":"    cfg.StrOpt(\u0027rng_dev_path\u0027,"},{"line_number":664,"context_line":"               default\u003d\u0027/dev/urandom\u0027,"},{"line_number":665,"context_line":"               help\u003d\"\"\""},{"line_number":666,"context_line":"The path to an RNG (Random Number Generator) device that will be used as"},{"line_number":667,"context_line":"the source of entropy on the host.  Since libvirt 1.3.4, any path (that"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_6ab72887","line":664,"in_reply_to":"5f7c97a3_3b6696bd","updated":"2018-07-02 12:22:49.000000000","message":"\u003e This is going to require updating:\n \u003e \n \u003e https://docs.openstack.org/glance/latest/admin/useful-image-properties.html\n\nAh, good point, will do.\n\n \u003e I\u0027ll be damned but our flavor extra specs docs actually even talk\n \u003e about this:\n \u003e \n \u003e https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs\n\nYeah, perhaps deserves a mention there too.","commit_id":"814bfd937238cbd211ea30805c36ae682cfd7b48"}]}