)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4b7a21a0655bbda85fb52129264cc56f8aba3b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Fix the rescue race for vGPU instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When rescueing an instance having a vGPU, we were not using the vGPU."},{"line_number":10,"context_line":"There would then be a race condition during the rescue where the vGPU"},{"line_number":11,"context_line":"could be passed to another instance."},{"line_number":12,"context_line":"Instead, we should just make sure the vGPU would also be in the rescued"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d01d6a62","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":14},"updated":"2018-06-25 10:15:23.000000000","message":"rescuing","commit_id":"56c4111409312dc8511ca58a0ac87bfb8748beaa"}],"doc/source/admin/virtual-gpu.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23035ade7ca56de5c7f7ae6e7b96f5472635603b","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  vGPUs during rescue. During that time, another instance can receive those"},{"line_number":196,"context_line":"  vGPUs. This is a known issue. The recommended workaround is to rebuild an"},{"line_number":197,"context_line":"  instance immediately after rescue. However, rebuilding the rescued instance"},{"line_number":198,"context_line":"  only helps if there are other free vGPUs on the host."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"For XenServer:"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_9be24ad4","side":"PARENT","line":198,"updated":"2018-06-28 22:31:32.000000000","message":"And then here you could note that it\u0027s fixed in Rocky and link to the fix, like in the cells v2 docs:\n\n\"This has been resolved in the Rocky release [1].\"","commit_id":"a0bdebac04af91198cef6beeea8d520212aa33df"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23035ade7ca56de5c7f7ae6e7b96f5472635603b","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. note::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"       All the caveats are related to the Rocky release"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"For libvirt:"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_dbd8c225","line":173,"updated":"2018-06-28 22:31:32.000000000","message":"Hmm, I tend to like how we handle updating fixed caveats in the cells v2 docs: https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#caveats-of-a-multi-cell-deployment\n\nSo can we change this to:\n\n\"This information is correct as of the Queens release. Where improvements have been made or issues fixed, they are noted per item.\"","commit_id":"56c4111409312dc8511ca58a0ac87bfb8748beaa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0403432f06ca8441c94c3ba083e60522bd085f32","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. note::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"       All the caveats are related to the Rocky release"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"For libvirt:"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_db01a26f","line":173,"in_reply_to":"5f7c97a3_dbd8c225","updated":"2018-06-28 22:32:11.000000000","message":"Also, this especially applies if you backport this change to stable/queens which it seems like we should.","commit_id":"56c4111409312dc8511ca58a0ac87bfb8748beaa"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23035ade7ca56de5c7f7ae6e7b96f5472635603b","unresolved":false,"context_lines":[{"line_number":2685,"context_line":"        re-creates the domain to ensure the reboot happens, as the guest"},{"line_number":2686,"context_line":"        OS cannot ignore this action."},{"line_number":2687,"context_line":"        \"\"\""},{"line_number":2688,"context_line":"        # NOTE(sbauza): Since we undefine the guest XML when destroying, we"},{"line_number":2689,"context_line":"        # need to remember the existing mdevs for reusing them."},{"line_number":2690,"context_line":"        mdevs \u003d self._get_all_assigned_mediated_devices(instance)"},{"line_number":2691,"context_line":"        mdevs \u003d list(mdevs.keys())"},{"line_number":2692,"context_line":"        # NOTE(mdbooth): In addition to performing a hard reboot of the domain,"},{"line_number":2693,"context_line":"        # the hard reboot operation is relied upon by operators to be an"},{"line_number":2694,"context_line":"        # automated attempt to fix as many things as possible about a"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7bc96e4f","line":2691,"range":{"start_line":2688,"start_character":8,"end_line":2691,"end_character":34},"updated":"2018-06-28 22:31:32.000000000","message":"OK similar logic here.","commit_id":"56c4111409312dc8511ca58a0ac87bfb8748beaa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0791c627c107665863d3f2a50a81fbc19501f20e","unresolved":false,"context_lines":[{"line_number":2959,"context_line":"        gen_confdrive \u003d functools.partial(self._create_configdrive,"},{"line_number":2960,"context_line":"                                          context, instance, injection_info,"},{"line_number":2961,"context_line":"                                          rescue\u003dTrue)"},{"line_number":2962,"context_line":"        # NOTE(sbauza): Since rescue rescreates the guest XML, we need to"},{"line_number":2963,"context_line":"        # remember the existing mdevs for reusing them."},{"line_number":2964,"context_line":"        mdevs \u003d self._get_all_assigned_mediated_devices(instance)"},{"line_number":2965,"context_line":"        mdevs \u003d list(mdevs.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b036aee6","line":2962,"range":{"start_line":2962,"start_character":37,"end_line":2962,"end_character":47},"updated":"2018-06-25 10:26:22.000000000","message":"nit:recreates","commit_id":"56c4111409312dc8511ca58a0ac87bfb8748beaa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4b7a21a0655bbda85fb52129264cc56f8aba3b0","unresolved":false,"context_lines":[{"line_number":2959,"context_line":"        gen_confdrive \u003d functools.partial(self._create_configdrive,"},{"line_number":2960,"context_line":"                                          context, instance, injection_info,"},{"line_number":2961,"context_line":"                                          rescue\u003dTrue)"},{"line_number":2962,"context_line":"        # NOTE(sbauza): Since rescue rescreates the guest XML, we need to"},{"line_number":2963,"context_line":"        # remember the existing mdevs for reusing them."},{"line_number":2964,"context_line":"        mdevs \u003d self._get_all_assigned_mediated_devices(instance)"},{"line_number":2965,"context_line":"        mdevs \u003d list(mdevs.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1028c283","line":2962,"range":{"start_line":2962,"start_character":37,"end_line":2962,"end_character":47},"updated":"2018-06-25 10:15:23.000000000","message":"recreate","commit_id":"56c4111409312dc8511ca58a0ac87bfb8748beaa"}]}