)]}'
{"nova/tests/functional/api/openstack/placement/gabbits/allocations-1.28.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"07a00b2ba2b70eb67450705c78c9342c8a84cb9f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"      resource_provider_generation: $RESPONSE[\u0027$.generation\u0027]"},{"line_number":184,"context_line":"      traits:"},{"line_number":185,"context_line":"          - MISC_SHARES_VIA_AGGREGATE"},{"line_number":186,"context_line":"          - STORAGE_DISK_SSD"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"- name: set disk inventory"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_013aa496","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":28},"updated":"2018-06-25 22:01:04.000000000","message":"You\u0027re just doing this to avoid getting the disk from the compute node?\n\nThat\u0027s cool; would also be neat to use granular with group_policy\u003disolate instead :)","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7a1af8281639f8c380b18d4f3a5b0e91239b1ad5","unresolved":false,"context_lines":[{"line_number":183,"context_line":"      resource_provider_generation: $RESPONSE[\u0027$.generation\u0027]"},{"line_number":184,"context_line":"      traits:"},{"line_number":185,"context_line":"          - MISC_SHARES_VIA_AGGREGATE"},{"line_number":186,"context_line":"          - STORAGE_DISK_SSD"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"- name: set disk inventory"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_9d1cd013","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":28},"in_reply_to":"5f7c97a3_013aa496","updated":"2018-06-26 08:20:44.000000000","message":"In my simple head sharing and traits is easier to model. Presumably because I was more actively involved in that and have made a placecat. Once I get around to making a placecat with some group_policy stuff my brain will settle.\n\nBut yes, this is to make it so we\u0027re only getting one allocation_request back while still making use of the pre-existing resource provider.","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"07a00b2ba2b70eb67450705c78c9342c8a84cb9f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"- name: compute in aggregate"},{"line_number":205,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/aggregates"},{"line_number":206,"context_line":"  request_headers:"},{"line_number":207,"context_line":"      # avoid generation in aggregates"},{"line_number":208,"context_line":"      openstack-api-version: placement 1.10"},{"line_number":209,"context_line":"  data:"},{"line_number":210,"context_line":"      - 7fade9e1-ab01-4d1b-84db-ac74f740bb42"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_a1c73098","line":207,"range":{"start_line":207,"start_character":6,"end_line":207,"end_character":38},"updated":"2018-06-25 22:01:04.000000000","message":"¿por qué?","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6dc47039924002ca5a679ecf9c588ad440ad3e9f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"- name: compute in aggregate"},{"line_number":205,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/aggregates"},{"line_number":206,"context_line":"  request_headers:"},{"line_number":207,"context_line":"      # avoid generation in aggregates"},{"line_number":208,"context_line":"      openstack-api-version: placement 1.10"},{"line_number":209,"context_line":"  data:"},{"line_number":210,"context_line":"      - 7fade9e1-ab01-4d1b-84db-ac74f740bb42"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_eebada08","line":207,"range":{"start_line":207,"start_character":6,"end_line":207,"end_character":38},"in_reply_to":"5f7c97a3_7d0d26e5","updated":"2018-06-26 20:35:02.000000000","message":"Yeah, it is inconsistent and that\u0027s icky, but I was rushing: I wasn\u0027t initially creating these tests to be actually committed, they were a diagnostic tool. In that context searching back up through history was a pita.\n\nIt was only later that I realized I should push it up in a more formal way and didn\u0027t do much cleanup. Note, for example, the two blank lines at 187 and 188.\n\nWe can do some tidying up later if everyone thinks that\u0027s the right thing to do.","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"955050a6c5d8d94e9bc17c9da056f9f44ad81b2b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"- name: compute in aggregate"},{"line_number":205,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/aggregates"},{"line_number":206,"context_line":"  request_headers:"},{"line_number":207,"context_line":"      # avoid generation in aggregates"},{"line_number":208,"context_line":"      openstack-api-version: placement 1.10"},{"line_number":209,"context_line":"  data:"},{"line_number":210,"context_line":"      - 7fade9e1-ab01-4d1b-84db-ac74f740bb42"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_f7295c9b","line":207,"range":{"start_line":207,"start_character":6,"end_line":207,"end_character":38},"in_reply_to":"5f7c97a3_7de69418","updated":"2018-06-26 13:44:17.000000000","message":"Meh.  Thanks for the explanation.","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"82b2084c15b7ee92ab07a5b9d380181e0f6cb54c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"- name: compute in aggregate"},{"line_number":205,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/aggregates"},{"line_number":206,"context_line":"  request_headers:"},{"line_number":207,"context_line":"      # avoid generation in aggregates"},{"line_number":208,"context_line":"      openstack-api-version: placement 1.10"},{"line_number":209,"context_line":"  data:"},{"line_number":210,"context_line":"      - 7fade9e1-ab01-4d1b-84db-ac74f740bb42"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_7d0d26e5","line":207,"range":{"start_line":207,"start_character":6,"end_line":207,"end_character":38},"in_reply_to":"5f7c97a3_7de69418","updated":"2018-06-26 19:29:52.000000000","message":"while I agree that a) you can do this and b) this is all one thread so.. meh, I think it\u0027s odd that you provide the generation when specifying the aggregates for the sharing provider directly above here but don\u0027t specify it for the compute provider.\n\nI won\u0027t -1 for this, though. Just would prefer it be consistent.","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7a1af8281639f8c380b18d4f3a5b0e91239b1ad5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"- name: compute in aggregate"},{"line_number":205,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/aggregates"},{"line_number":206,"context_line":"  request_headers:"},{"line_number":207,"context_line":"      # avoid generation in aggregates"},{"line_number":208,"context_line":"      openstack-api-version: placement 1.10"},{"line_number":209,"context_line":"  data:"},{"line_number":210,"context_line":"      - 7fade9e1-ab01-4d1b-84db-ac74f740bb42"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_7de69418","line":207,"range":{"start_line":207,"start_character":6,"end_line":207,"end_character":38},"in_reply_to":"5f7c97a3_a1c73098","updated":"2018-06-26 08:20:44.000000000","message":"Because two reasons:\n\na) we don\u0027t care about the generation when adding aggregates from one thread\nb) I didn\u0027t want to read back in the test to find which part of history I needed to inspect to extract the correct generation\n\nand a bonus c) because I can\n\nI can annotate about that if you think that would be a good idea.","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"82b2084c15b7ee92ab07a5b9d380181e0f6cb54c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"# This fails because of bug 1778576"},{"line_number":220,"context_line":"# https://bugs.launchpad.net/nova/+bug/1778576"},{"line_number":221,"context_line":"- name: put that allocation to new consumer"},{"line_number":222,"context_line":"  xfail: True"},{"line_number":223,"context_line":"  PUT: /allocations/55555555-5555-5555-5555-555555555555"},{"line_number":224,"context_line":"  data:"},{"line_number":225,"context_line":"      allocations: $RESPONSE[\u0027$.allocation_requests[0].allocations\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_3df32ee9","line":222,"range":{"start_line":222,"start_character":9,"end_line":222,"end_character":13},"updated":"2018-06-26 19:29:52.000000000","message":"should this be \u0027true\u0027, not \u0027True\u0027, being YAML not Python?","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6dc47039924002ca5a679ecf9c588ad440ad3e9f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"# This fails because of bug 1778576"},{"line_number":220,"context_line":"# https://bugs.launchpad.net/nova/+bug/1778576"},{"line_number":221,"context_line":"- name: put that allocation to new consumer"},{"line_number":222,"context_line":"  xfail: True"},{"line_number":223,"context_line":"  PUT: /allocations/55555555-5555-5555-5555-555555555555"},{"line_number":224,"context_line":"  data:"},{"line_number":225,"context_line":"      allocations: $RESPONSE[\u0027$.allocation_requests[0].allocations\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_0e64f6b1","line":222,"range":{"start_line":222,"start_character":9,"end_line":222,"end_character":13},"in_reply_to":"5f7c97a3_3df32ee9","updated":"2018-06-26 20:35:02.000000000","message":"In yaml 1.2 at least the following are all true: true | True | TRUE \n\nIn some implementations \"on\" is also true.","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"82b2084c15b7ee92ab07a5b9d380181e0f6cb54c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"      user_id: $ENVIRON[\u0027USER_ID\u0027]"},{"line_number":237,"context_line":"      # we just happen to know this is supposed to be 1 here, so shortcutting"},{"line_number":238,"context_line":"      consumer_generation: 1"},{"line_number":239,"context_line":"  status: 204"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_fd1136f9","line":239,"updated":"2018-06-26 19:29:52.000000000","message":"ok, so this works for existing consumers, just not for new consumers. correct?","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6dc47039924002ca5a679ecf9c588ad440ad3e9f","unresolved":false,"context_lines":[{"line_number":236,"context_line":"      user_id: $ENVIRON[\u0027USER_ID\u0027]"},{"line_number":237,"context_line":"      # we just happen to know this is supposed to be 1 here, so shortcutting"},{"line_number":238,"context_line":"      consumer_generation: 1"},{"line_number":239,"context_line":"  status: 204"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_ae2dc246","line":239,"in_reply_to":"5f7c97a3_fd1136f9","updated":"2018-06-26 20:35:02.000000000","message":"seems that way yes","commit_id":"6b56bba8edab4a324280be4093f7370892a1712c"}]}