)]}'
{"placement-api-ref/source/allocation_candidates.inc":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d54c1e5353de3e56de3511eb29bfd07647f88554","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_c5834655","line":33,"updated":"2018-06-26 14:26:39.000000000","message":"I don\u0027t agree with the reorder.  I\u0027m of the opinion that the params should be in logical order, not microversion order.  How do others feel?","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3dc0e97aa54dd146ed676f28d61d8953bdde4c47","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_44fc9c0b","line":33,"in_reply_to":"5f7c97a3_54fc5771","updated":"2018-07-02 16:16:09.000000000","message":"Not easily, no.  I\u0027m talking about the order that \"just makes sense\" to the consumer of the API.  In this case, they want to know about resources, traits, and aggregates; then they want to know about the granular versions of those, and how they interact (group_policy); and then they want to know how to limit the overall result pool.\n\nOr maybe they want to know about resources, traits, and aggregates with their granular equivalents interwoven, i.e.\n\n resources\n resourcesN\n required\n requiredN\n member_of\n member_ofN\n group_policy\n limit\n\nBut in any case having `limit` jammed in the middle of that other stuff doesn\u0027t make intuitive sense.","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f87ea0d4aa42f7b6df836b89a2ab32718ed40c30","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_54fc5771","line":33,"in_reply_to":"5f7c97a3_ac8b3315","updated":"2018-07-02 10:10:59.000000000","message":"IMO, the \"logical\" is unclear. What means \"logical\"?\nCan it be defined explicitly?","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"78e74317c4d44205494c843582554e639eda533a","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_ac8b3315","line":33,"in_reply_to":"5f7c97a3_bd7847f7","updated":"2018-06-29 20:28:19.000000000","message":"I think that wiki article is wrong.  It should at least be worded as a guideline rather than a mandate.  In this case it makes no sense for \u0027limit\u0027 to come right in the middle of the other options.  The options should be in \"logical\" order for people who are reading the reference to figure out how to use the API.  People reading the reference to figure out which microversion accepts which bits have the nice cue from min_version - they don\u0027t *also* need the params to be in microversion order.","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5da7815fe1c5f967c0e7fac5b2f92e81ca6474c1","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_d5a63dc1","line":33,"in_reply_to":"5f7c97a3_c34a35ac","updated":"2018-06-29 16:19:47.000000000","message":"The wiki is talking about things in the body, and limit is in the path, which comes before body parameters in the wiki, so does that mean it comes before stuff in the request body even if it was added in a later microversion? I think there is an argument for categorizing by header/path/query/body and then sorting within those based on microversion.","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cb8be80b2751eed1380b102c206f05437ebd15e2","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_c34a35ac","line":33,"in_reply_to":"5f7c97a3_c5834655","updated":"2018-06-28 01:56:38.000000000","message":"See the \"Parameter Verification\" section in https://wiki.openstack.org/wiki/NovaAPIRef .","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5b3efd27937cc4aec4e820b01d546e99c308c0ab","unresolved":false,"context_lines":[{"line_number":30,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  - resources: resources_query_ac"},{"line_number":33,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":34,"context_line":"  - required: required_traits_unnumbered"},{"line_number":35,"context_line":"  - member_of: member_of_1_21"},{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_bd7847f7","line":33,"in_reply_to":"5f7c97a3_d5a63dc1","updated":"2018-06-29 17:09:22.000000000","message":"The following parameters are all query parameters.\n\n- resources\n- limit\n- required\n- member_of\n- resourcesN\n- requiredN\n- member_ofN\n- group_policy\n\nSo it should be sorted by microversion in the category, shouldn\u0027t it?","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d54c1e5353de3e56de3511eb29bfd07647f88554","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - resources: resources"},{"line_number":50,"context_line":"  - capacity: capacity"},{"line_number":51,"context_line":"  - used: used"},{"line_number":52,"context_line":"  - traits: traits_1_17"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Response Example (microversions 1.12 - )"},{"line_number":55,"context_line":"----------------------------------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_454ad626","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":23},"updated":"2018-06-26 14:26:39.000000000","message":"Following the example of the rest of the doc, perhaps we should split \"1.12 -\" into \"1.12 - 1.16\" and \"1.17 -\".  Thoughts?","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"78e74317c4d44205494c843582554e639eda533a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - resources: resources"},{"line_number":50,"context_line":"  - capacity: capacity"},{"line_number":51,"context_line":"  - used: used"},{"line_number":52,"context_line":"  - traits: traits_1_17"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Response Example (microversions 1.12 - )"},{"line_number":55,"context_line":"----------------------------------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_cc8eaf25","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":23},"in_reply_to":"5f7c97a3_233c48bf","updated":"2018-06-29 20:28:19.000000000","message":"meh, I\u0027m not stuck on this.","commit_id":"c238629e1a0036f70076672c642a260e02156622"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cb8be80b2751eed1380b102c206f05437ebd15e2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - resources: resources"},{"line_number":50,"context_line":"  - capacity: capacity"},{"line_number":51,"context_line":"  - used: used"},{"line_number":52,"context_line":"  - traits: traits_1_17"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Response Example (microversions 1.12 - )"},{"line_number":55,"context_line":"----------------------------------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_233c48bf","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":23},"in_reply_to":"5f7c97a3_454ad626","updated":"2018-06-28 01:56:38.000000000","message":"IMO, it is not good idea.\nThe difference between the response body of version 1.12 and 1.17 is just adding \u0027traits\u0027 parameter.\nThe v1.17 example is enough to explain the response body after v1.12.","commit_id":"c238629e1a0036f70076672c642a260e02156622"}]}