)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"31787873b3bd1d1810e4027471f9874e7f8d6345","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        scheduler_hints \u003d {}"},{"line_number":442,"context_line":"        if \u0027os:scheduler_hints\u0027 in body:"},{"line_number":443,"context_line":"            scheduler_hints \u003d body[\u0027os:scheduler_hints\u0027]"},{"line_number":444,"context_line":"        elif \u0027OS-SCH-HNT:scheduler_hints\u0027 in body:"},{"line_number":445,"context_line":"            scheduler_hints \u003d body[\u0027OS-SCH-HNT:scheduler_hints\u0027]"},{"line_number":446,"context_line":"        create_kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e17c7beb","line":444,"range":{"start_line":444,"start_character":14,"end_line":444,"end_character":40},"updated":"2018-07-05 08:55:21.000000000","message":"Looks like we have no test for this field, can we add same test with \u0027os:scheduler_hints\u0027 before we move them?","commit_id":"4bc819088243d41bb452868120c8d00db1dcc984"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"278a3c86ebcca94c06a52592a80f0908ee000a8d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        scheduler_hints \u003d {}"},{"line_number":442,"context_line":"        if \u0027os:scheduler_hints\u0027 in body:"},{"line_number":443,"context_line":"            scheduler_hints \u003d body[\u0027os:scheduler_hints\u0027]"},{"line_number":444,"context_line":"        elif \u0027OS-SCH-HNT:scheduler_hints\u0027 in body:"},{"line_number":445,"context_line":"            scheduler_hints \u003d body[\u0027OS-SCH-HNT:scheduler_hints\u0027]"},{"line_number":446,"context_line":"        create_kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_44b55318","line":444,"range":{"start_line":444,"start_character":14,"end_line":444,"end_character":40},"in_reply_to":"5f7c97a3_e17c7beb","updated":"2018-07-17 08:15:29.000000000","message":"sure. done.","commit_id":"4bc819088243d41bb452868120c8d00db1dcc984"}],"nova/tests/unit/api/openstack/compute/test_scheduler_hints.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c42ae0b2c87dbfccab05fef138a4d542b458fbcf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            {\u0027different_host\u0027: [\u00279c47bf55-e9d8-42da-94ab-7f9e80cd1857\u0027,"},{"line_number":97,"context_line":"                                \u002782412fa6-0365-43a9-95e4-d8b20e00c0de\u0027]})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _create_server_with_scheduler_hints_bad_request(self, param):"},{"line_number":100,"context_line":"        req \u003d self._get_request()"},{"line_number":101,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":102,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":103,"context_line":"        body \u003d {"},{"line_number":104,"context_line":"            \u0027server\u0027: {"},{"line_number":105,"context_line":"                  \u0027name\u0027: \u0027server_test\u0027,"},{"line_number":106,"context_line":"                  \u0027imageRef\u0027: \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027,"},{"line_number":107,"context_line":"                  \u0027flavorRef\u0027: \u00271\u0027,"},{"line_number":108,"context_line":"            },"},{"line_number":109,"context_line":"            \u0027os:scheduler_hints\u0027: param,"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":112,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":113,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_create_server_bad_hints_non_dict(self):"},{"line_number":116,"context_line":"        self._create_server_with_scheduler_hints_bad_request(\u0027non-dict\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f17303b3","side":"PARENT","line":113,"range":{"start_line":99,"start_character":8,"end_line":113,"end_character":45},"updated":"2018-07-04 07:22:54.000000000","message":"should we also keep this test?","commit_id":"021a2717e389a52da999b377e8398ef33a9bb077"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a75a169ef21ed219b4492206d27ea21e4b647779","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            {\u0027different_host\u0027: [\u00279c47bf55-e9d8-42da-94ab-7f9e80cd1857\u0027,"},{"line_number":97,"context_line":"                                \u002782412fa6-0365-43a9-95e4-d8b20e00c0de\u0027]})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _create_server_with_scheduler_hints_bad_request(self, param):"},{"line_number":100,"context_line":"        req \u003d self._get_request()"},{"line_number":101,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":102,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":103,"context_line":"        body \u003d {"},{"line_number":104,"context_line":"            \u0027server\u0027: {"},{"line_number":105,"context_line":"                  \u0027name\u0027: \u0027server_test\u0027,"},{"line_number":106,"context_line":"                  \u0027imageRef\u0027: \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027,"},{"line_number":107,"context_line":"                  \u0027flavorRef\u0027: \u00271\u0027,"},{"line_number":108,"context_line":"            },"},{"line_number":109,"context_line":"            \u0027os:scheduler_hints\u0027: param,"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":112,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":113,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_create_server_bad_hints_non_dict(self):"},{"line_number":116,"context_line":"        self._create_server_with_scheduler_hints_bad_request(\u0027non-dict\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a339a2a3","side":"PARENT","line":113,"range":{"start_line":99,"start_character":8,"end_line":113,"end_character":45},"in_reply_to":"5f7c97a3_f17303b3","updated":"2018-07-05 14:47:13.000000000","message":"These tests were kept, just in a slightly different format. \n\nSee the tests that begin with \"test_create_server_with_bad\" added here:\n\nhttps://review.openstack.org/#/c/579067/3/nova/tests/unit/api/openstack/compute/test_serversV21.py","commit_id":"021a2717e389a52da999b377e8398ef33a9bb077"}]}