)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"6d3f2b3f42f0a88d04d7a242da5344b1db66a77a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-02 17:47:16 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: add qemu version check when configuring mtu for network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a QEMU check when configuring MTU for ethernet and bridge"},{"line_number":10,"context_line":"interface types. When creating and configuring tap devices, libvirt is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_e18cba3a","line":7,"updated":"2018-07-02 15:56:56.000000000","message":"OCD nit: s/qemu/QEMU/\n\n(I see you\u0027ve actually used all caps in the rest of the commit message :-))","commit_id":"e2d7189f4ff7e4a2697256cf3f695327e1d71db2"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"6d3f2b3f42f0a88d04d7a242da5344b1db66a77a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a QEMU check when configuring MTU for ethernet and bridge"},{"line_number":10,"context_line":"interface types. When creating and configuring tap devices, libvirt is"},{"line_number":11,"context_line":"setting MTU but also configures the virtio-net devices to let it"},{"line_number":12,"context_line":"discovers the MTU used. This QEMU \u0027host_mtu\u0027 option is supported by"},{"line_number":13,"context_line":"QEMU version 2.9 and more."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 1779626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_8174e637","line":12,"updated":"2018-07-02 15:56:56.000000000","message":"nit: s/\"to let it discovers the\"/\"to discover the\"/","commit_id":"e2d7189f4ff7e4a2697256cf3f695327e1d71db2"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ccfc52d7aa1bbeeb386706be235fe969700b2a6e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"MIN_LIBVIRT_VHOSTUSER_MQ \u003d (1, 2, 17)"},{"line_number":52,"context_line":"#  vlan tag for macvtap passthrough mode on SRIOV VFs"},{"line_number":53,"context_line":"MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN \u003d (1, 3, 5)"},{"line_number":54,"context_line":"# setting interface mtu was intoduced in libvirt 3.3, We also need to"},{"line_number":55,"context_line":"# check for QEMU that because libvirt is configuring in same time"},{"line_number":56,"context_line":"# host_mtu for virtio-net, fails if not supported."},{"line_number":57,"context_line":"MIN_LIBVIRT_INTERFACE_MTU \u003d (3, 3, 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f15c71f1","line":54,"range":{"start_line":54,"start_character":54,"end_line":54,"end_character":55},"updated":"2018-07-03 15:46:53.000000000","message":"we","commit_id":"e2d7189f4ff7e4a2697256cf3f695327e1d71db2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ccfc52d7aa1bbeeb386706be235fe969700b2a6e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#  vlan tag for macvtap passthrough mode on SRIOV VFs"},{"line_number":53,"context_line":"MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN \u003d (1, 3, 5)"},{"line_number":54,"context_line":"# setting interface mtu was intoduced in libvirt 3.3, We also need to"},{"line_number":55,"context_line":"# check for QEMU that because libvirt is configuring in same time"},{"line_number":56,"context_line":"# host_mtu for virtio-net, fails if not supported."},{"line_number":57,"context_line":"MIN_LIBVIRT_INTERFACE_MTU \u003d (3, 3, 0)"},{"line_number":58,"context_line":"MIN_QEMU_INTERFACE_MTU \u003d (2, 9, 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d15935fd","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":21},"updated":"2018-07-03 15:46:53.000000000","message":"s/that//","commit_id":"e2d7189f4ff7e4a2697256cf3f695327e1d71db2"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"f3ad6daaaa6d09e4b0d7ec2fa5761dd5806dae68","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _has_min_version_for_mtu(self, host):"},{"line_number":282,"context_line":"        return host.has_min_version(MIN_LIBVIRT_INTERFACE_MTU,"},{"line_number":283,"context_line":"                                    MIN_QEMU_INTERFACE_MTU)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def get_config_802qbg(self, instance, vif, image_meta,"},{"line_number":286,"context_line":"                          inst_type, virt_type, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7404dd18","line":283,"updated":"2018-07-03 06:13:35.000000000","message":"Does this require QEMU vs. XEN checking? 2.9.0 is req for QEMU, i\u0027m not sure if XEN also supports this. I\u0027d expect hv_type\u003dlv_host.HV_DRIVER_QEMU or something like that here?","commit_id":"e2d7189f4ff7e4a2697256cf3f695327e1d71db2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"597833aa936790192b187a85c81950cdca305ff5","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _has_min_version_for_mtu(self, host):"},{"line_number":282,"context_line":"        return host.has_min_version(MIN_LIBVIRT_INTERFACE_MTU,"},{"line_number":283,"context_line":"                                    MIN_QEMU_INTERFACE_MTU)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def get_config_802qbg(self, instance, vif, image_meta,"},{"line_number":286,"context_line":"                          inst_type, virt_type, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2e5124da","line":283,"in_reply_to":"5f7c97a3_7404dd18","updated":"2018-07-03 15:00:08.000000000","message":"Not sure Xen is supporting virtio so that should not be an issue here.","commit_id":"e2d7189f4ff7e4a2697256cf3f695327e1d71db2"}]}