)]}'
{"nova/objects/migrate_data.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d53f728f1481c36378a07de38a07da620c03064f","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        \u0027dest_proc_compat\u0027: fields.StringField(),"},{"line_number":386,"context_line":"        \u0027vol_data\u0027: fields.DictOfNullableStringsField(),"},{"line_number":387,"context_line":"        \u0027vea_vlan_mappings\u0027: fields.DictOfNullableStringsField(),"},{"line_number":388,"context_line":"        \u0027dest_msp_ips\u0027: fields.StringField()"},{"line_number":389,"context_line":"    }"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d685beaf","line":388,"range":{"start_line":388,"start_character":24,"end_line":388,"end_character":44},"updated":"2018-07-02 21:54:52.000000000","message":"Also wonder if this might be better as a ListOfStringsField...","commit_id":"b119af24c040a9c1ee5355c8fea63619d6fc0f11"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"69ff3ab002aa2dbed3fbab4232d53108e3b44ef4","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        \u0027dest_proc_compat\u0027: fields.StringField(),"},{"line_number":386,"context_line":"        \u0027vol_data\u0027: fields.DictOfNullableStringsField(),"},{"line_number":387,"context_line":"        \u0027vea_vlan_mappings\u0027: fields.DictOfNullableStringsField(),"},{"line_number":388,"context_line":"        \u0027dest_msp_ips\u0027: fields.StringField()"},{"line_number":389,"context_line":"    }"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4d18a282","line":388,"range":{"start_line":388,"start_character":24,"end_line":388,"end_character":44},"in_reply_to":"5f7c97a3_d685beaf","updated":"2018-07-10 20:38:32.000000000","message":"I like the StringField best because this will come directly from configuration. So the comma-separated list can be passed directly through to the job parameters. With a ListOfStringField we\u0027d have to parse the configuration option and do some joining when it\u0027s time to send it to the job parameter.","commit_id":"b119af24c040a9c1ee5355c8fea63619d6fc0f11"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"30ee6bbc0088048bff1bbe02a5fc23a2dc5bedfc","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"    \u0027PciDeviceList\u0027: \u00271.3-52ff14355491c8c580bdc0ba34c26210\u0027,"},{"line_number":1139,"context_line":"    \u0027PciDevicePool\u0027: \u00271.1-3f5ddc3ff7bfa14da7f6c7e9904cc000\u0027,"},{"line_number":1140,"context_line":"    \u0027PciDevicePoolList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":1141,"context_line":"    \u0027PowerVMLiveMigrateData\u0027: \u00271.3-79c635ecf61d1d70b5b9fa04bf778a91\u0027,"},{"line_number":1142,"context_line":"    \u0027Quotas\u0027: \u00271.3-40fcefe522111dddd3e5e6155702cf4e\u0027,"},{"line_number":1143,"context_line":"    \u0027QuotasNoOp\u0027: \u00271.3-347a039fc7cfee7b225b68b5181e0733\u0027,"},{"line_number":1144,"context_line":"    \u0027RequestSpec\u0027: \u00271.9-e506ccb22cd7807a1207c22a3f179387\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d6d7febf","line":1141,"range":{"start_line":1141,"start_character":31,"end_line":1141,"end_character":69},"updated":"2018-07-02 21:53:12.000000000","message":"This will need to be updated.","commit_id":"b119af24c040a9c1ee5355c8fea63619d6fc0f11"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"891bfea95b54053fa085166bd9de2d85bee33b0f","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"    \u0027PciDeviceList\u0027: \u00271.3-52ff14355491c8c580bdc0ba34c26210\u0027,"},{"line_number":1139,"context_line":"    \u0027PciDevicePool\u0027: \u00271.1-3f5ddc3ff7bfa14da7f6c7e9904cc000\u0027,"},{"line_number":1140,"context_line":"    \u0027PciDevicePoolList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":1141,"context_line":"    \u0027PowerVMLiveMigrateData\u0027: \u00271.3-79c635ecf61d1d70b5b9fa04bf778a91\u0027,"},{"line_number":1142,"context_line":"    \u0027Quotas\u0027: \u00271.3-40fcefe522111dddd3e5e6155702cf4e\u0027,"},{"line_number":1143,"context_line":"    \u0027QuotasNoOp\u0027: \u00271.3-347a039fc7cfee7b225b68b5181e0733\u0027,"},{"line_number":1144,"context_line":"    \u0027RequestSpec\u0027: \u00271.9-e506ccb22cd7807a1207c22a3f179387\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ecd15858","line":1141,"range":{"start_line":1141,"start_character":31,"end_line":1141,"end_character":69},"in_reply_to":"5f7c97a3_d6d7febf","updated":"2018-07-11 16:34:23.000000000","message":"Done","commit_id":"b119af24c040a9c1ee5355c8fea63619d6fc0f11"}]}