)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"007bc32fcf655ad6e1090ba76f8699e22e4abdd6","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"            raise exception.ImageNotActive(message\u003dmsg)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"        flavor \u003d flavor_obj.Flavor.get_by_name(context,"},{"line_number":1308,"context_line":"                                               kwargs.get(\u0027instance_type\u0027,"},{"line_number":1309,"context_line":"                                                          None))"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        (instances, resv_id) \u003d self.compute_api.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BjsQ%3D","line":1308,"updated":"2013-11-23 16:27:05.000000000","message":"by default the kwargs.get should return None. Do we need this here?","commit_id":"de8ac9a2585a98161c5f2f3c5d83b8cf18d9ef1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"32e05ad8be261daaea38833e5fc13588340b3a58","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"            raise exception.ImageNotActive(message\u003dmsg)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"        flavor \u003d flavor_obj.Flavor.get_by_name(context,"},{"line_number":1308,"context_line":"                                               kwargs.get(\u0027instance_type\u0027,"},{"line_number":1309,"context_line":"                                                          None))"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        (instances, resv_id) \u003d self.compute_api.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BfBU%3D","line":1308,"in_reply_to":"AAAATn%2F%2BfaE%3D","updated":"2013-11-25 15:59:33.000000000","message":"ok, if you do another patch then please remove the None","commit_id":"de8ac9a2585a98161c5f2f3c5d83b8cf18d9ef1b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1400948b4b066e49dfdbeaaa63cebf0d1d0f89e","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"            raise exception.ImageNotActive(message\u003dmsg)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"        flavor \u003d flavor_obj.Flavor.get_by_name(context,"},{"line_number":1308,"context_line":"                                               kwargs.get(\u0027instance_type\u0027,"},{"line_number":1309,"context_line":"                                                          None))"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        (instances, resv_id) \u003d self.compute_api.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BfaE%3D","line":1308,"in_reply_to":"AAAATn%2F%2BjsQ%3D","updated":"2013-11-25 15:06:33.000000000","message":"I was mirroring the way it was before, but no, not technically.","commit_id":"de8ac9a2585a98161c5f2f3c5d83b8cf18d9ef1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9d8a332bd7cba883b7ca0a2ecafb3b264301d856","unresolved":false,"context_lines":[{"line_number":1296,"context_line":"            raise exception.ImageNotActive(message\u003dmsg)"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"        flavor \u003d flavor_obj.Flavor.get_by_name(context,"},{"line_number":1299,"context_line":"                                               kwargs.get(\u0027instance_type\u0027,"},{"line_number":1300,"context_line":"                                                          None))"},{"line_number":1301,"context_line":""},{"line_number":1302,"context_line":"        (instances, resv_id) \u003d self.compute_api.create(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F95cs%3D","line":1299,"updated":"2013-12-04 18:37:43.000000000","message":"the get returns None by default.","commit_id":"48b0d084b974bd04afa46b0f4324e88b022a96c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58da5c2353617132699069fd4454846dfbfc10a1","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"            except exception.NotFound:"},{"line_number":1123,"context_line":"                instances \u003d []"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        for instance in instances:"},{"line_number":1126,"context_line":"            if not context.is_admin:"},{"line_number":1127,"context_line":"                if pipelib.is_vpn_image(instance[\u0027image_ref\u0027]):"},{"line_number":1128,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9OD0%3D","line":1125,"updated":"2013-12-13 21:21:16.000000000","message":"Note to self, now that the instances here are objects everything in this loop should be accessing fields on the instance like an object rather than a dict, i.e. instance.uuid.","commit_id":"4c54b1d660c83325353d4e1a576ef1100fc1d68e"}],"nova/api/ec2/ec2utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"007bc32fcf655ad6e1090ba76f8699e22e4abdd6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        info_cache \u003d instance[\u0027info_cache\u0027] or {}"},{"line_number":167,"context_line":"        nw_info \u003d info_cache.get(\u0027network_info\u0027)"},{"line_number":168,"context_line":"    # Make sure empty response is turned into the model"},{"line_number":169,"context_line":"    if not nw_info:"},{"line_number":170,"context_line":"        nw_info \u003d []"},{"line_number":171,"context_line":"    return get_ip_info_for_instance_from_nw_info(nw_info)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BjsM%3D","line":169,"updated":"2013-11-23 16:27:05.000000000","message":"Why not:\nif nw_info is None:\n\nThe value could be []","commit_id":"de8ac9a2585a98161c5f2f3c5d83b8cf18d9ef1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"32e05ad8be261daaea38833e5fc13588340b3a58","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        info_cache \u003d instance[\u0027info_cache\u0027] or {}"},{"line_number":167,"context_line":"        nw_info \u003d info_cache.get(\u0027network_info\u0027)"},{"line_number":168,"context_line":"    # Make sure empty response is turned into the model"},{"line_number":169,"context_line":"    if not nw_info:"},{"line_number":170,"context_line":"        nw_info \u003d []"},{"line_number":171,"context_line":"    return get_ip_info_for_instance_from_nw_info(nw_info)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BfAQ%3D","line":169,"in_reply_to":"AAAATn%2F%2BfZ0%3D","updated":"2013-11-25 15:59:33.000000000","message":"Yeah, understand that. Worst case would be that one of the instantiations above have set the value to [] and we will just set it again. Not the end of the world","commit_id":"de8ac9a2585a98161c5f2f3c5d83b8cf18d9ef1b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1400948b4b066e49dfdbeaaa63cebf0d1d0f89e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        info_cache \u003d instance[\u0027info_cache\u0027] or {}"},{"line_number":167,"context_line":"        nw_info \u003d info_cache.get(\u0027network_info\u0027)"},{"line_number":168,"context_line":"    # Make sure empty response is turned into the model"},{"line_number":169,"context_line":"    if not nw_info:"},{"line_number":170,"context_line":"        nw_info \u003d []"},{"line_number":171,"context_line":"    return get_ip_info_for_instance_from_nw_info(nw_info)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BfZ0%3D","line":169,"in_reply_to":"AAAATn%2F%2BjsM%3D","updated":"2013-11-25 15:06:33.000000000","message":"This is just de-indenting what was already there.","commit_id":"de8ac9a2585a98161c5f2f3c5d83b8cf18d9ef1b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d93d463b0c0ff74c1ca19b76ddf9f15b02fb65aa","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        nw_info \u003d info_cache.get(\u0027network_info\u0027)"},{"line_number":168,"context_line":"    # Make sure empty response is turned into the model"},{"line_number":169,"context_line":"    if not nw_info:"},{"line_number":170,"context_line":"        nw_info \u003d []"},{"line_number":171,"context_line":"    return get_ip_info_for_instance_from_nw_info(nw_info)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9OU4%3D","line":170,"updated":"2013-12-13 20:16:22.000000000","message":"ah, i must have messed this up before","commit_id":"4c54b1d660c83325353d4e1a576ef1100fc1d68e"}]}