)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f68b07ec6d8d6e46bb014a95d31b3a0d5adb95f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f7c97a3_999609ef","line":15,"updated":"2018-07-10 13:57:05.000000000","message":"Could probably use a \u0027Partial-Bug\u0027 tag here, assuming you\u0027ll want to backport this?","commit_id":"30eec136260bd22d0b5bde806006917b0f97e443"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f4484216f0dbbd32a1a0e26bb31c2e43db0ac13f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f7c97a3_1435e0da","line":15,"in_reply_to":"5f7c97a3_999609ef","updated":"2018-07-10 14:03:09.000000000","message":"Yes it makes sense to backport this serie, done.","commit_id":"30eec136260bd22d0b5bde806006917b0f97e443"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c60bab3223ffd426fa4547f05bb1dbfcbc60c75","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        # instance1, instance2 are consuming 96MiB smallpages"},{"line_number":1387,"context_line":"        self.assertEqual(4, hostusage.cells[0].mempages[0].size_kb)"},{"line_number":1388,"context_line":"        self.assertEqual(24608, hostusage.cells[0].mempages[0].used)"},{"line_number":1389,"context_line":"        # instance3 is consuming 16MiB largepages"},{"line_number":1390,"context_line":"        self.assertEqual(2048, hostusage.cells[0].mempages[1].size_kb)"},{"line_number":1391,"context_line":"        self.assertEqual(10, hostusage.cells[0].mempages[1].used)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4254fec5","line":1388,"range":{"start_line":1388,"start_character":25,"end_line":1388,"end_character":30},"updated":"2018-07-10 10:12:18.000000000","message":"I genuinely can\u0027t figure out where these numbers are coming from. Could you expand them out, please? Something like\n\n  N * M + X - Y","commit_id":"2f1e4d76de2b1920474125e5c958ac193d0295d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"adbdce4494ba07ad615fddad4131b017f5aa370d","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        # instance1, instance2 are consuming 96MiB smallpages"},{"line_number":1387,"context_line":"        self.assertEqual(4, hostusage.cells[0].mempages[0].size_kb)"},{"line_number":1388,"context_line":"        self.assertEqual(24608, hostusage.cells[0].mempages[0].used)"},{"line_number":1389,"context_line":"        # instance3 is consuming 16MiB largepages"},{"line_number":1390,"context_line":"        self.assertEqual(2048, hostusage.cells[0].mempages[1].size_kb)"},{"line_number":1391,"context_line":"        self.assertEqual(10, hostusage.cells[0].mempages[1].used)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8eb9ddcb","line":1388,"range":{"start_line":1388,"start_character":25,"end_line":1388,"end_character":30},"in_reply_to":"5f7c97a3_133adac2","updated":"2018-07-10 13:15:25.000000000","message":"\u003e On the host NUMA node 0 there are 32768 of 4K pages available. 32\n \u003e are already used and instance1,2 are consuming 96MiB which means\n \u003e 96*1024/4 \u003d 24576.\n \u003e \n \u003e 24576 + 32 \u003d 24608\n\nAh, of course: total and used are number of pages - not (k|M|G)b. My bad.\n\nI wonder if it might be possible to insert that as a comment here. If I got caught out by it, I\u0027m sure others will too\n\n \u003e If you remove my change in hardware.py that number will be 0 when\n \u003e we will compute the 2M pages that because we already get the\n \u003e initial hostcell insteadof of the one updated but i think you\n \u003e figured out that point :)\n\nSure...as soon as I realized the above. Thanks :)","commit_id":"2f1e4d76de2b1920474125e5c958ac193d0295d0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ac7d22d7336378674a0d7b8e150d5c4fc6af2a41","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        # instance1, instance2 are consuming 96MiB smallpages"},{"line_number":1387,"context_line":"        self.assertEqual(4, hostusage.cells[0].mempages[0].size_kb)"},{"line_number":1388,"context_line":"        self.assertEqual(24608, hostusage.cells[0].mempages[0].used)"},{"line_number":1389,"context_line":"        # instance3 is consuming 16MiB largepages"},{"line_number":1390,"context_line":"        self.assertEqual(2048, hostusage.cells[0].mempages[1].size_kb)"},{"line_number":1391,"context_line":"        self.assertEqual(10, hostusage.cells[0].mempages[1].used)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e84e498e","line":1388,"range":{"start_line":1388,"start_character":25,"end_line":1388,"end_character":30},"in_reply_to":"5f7c97a3_4254fec5","updated":"2018-07-10 12:06:04.000000000","message":"On the host NUMA node 0 there are 32768 of 4K pages available. 32 are already used and instance1,2 are consuming 96MiB which means 96*1024/4 \u003d 24576.\n\n24576 + 32 \u003d 24608","commit_id":"2f1e4d76de2b1920474125e5c958ac193d0295d0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bf8a0aaf1a571d497eb0f7113c1ef7dca9bb1cd3","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        # instance1, instance2 are consuming 96MiB smallpages"},{"line_number":1387,"context_line":"        self.assertEqual(4, hostusage.cells[0].mempages[0].size_kb)"},{"line_number":1388,"context_line":"        self.assertEqual(24608, hostusage.cells[0].mempages[0].used)"},{"line_number":1389,"context_line":"        # instance3 is consuming 16MiB largepages"},{"line_number":1390,"context_line":"        self.assertEqual(2048, hostusage.cells[0].mempages[1].size_kb)"},{"line_number":1391,"context_line":"        self.assertEqual(10, hostusage.cells[0].mempages[1].used)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b9bf45a9","line":1388,"range":{"start_line":1388,"start_character":25,"end_line":1388,"end_character":30},"in_reply_to":"5f7c97a3_8eb9ddcb","updated":"2018-07-10 13:48:32.000000000","message":"Sure, done.","commit_id":"2f1e4d76de2b1920474125e5c958ac193d0295d0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"617f79a4a2f3df0c8dbd273b17e7edb04777d706","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        # instance1, instance2 are consuming 96MiB smallpages"},{"line_number":1387,"context_line":"        self.assertEqual(4, hostusage.cells[0].mempages[0].size_kb)"},{"line_number":1388,"context_line":"        self.assertEqual(24608, hostusage.cells[0].mempages[0].used)"},{"line_number":1389,"context_line":"        # instance3 is consuming 16MiB largepages"},{"line_number":1390,"context_line":"        self.assertEqual(2048, hostusage.cells[0].mempages[1].size_kb)"},{"line_number":1391,"context_line":"        self.assertEqual(10, hostusage.cells[0].mempages[1].used)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_133adac2","line":1388,"range":{"start_line":1388,"start_character":25,"end_line":1388,"end_character":30},"in_reply_to":"5f7c97a3_e84e498e","updated":"2018-07-10 12:12:22.000000000","message":"If you remove my change in hardware.py that number will be 0 when we will compute the 2M pages that because we already get the initial hostcell insteadof of the one updated but i think you figured out that point :)","commit_id":"2f1e4d76de2b1920474125e5c958ac193d0295d0"}]}