)]}'
{"nova/tests/functional/regressions/test_bug_1780373.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e7e117c2fb4b01da6bc65d315b7ba8c6b902c6cb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.flags(server_group_members\u003d2, group\u003d\u0027quota\u0027)"},{"line_number":42,"context_line":"        self.useFixture(policy_fixture.RealPolicyFixture())"},{"line_number":43,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"},{"line_number":44,"context_line":"        self.useFixture(nova_fixtures.PlacementFixture())"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":47,"context_line":"            api_version\u003d\u0027v2.1\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0fd5a6e6","line":44,"updated":"2018-07-11 17:48:14.000000000","message":"I\u0027ve noticed in this and some other functional tests, we don\u0027t use the CastAsCall fixture even though it seems we should. I guess we just are lucky that the servers finish building before we GET them?","commit_id":"f9874e059df50dc81803fcfdfd1045cc09624894"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ffeb0d238a5f8a67dcaad4574c14155bb426a88","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.flags(server_group_members\u003d2, group\u003d\u0027quota\u0027)"},{"line_number":42,"context_line":"        self.useFixture(policy_fixture.RealPolicyFixture())"},{"line_number":43,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"},{"line_number":44,"context_line":"        self.useFixture(nova_fixtures.PlacementFixture())"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":47,"context_line":"            api_version\u003d\u0027v2.1\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ef94eae9","line":44,"in_reply_to":"5f7c97a3_0fd5a6e6","updated":"2018-07-11 17:58:43.000000000","message":"\u003e I\u0027ve noticed in this and some other functional tests, we don\u0027t use the CastAsCall fixture even though it seems we should.\n\nBecause CastAsCall is not something a real user would experience so unless there is a good reason to use it, I don\u0027t.\n\n\u003e I guess we just are lucky that the servers finish building before we GET them?\n\nWe always create servers before responding from POST /servers with a 202 - the status isn\u0027t ACTIVE so a client would need to poll for that change, but in these tests we don\u0027t care about the server status.","commit_id":"f9874e059df50dc81803fcfdfd1045cc09624894"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"448ae0a0d177914f3531911acfec344f147573ef","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.flags(server_group_members\u003d2, group\u003d\u0027quota\u0027)"},{"line_number":42,"context_line":"        self.useFixture(policy_fixture.RealPolicyFixture())"},{"line_number":43,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"},{"line_number":44,"context_line":"        self.useFixture(nova_fixtures.PlacementFixture())"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":47,"context_line":"            api_version\u003d\u0027v2.1\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_628c7139","line":44,"in_reply_to":"5f7c97a3_ef94eae9","updated":"2018-07-11 18:35:33.000000000","message":"Ah, yep, as discussed on IRC, I was missing that point and was thinking of a time recently when I was working on a functional test that would not work properly without CastAsCall -- and that must have been because there were asserts in my test that depended on the boot process having reach a certain point.\n\nThanks for explaining and apologies for the noise.","commit_id":"f9874e059df50dc81803fcfdfd1045cc09624894"}]}