)]}'
{"nova/volume/cinder.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9c68812f36627fa7cca457cd002413fe37f3924e","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        except cinder_exception.ClientException as ex:"},{"line_number":748,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":749,"context_line":"                # NOTE: It is unnecessary to output BadRequest(400) error log,"},{"line_number":750,"context_line":"                # because operators don\u0027t need to debug such cases."},{"line_number":751,"context_line":"                if getattr(ex, \u0027code\u0027, None) !\u003d 400:"},{"line_number":752,"context_line":"                    LOG.error((\u0027Create attachment failed for volume \u0027"},{"line_number":753,"context_line":"                               \u0027%(volume_id)s. Error: %(msg)s Code: %(code)s\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_315530c3","line":750,"range":{"start_line":750,"start_character":26,"end_line":750,"end_character":66},"updated":"2018-10-09 09:37:55.000000000","message":"I am not sure that it is the best way to suppress the log output in this case.\nHow about outputting the log in the debug level in the 400 case?","commit_id":"d6e0051c8ddd91628bfef8af7f440c50cf58ae7b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5565c575fe883a8339d0213061dd57aa93f964cf","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        except cinder_exception.ClientException as ex:"},{"line_number":748,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":749,"context_line":"                # NOTE: It is unnecessary to output BadRequest(400) error log,"},{"line_number":750,"context_line":"                # because operators don\u0027t need to debug such cases."},{"line_number":751,"context_line":"                if getattr(ex, \u0027code\u0027, None) !\u003d 400:"},{"line_number":752,"context_line":"                    LOG.error((\u0027Create attachment failed for volume \u0027"},{"line_number":753,"context_line":"                               \u0027%(volume_id)s. Error: %(msg)s Code: %(code)s\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_80c14232","line":750,"range":{"start_line":750,"start_character":26,"end_line":750,"end_character":66},"in_reply_to":"3f79a3b5_315530c3","updated":"2018-10-09 20:35:20.000000000","message":"As you know, API validation of JsonSchema rejects any wrong requrests(HTTP400) without any logs.\nI think this case is the same as the above JsonSchema case, because Cinder just validates instead of Nova.\nSo I am not sure we really need to output this log in HTTP400 case.","commit_id":"d6e0051c8ddd91628bfef8af7f440c50cf58ae7b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"33f3d2122acbcbe5e633bc84a1f2a491a1c49503","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        except cinder_exception.ClientException as ex:"},{"line_number":748,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":749,"context_line":"                # NOTE: It is unnecessary to output BadRequest(400) error log,"},{"line_number":750,"context_line":"                # because operators don\u0027t need to debug such cases."},{"line_number":751,"context_line":"                if getattr(ex, \u0027code\u0027, None) !\u003d 400:"},{"line_number":752,"context_line":"                    LOG.error((\u0027Create attachment failed for volume \u0027"},{"line_number":753,"context_line":"                               \u0027%(volume_id)s. Error: %(msg)s Code: %(code)s\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_cd0191b7","line":750,"range":{"start_line":750,"start_character":26,"end_line":750,"end_character":66},"in_reply_to":"3f79a3b5_80c14232","updated":"2018-10-11 00:19:34.000000000","message":"\u003e As you know, API validation of JsonSchema rejects any wrong requrests(HTTP400) without any logs.\n\nOkay. Fair enough.\nI agree with you.","commit_id":"d6e0051c8ddd91628bfef8af7f440c50cf58ae7b"}]}