)]}'
{"nova/tests/functional/api_sample_tests/test_server_migrations.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"751efa0a554af068bdbb4618ca985a3e24e62294","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class ServerMigrationsSampleJsonTestV2_24(test_servers.ServersSampleBase):"},{"line_number":165,"context_line":"    ADMIN_API \u003d True"},{"line_number":166,"context_line":"    microversion \u003d \u00272.24\u0027"},{"line_number":167,"context_line":"    sample_dir \u003d \"server-migrations\""},{"line_number":168,"context_line":"    scenarios \u003d [(\u0027v2_24\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e2b721d7","line":166,"updated":"2018-07-11 18:40:06.000000000","message":"This is the correct way to write samples tests that use microversions \u003e 2.1 and was just an oversight when originally written, so regardless of extending this test class this is the right thing to do.","commit_id":"af14186c38deeb9d766e544888478625f5ac3ddf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bc6e938fab8c95f44f6e93a34fc382dc1744638e","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class ServerMigrationsSampleJsonTestV2_24(test_servers.ServersSampleBase):"},{"line_number":165,"context_line":"    ADMIN_API \u003d True"},{"line_number":166,"context_line":"    microversion \u003d \u00272.24\u0027"},{"line_number":167,"context_line":"    sample_dir \u003d \"server-migrations\""},{"line_number":168,"context_line":"    scenarios \u003d [(\u0027v2_24\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9371d8e2","line":166,"in_reply_to":"5f7c97a3_e2b721d7","updated":"2018-07-12 07:24:51.000000000","message":"True.","commit_id":"af14186c38deeb9d766e544888478625f5ac3ddf"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4ee5b10a0765efab58b8e65ae5f099bf90845d3a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"\"\"setUp method for server usage.\"\"\""},{"line_number":34,"context_line":"        super(ServerMigrationsSampleJsonTest, self).setUp()"},{"line_number":35,"context_line":"        self.uuid \u003d self._post_server()"},{"line_number":36,"context_line":"        self.api.microversion \u003d \u00272.22\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(conductor_manager.ComputeTaskManager, \u0027_live_migrate\u0027)"},{"line_number":39,"context_line":"    @mock.patch.object(db, \u0027service_get_by_compute_host\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_b4936bff","line":36,"updated":"2018-07-14 00:18:48.000000000","message":"Is this the same mistake?","commit_id":"25f73e979c2ede751d04a86e6d2b06cfa6847dd1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3cfb1f0577afffe3eb6fb231a66002111ddbc3a0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"\"\"setUp method for server usage.\"\"\""},{"line_number":34,"context_line":"        super(ServerMigrationsSampleJsonTest, self).setUp()"},{"line_number":35,"context_line":"        self.uuid \u003d self._post_server()"},{"line_number":36,"context_line":"        self.api.microversion \u003d \u00272.22\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(conductor_manager.ComputeTaskManager, \u0027_live_migrate\u0027)"},{"line_number":39,"context_line":"    @mock.patch.object(db, \u0027service_get_by_compute_host\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_17234108","line":36,"in_reply_to":"5f7c97a3_b4936bff","updated":"2018-07-14 02:30:52.000000000","message":"nice catch. \n\nyeah, this also issue. fixed in  - https://review.openstack.org/#/c/582702/","commit_id":"25f73e979c2ede751d04a86e6d2b06cfa6847dd1"}]}