)]}'
{"nova/cmd/status.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1aac2ff09949059b67357b0143080b3241ed1212","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if not mappings:"},{"line_number":530,"context_line":"            # There are no cell mappings so we can\u0027t determine this, just"},{"line_number":531,"context_line":"            # return a warning. The cellsv2 check would have already failed"},{"line_number":532,"context_line":"            # on this."},{"line_number":533,"context_line":"            msg \u003d (_(\u0027Unable to determine request spec migrations without \u0027"},{"line_number":534,"context_line":"                     \u0027cell mappings.\u0027))"},{"line_number":535,"context_line":"            return UpgradeCheckResult(UpgradeCheckCode.WARNING, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9bafa1df","line":532,"updated":"2018-07-24 14:21:12.000000000","message":"yeah, a warning is weird but meh.","commit_id":"e73f828057f8ec3d0693f1c498e59600caf1eeb6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1aac2ff09949059b67357b0143080b3241ed1212","unresolved":false,"context_lines":[{"line_number":544,"context_line":"                meta \u003d MetaData(bind\u003ddb_session.get_engine(context\u003dcctxt))"},{"line_number":545,"context_line":"                instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":546,"context_line":"                instance_records \u003d ("},{"line_number":547,"context_line":"                    select([instances.c.uuid]).select_from(instances).where("},{"line_number":548,"context_line":"                        instances.c.deleted \u003d\u003d 0"},{"line_number":549,"context_line":"                    ).execute().fetchall())"},{"line_number":550,"context_line":"                # For each instance in the list, verify that it has a matching"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9b88016c","line":547,"range":{"start_line":547,"start_character":27,"end_line":547,"end_character":45},"updated":"2018-07-24 14:21:12.000000000","message":"hopefully we only get instance UUIDs, so that\u0027s not a large in-memory list.","commit_id":"e73f828057f8ec3d0693f1c498e59600caf1eeb6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7515d7e21297b2411ddb040a9b404ebeba6b3fb7","unresolved":false,"context_lines":[{"line_number":544,"context_line":"                meta \u003d MetaData(bind\u003ddb_session.get_engine(context\u003dcctxt))"},{"line_number":545,"context_line":"                instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":546,"context_line":"                instance_records \u003d ("},{"line_number":547,"context_line":"                    select([instances.c.uuid]).select_from(instances).where("},{"line_number":548,"context_line":"                        instances.c.deleted \u003d\u003d 0"},{"line_number":549,"context_line":"                    ).execute().fetchall())"},{"line_number":550,"context_line":"                # For each instance in the list, verify that it has a matching"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3513f1b9","line":547,"range":{"start_line":547,"start_character":27,"end_line":547,"end_character":45},"in_reply_to":"5f7c97a3_9b88016c","updated":"2018-07-24 21:23:25.000000000","message":"That\u0027s exactly why I\u0027m only selecting the instances.uuid column in the result set.","commit_id":"e73f828057f8ec3d0693f1c498e59600caf1eeb6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b3033f419cddbe7d10e790b806ce4a07689cf2c","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                        instances.c.deleted \u003d\u003d 0"},{"line_number":549,"context_line":"                    ).execute().fetchall())"},{"line_number":550,"context_line":"                # For each instance in the list, verify that it has a matching"},{"line_number":551,"context_line":"                # request spec in the API DB."},{"line_number":552,"context_line":"                for inst in instance_records:"},{"line_number":553,"context_line":"                    spec_id \u003d ("},{"line_number":554,"context_line":"                        select([request_specs.c.id]).select_from("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b88a631b","line":551,"updated":"2018-07-26 16:16:01.000000000","message":"I guess I would try to pull out batches of 50 reqspecs or something just so we\u0027re not doing N queries to the DB for N instances in the system. But, if it becomes a problem we could change it later I guess.","commit_id":"e73f828057f8ec3d0693f1c498e59600caf1eeb6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"10ad8f4eb72476e0c6805eef97b1acd71384bafb","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                        instances.c.deleted \u003d\u003d 0"},{"line_number":549,"context_line":"                    ).execute().fetchall())"},{"line_number":550,"context_line":"                # For each instance in the list, verify that it has a matching"},{"line_number":551,"context_line":"                # request spec in the API DB."},{"line_number":552,"context_line":"                for inst in instance_records:"},{"line_number":553,"context_line":"                    spec_id \u003d ("},{"line_number":554,"context_line":"                        select([request_specs.c.id]).select_from("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d82f1ff3","line":551,"in_reply_to":"5f7c97a3_b88a631b","updated":"2018-07-26 16:24:06.000000000","message":"True. Note below that we do stop once we find at least one missing reqspec per cell, but if there are none in a given cell it\u0027s less efficient yeah.","commit_id":"e73f828057f8ec3d0693f1c498e59600caf1eeb6"}]}